Repository navigation
Support mandatory Query-prefixed parameters for required queries - #3882
Merged
Ramses Sanchez-Hernandez (ramsessanchez) merged 7 commits intoNov 5, 2026
Conversation
Preserve inherited OpenAPI query inputs and bind verified Kiota query members without changing natural path-ID variant eligibility. Add production-template compiled offline binder, transport, header and genuine confirmation regression coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Ramses Sanchez-Hernandez (ramsessanchez)
requested a review
from a team
as a code owner
October 30, 2026 02:41
This was referenced Oct 30, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep required native string DELETE support unchanged. Pin profile-aware source expectations and exercise normal dependency-free wrapper manifests through the real offline Authentication factory, with exact URI/binder/header/body/prompt and single-closure provenance checks. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This was referenced Nov 3, 2026
Ramses Sanchez-Hernandez (ramsessanchez)
added a commit
that referenced
this pull request
Nov 3, 2026
Run the full queued Kiota 1.36.1 and wrapper Release pipeline on normal target 844672d. Status OK, 70.2 seconds, 531 exports. Regenerate all beta transport calls/projects/manifests with the actual beta service root and three owned DLLs; client output is unchanged. Normal factory proof retains all five grouped alternatives and cloud roots. Explicit known HTTP failures remain: generic headers lost on PATCH204 refetch (#3886), and required @id query binding absent on four retained collection-reference DELETEs (#3882). No unmerged fixes overlaid or source mappings altered. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This was referenced Nov 3, 2026
Expose native required inputs uniformly as Query-prefixed mandatory typed parameters, preserve inherited operation contracts and Kiota wire encoding, and isolate PATCH queries from each refetch GET. Add operation-family, production Bookings, typed transport and binder regression coverage without expanding optional queries or path-ID group eligibility. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The normal authenticated factory retains its global v1.0 BaseAddress even for USGov; generated profile-aware adapters must choose the request's actual cloud/profile without mutating that client. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Kiota 1.36.1 retains an inherited query member when reporting a duplicate operation declaration. Preserve compatible requiredness overrides, but diagnose incompatible required type/serialization overrides before emitting an unusable typed binding. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Ramses Sanchez-Hernandez (ramsessanchez)
merged commit Nov 5, 2026
4eb3ca3
into
powershell-v3
6 checks passed
Ramses Sanchez-Hernandez (ramsessanchez)
deleted the
ramsessanchez-required-delete-query-binding
branch
November 5, 2026 20:40
This was referenced Nov 6, 2026
Ramses Sanchez-Hernandez (ramsessanchez)
added a commit
that referenced
this pull request
Nov 13, 2026
…ion variants (#3875) * Migrate Applications shared cmdlet directives for v3 Review both compatible profiles, preserve structural publishing-profile naming and exact legacy operation-ID absence, and defer the ApplicationId alias. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Translate Applications legacy reference selectors exactly Bridge all seven v1.0 and twelve beta source operations to compatible method/path/IDs. Preserve item-reference neighbors; replace the previous current-ID-only absence audit. Canonical prerequisite helper #3847 accepted the complete bridge read-only, and module regression coverage verifies both source profiles. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Regenerate Applications v1.0 client and cmdlets Run the full Release Kiota 1.36.1 and wrapper pipeline against the compatible v1.0 spec. Client and cmdlet source plus projects remain byte-identical; the generated Kiota lock records the tool update. Compiled module discovery exports 389 cmdlets; migrated-route and retained-neighbor evidence agrees with the reviewed mapping. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Preserve published Applications item-reference nouns Distinguish four beta item-reference DELETE names from their retained collection routes using published command metadata and independently reviewed Microsoft Learn parameter-set evidence. Keep all endpoints available; defer remaining agent-group dispatch collisions to canonical opt-in multi-route support. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Refresh Applications literal evidence on the current target Use current aligned operation IDs and compare the entire original legacy selection against both compatible specs. Remove unmerged bridge-only schema fields, preserve five published collision routes, and document actual 2.38.1 proxy parameter sets/defaults. Strict inventory passes four Mapped and one Deferred group; 103 targeted regressions pass. Beta remains blocked on exact multi-route dispatch, not retired endpoints. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Integrate Applications compatible operation variants Register the reviewed profile and agent GET/count families using the merged shared module API. Preserve all five routes and existing mandatory-ID/default behavior. Migrate tests to separate generation profile context and verify data-on/off ingestion in both compatible profiles; strict inventory and 114 targeted regressions pass. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Regenerate Applications v1.0 on the merged variant generator Run the actual queued full Release Kiota 1.36.1 and wrapper pipeline against compatible spec 088b07a. Status OK, 203.3 seconds, 389 exported cmdlets. Fresh compiled evidence: all 18 migrated suppressions absent, 17 neighbors present, 389/389 raw cmdlet routes match the oracle. Client/spec-lock changes are combined here; generated cmdlets and projects are byte-identical. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Generate complete Applications beta client and cmdlets Run the actual queued full Release Kiota 1.36.1 and wrapper pipeline against compatible spec 0973019. Status OK, 143.1 seconds, 531 exports. Create both previously missing beta projects and combine client, cmdlet and lock output in this commit. Fresh compiled evidence: 23 migrated suppressions absent, 6 structurally named operations, all 5 grouped alternatives and 30 neighbors present; 17 full-module binder/mock-HTTP cases pass without URL fallback. Raw beta naming parity remains a known baseline limitation (0/534; 514 mismatches and 20 no-oracle rows), not a passing normalized comparison. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Pin Applications generated transport profiles after Authentication sync Verify ordinary application GETs and every grouped beta worker emit their actual profile into GetRequestAdapter. Preserve module directives, groups, defaults, aliases and source mappings. Current ordinary strict inventory passes four Mapped and one Deferred group; actual TRX records 116 passing targeted regressions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Regenerate Applications v1.0 for packaged Authentication 2.41.2 Run the full queued Kiota 1.36.1 and wrapper Release pipeline on normal target 844672d. Status OK, 37.3 seconds, 389 exports. Regenerate cmdlets and project with explicit v1.0 transport and only three owned DLLs; client output is unchanged. Preserve all original migration/source and profile commit boundaries. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Regenerate Applications beta for packaged Authentication 2.41.2 Run the full queued Kiota 1.36.1 and wrapper Release pipeline on normal target 844672d. Status OK, 70.2 seconds, 531 exports. Regenerate all beta transport calls/projects/manifests with the actual beta service root and three owned DLLs; client output is unchanged. Normal factory proof retains all five grouped alternatives and cloud roots. Explicit known HTTP failures remain: generic headers lost on PATCH204 refetch (#3886), and required @id query binding absent on four retained collection-reference DELETEs (#3882). No unmerged fixes overlaid or source mappings altered. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Pin Applications required QueryId source contracts Audit effective path-item and operation query metadata in both real compatible specs. Verify all surviving DELETE query routes (two v1.0, four beta), their complete original suppression boundaries, mandatory QueryId declarations, native Kiota Id assignment, and inherited equivalents. Preserve natural-ID groups and defaults; 187 targeted current regressions and ordinary strict inventory pass. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Regenerate Applications v1.0 required query bindings Run the actual full queued Kiota 1.36.1 and wrapper Release pipeline on normal target 4eb3ca3: OK, 62.4 seconds, 389 exports. Combined profile generation adds mandatory QueryId to both retained service-principal policy collection-reference DELETEs; native @id wire names and neighbors remain. Client/project/lock output is genuinely unchanged. Preserve all earlier profile commit boundaries. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Regenerate Applications beta required query bindings Run the actual full queued Kiota 1.36.1 and wrapper Release pipeline on normal target 4eb3ca3: OK, 118.6 seconds, 531 exports. Combined profile generation adds mandatory QueryId for all four surviving collection-reference DELETEs. Client/project/lock output is genuinely unchanged. Fresh normal factory Global/USGov proof verifies nonempty encoded queries, rejected omission/null/empty, bodyless IfMatch/custom-header transport and one-prompt safety. Retain the separately reproduced unmerged #3886 PATCH204 refetch-header failure; no overlays or mapping changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Pin Applications PATCH-only response semantics Document and test that Update-MgApplication returns only its PATCH response: 204 has no object/readback and 200 returns the typed model. Prove generation independently of a sibling GET in both profiles. Preserve all directives, query groups and neighboring operations; actual targeted TRX194pass and strict4Mapped1Deferred verified. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Regenerate Applications v1.0 with PATCH-only results Run full queued Kiota 1.36.1 and wrapper Release pipeline on normal target 6475f3f: OK, 236.0 seconds, 389 exports, then a successful no-incremental Release build. Combined profile generation removes implicit GET/read-back and preserves typed PATCH200 results, query bindings, headers and ShouldProcess. Kiota client/project/locks are genuinely unchanged. Preserve prior migration and profile history. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Regenerate Applications beta with PATCH-only results Run full queued Kiota 1.36.1 and wrapper Release pipeline on normal target 6475f3f: OK, 161.8 seconds, 531 exports, followed by successful no-incremental Release build. Combined beta generation removes automatic GET after PATCH. Fresh real factory Global/USGov proofs pass PATCH204 no-object/one-request and PATCH200 typed-result/one-request with GET403 configured; caller-explicit GET is independent. All four QueryId routes, five grouped read alternatives, headers, safety and normal Authentication ownership remain verified. Client/project/locks genuinely unchanged; earlier history preserved. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N/A - shared required-query correctness support; no linked issue.
Changes proposed in this pull request
Query+ normalized PascalCase parameters:@id->-QueryId,tenantId->-QueryTenantId,$filter->-QueryFilter. Public names are independent of Kiota members:QueryIdassignsrequestConfiguration.QueryParameters.Id, retaining[QueryParameter("%40id")]. No old-Idalias, author flags, route selectors, optional-query expansion, manual URL/request construction, reflection binding or string-cast fallback.(name, location)overrides. Reuse scalar/name machinery; validate public and typed-member collisions independently. Wire ordinary GET/list/item/POST/PATCH/PUT/bodyless DELETE, actions, inline functions, reference reads/writes, scalar/count, delta and media paths. Required standard options replace their optional declaration/binding instead of duplicating it; explicit false/zero values remain valid. Paired GETs retain per-set requirements, and paging/delta links do not replay initial queries.Scope, type contracts and naming
@id: stringQueryId-> KiotaId; full value is encoded query data, not a destination URL.tenantId: string,tenant-id,tenant.name,underscore_nameQueryTenantId,QueryTenantName,QueryUnderscoreName; actual typed member/wire names remain Kiota-owned.$falseand numeric0are supplied values, not absence.Guid,DateTimeOffset, KiotaDate/Time, verified against actual generated members and HTTP URI expansion.$selectisQuerySelect, not an additional optionalPropertydeclaration.Required strings/arrays reject missing/null/empty inputs through PowerShell validation; typed values retain binder/null validation. Query names allow an optional leading
@/$and ASCII alphanumeric segments separated by-,.,_. Collisions are checked against path/body/header/inline/common/reserved members, separately from Kiota query-member collisions. Required$topmust be an integer on paginated emitters.Native Kiota 1.36.1 URI expansion rejects Byte/TimeSpan substitutions even though JSON-body mapping supports them. Therefore binary/base64url/uint8/duration required-query contracts fail generation rather than compile into commands that fail only when invoked. Those actual failures are retained; no conversion fallback was added.
Kiota 1.36.1 also reports duplicate path/operation parameters while retaining the inherited typed query member. Compatible requiredness overrides are supported and exercised. A required override with an incompatible CLR type or serialization contract now fails explicitly instead of binding against that wrong member. Optional-query broadening is not part of this PR.
Delta queries are mandatory only for
DeltaSync; complete resume/nextLink URLs carry their own state. A token-form delta operation with separate required queries is rejected explicitly. Existing authored natural-ID groups do not become query-discriminated groups: their unsupported required-query inputs remain explicit errors.Current target, history and exact Git scope
Target remains normally merged
powershell-v3@844672d7c2238f6b29a208f9ba73fe28e9e29cef(#3891). Original implementation50dc0ce200, normal target merge37a398775e, and refreshed prior head5221c6cce4are preserved. User-directed rescope commits, all additive/coauthored:Current head:
800e4fc65e395ece7dd0edbe9e4ae2c55c01acf6. Same branch/PR/history, normal non-force pushes; no amend/rebase/new PR/merge/approval/bypass.Production scope is eight shared generator files:
CmdletEmitter.cs,CmdletEmitter.Query.cs,CmdletEmitter.MultiRoute.cs(existing reserved-name helper),EmitContext.cs(internal resolved inputs only),PowerShellWrapperGenerationService.cs,.Query.cs,.MutationRoute.csandSchemaProperties.cs.OperationInfoand public authoring configuration remain unchanged. Other paths are the two proof scripts, two YAML fixtures/host, required-query tests/test project, prior narrow MultiRoute profile-literal test correction, and existing crosspath edge-case documentation: 17 paths total relative to target. Nosrc/module/packaging/template/Authentication/runtime/CmdletNaming production delta exists. The former DELETE-only helper/test files are replaced by the generalized query helper/tests within preserved history.Final committed-source acceptance results
Toolchain: .NET 10.0.403, PowerShell 7.6.9, isolated Kiota
1.36.1+fd3bf87790149b87f40f7eae1a5feb9016625943, process-local Kiota parallelism 1. 522 total/executed/passed tests, 0 failed/notExecuted; 67 physically reconciled RequiredQueryTests. The combined selector includes existing emitter/action/function/mutation/generation/group/composite/scalar/naming coverage.All requests terminate at a capture handler AFTER the real offline
Connect-MgGraph+GraphHttpClientFactoryauthentication pipeline; no bare marker-client substitution, live Graph/OAuth or real credential store. Test-only MockDataStore isolates synthetic sessions. Every accepted mutation has one genuine prompt maximum and one mutation request maximum; PATCH may additionally issue its intended 204 GET. Genuine No/WhatIf send zero. Missing/empty/null/invalid types, required bool absence/null/invalid values, empty arrays, old-Id, mixed list/item inputs and missing production Bookings range inputs fail before HTTP.The proofs verify actual query/body/header/result separation, not only generated strings: nested typed POST JSON and false body values, PATCH tenant query followed by ONLY the GET view query, typed PUT/action/reference bodies, bodyless DELETE/read operations, uploaded media bytes, streamed/count/scalar/typed results, initial list queries versus server-owned continuation links, delta sync versus resume, optional Select/Filter/Top behavior, required Count=false/Top=0, arrays, formatted scalar values and adversarial escaping. The actual production
/solutions/bookingBusinesses/{bookingBusiness-id}/calendarViewlist AND item GETs compile from each unmodified same-profile Bookings spec and require QueryStart/QueryEnd while retaining optional Select/Top behavior. This is a bounded two-GET slice, not a full module build or complete inventory claim.PATCH's existing generic-header omission on its refetch remains explicitly recorded as the separate prerequisite; no refetch ETag is replayed. Required-query isolation is independently asserted. No #3886 overlay is included.
Profile/cloud preservation is verified through compiled commands: the REAL factory retains
https://graph.microsoft.com/v1.0/even for USGov, but adapters selecthttps://graph.microsoft.us/betafor the USGov beta requests. Global beta uses/beta, not the factory's/v1.0. Shared client/BaseAddress identity remains unchanged. Foreign-host strings supplied as query data remain encoded on the selected Graph destination; no URI-validation feature was added.The accepted adapted Authentication 2.41.2 root is:
All 64 original payload SHA256s are checked before/after and against all five actual import captures. Shipping source equals merged target 844672; package SHA256
2FC09BFE6B70D313BC56DF8ADCCFB1976FB4E90A1898BF8A916B4B8B792898EB, accepted final-source manifest SHA2560757D880989BF68829EBAD0E923B3DA7D9DDC96130C426ED6F01FC42EF9FDDFD. Each wrapper bin has ONLY its three owned DLLs; normal manifests have no dependency preloads. Each family process has 12 single Auth/Kiota closure identities (typed JSON loads Auth-owned RMS); DELETE processes have 11. Auth/Loader are Default, Core/Kiota/UriTemplate/RMS are in Authentication's context, and all locations belong to that accepted package. No stock gallery/old 2.38/DLL injection/RMS-retention/signing workaround/global installation or environment change.Exact final commands, results and retained evidence
The session-only queue wrapper uses the EXACT SAME four named mutex slots as the unchanged parent full-build queue. All final proof processes ran sequentially, acquired/released slot1 normally, and retained cap1. No consumer full build/regen or consumer wakeup occurred. Each actual Kiota, generator and Release build command, exit, duration and raw log is in the corresponding
commands-results.json/command-*.log. Full reproduction orchestration:$R\Invoke-FinalQueryValidation.ps1(already-used roots must not be overwritten; choose new named roots on rerun).Current acceptance evidence:
$E\verified-summary.json,$E\final-results.json,$E\final-tests.log,$E\final-tests\required-query-final.trx; each of the five named proof directories containsevidence.json, actual generated Kiota builders/cmdlets/projects, compiled binaries/normal manifests, source/input/output/Auth hashes, assembly contexts and HTTP captures. Family proofs also retainrequests.json/checks.json. All checked hashes and counters match current head 800e4fc.DELETE before/after remains literal: baseline
.../members/$ref?@id=EMPTY, new QueryId.../members/$ref?@id=https%3A%2F%2Fgraph.microsoft.com%2Fbeta%2FdirectoryObjects%2Fmember; item and no-query neighbors are unchanged. Baselines are verified copies of the pristine 844672 same-profile generator output, not earlier bare-adapter beta output. Old October DELETE-only-Idevidence and November 5221 refresh evidence remain immutable in their original directories and are historical only.Failures/limits are retained, not relabeled: exploratory compile failures exposed an isolated underscore-member collision and a fixture declaring only void PATCH (fixture corrected to the existing typed-response/runtime204 shape); actual Byte/TimeSpan expansion failures now produce explicit unsupported-query diagnostics. Later checks caught/fixed a test-only interface assignment, a test-only factory/cloud baseline assumption, and an isolated pagination test expectation after adding the override guard. Earlier logs under
$Rand itsverified/confirmeddirectories remain untouched; final acceptance is ONLYcompleteat head800e4fc65e. Existing YamlReader NU1903, obsolete ManagedIdentity warning and Bookings full-spec discriminator warnings remain visible in raw logs; unrelated dependency/schema fixes are out of scope.This PR does not certify full DirectoryManagement/SignIns/Users/Bookings/Calendar regeneration, exhaustive effective required-query inventory, all OpenAPI types, retired routes, new variant eligibility, public aliases, optional query expansion or separate builder/refetch-header fixes. Consumers retain their full supported-profile queued gates after an actual prerequisite merge. PS7/Core only; no Desktop claim or authorization to merge anything.
Other links