Repository navigation
Fix Kiota PostPath typed navigation without renaming operation types - #3881
Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 3 commits into
Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 3 commits into
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 3 commits into
Conversation
Extend the observed request-method property escape without changing operation namespaces, body types or public cmdlet names. Pin actual Financials beta paths and typed navigation neighbors. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Ramses Sanchez-Hernandez (ramsessanchez)
requested a review
from a team
as a code owner
October 30, 2026 02:28
This was referenced Oct 30, 2026
Refresh existing typed PostPath prerequisite onto 844672d without changing its mapping scope. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This was referenced Nov 3, 2026
Keep the normally merged Authentication 2.41.2 profile-aware adapter call while asserting the bounded typed navigation correction. No production mapping, namespace, body or public noun changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This was referenced Nov 3, 2026
This was referenced Nov 3, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
AvoidRequestMethodClashmapping from the observedDelete -> DeletePathto includePost -> PostPath. Kiota 1.36.1 emitsPostPathfor Financials beta's literal journal, purchase-invoice and sales-invoice/postactions; the uncorrected wrappers predict.Post.PostAsyncand fail with three CS1061 errors.microsoft.graph.post, parameterizedpost(value='{value}'), andpostAndSendare unchanged; zero-argumentpost()and intermediate resource/postproperties are escaped. The four-file scope remains naming, regression tests and the existing edge-case catalog only. No module configurations, suppressions, specs, generated files, Authentication, runtime, templates, packaging, reflection or new API flags are changed relative to the actual target.Normally merged target and current evidence
The same branch/PR now normally includes actual
powershell-v3target844672d7c2238f6b29a208f9ba73fe28e9e29cef(#3891). Normal merge commit:2f034c7e7704ebba7351ed4dc058146d1cdebd2f; additive test-only assertion:9585b766e7881f4ac91342f5004dce26509aa10b(current published head). Original mapping commit:c28dff9470df31f0b808382ab24164a78428c872. No amend, rebase, force push or prerequisite overlay.Production input remains
openApiDocs_KiotaCompat\beta\Financials.yml, Git blob82f1d616cff0416dbd226e02268ebdde6fded7b1. Toolchain: .NET SDK 10.0.403, PowerShell 7.6.9/Core only, Kiota1.36.1+fd3bf87790149b87f40f7eae1a5feb9016625943; process-local Kiota parallelism is 1.New proof root (old evidence is retained separately):
The first process-local PSModulePath entry is the exact locally packaged, adapted Authentication 2.41.2 root above, followed by the existing Documents/Program Files PowerShell module paths. Fresh PS7 imports verify its location/version and all 64 original package SHA256s. Another 118 shipping Authentication source hashes match the package producer evidence against our normally merged source. This is not stock gallery 2.41.2 or old 2.38.1. Current target Authentication/runtime/profile-aware generator/template code is preserved; no RMS wrapper retention/preload, dependency copies or old candidate DLL injection.
Focused test results — explicit baseline exception
Result: 459 executed: 458 passed, 1 failed, 0 skipped; exit 1.
MultiRouteTests.SharedVariantsEmitIdenticalSourcesWhenOnlyTheRunProfileChangesstill asserts full source equality at line 266. #3891 intentionally emitsGetRequestAdapter("v1.0")versusGetRequestAdapter("beta"), so that assertion fails. The same exact failure was reproduced separately on an untouched Git archive of actual844672, without this PostPath mapping:Result: 1 executed, 1 failed; exit 1. Original logs/TRX are retained. The coordinator assigned that stale test to a separate shared test-only follow-up; it is not copied into this PR.
Result with only that exact baseline test excluded: 458 passed, 0 failed, 0 skipped; exit 0. This is not claimed as a passing unfiltered/full suite. The existing NU1903 YamlReader warning is unchanged.
Actual Kiota typed compilation and request-information gates
Result: exit 0. Bounded fixture work acquires/releases one of the exact existing four shared generation mutexes, with one Kiota operation stream at a time; the parent's full-module queue script is unchanged.
commands-results.jsonrecords every exact child command, arguments, raw log, expected/actual exit and elapsed time.The baseline generator is built from an untouched Git archive of actual
844672, not the old08e409executable. Both generators use the same three actual production path filters:Generated builders and wrappers compile together using the unchanged current client/module templates and normally merged Runtime/Authentication projects, in Release netstandard2.0:
All 17 Kiota C# source identities are reverified SHA256-identical before/after and against the historical 17-source capture, excluding compiler bin/obj files. Each Financials wrapper changes only
.Post.PostAsync(to.PostPath.PostAsync(; both baseline and corrected wrappers preserveGetRequestAdapter("beta"). Generated C# is never hand-edited.Neighbors cover
PostPath/PostPostRequestBody, existingDeletePath/DeletePostRequestBody, qualified operation/body namespace,postAndSend, zero-argument function, parameterized function constructor/value binding, and intermediate resource navigation. The offline request-information processes verify exact URLs, methods, IDs/function values and typed body JSON; they send no HTTP.Fresh compiled manifest/type-wire gates:
Results: both exit 0. Fresh manifests require Authentication 2.41.2, do not preload dependencies, and import exactly 3 and 7 cmdlets respectively. Both bins carry only their three owned DLLs. All ten compiled public names/GraphRoute methods/paths are asserted; seven mutation WhatIf calls preserve the no-session/no-HTTP guard. Neighbor body CLR contracts resolve to the single Kiota identity owned by the exact Authentication package. Exact assembly paths/load contexts and binary/manifest hashes are retained.
Proof limits: this is current-target bounded framework evidence, not a full Financials module generation/build or a candidate Financials migration. Its unmerged natural-ID configuration is not included or stacked. Full Financials consumer validation remains its owner's work after actual integration of this prerequisite. RequestInformation and WhatIf checks are not claimed as authenticated HTTP transport/mutation acceptance. No live Graph calls. No #3878/#3882/#3886 overlays or other-owner modifications.
Historical evidence: the original
08e409a6aaisolated proof (457 passing cases and before/after compilation) remains under the parentfilesfolder and is not relabeled as new target evidence.attempt-1retains the new proof's first raw run and a harness-only OrderedDictionary sorting comparison failure; the corrected path/SHA256 comparison verified identical inputs. No source or generated-C# repair was used to make that comparison pass.Other links
$proof:artifact-index.json,commands-results.json,verification-summary.json,source-input-hashes.json,authentication-shipping-source-hashes.json,authentication-package-hashes.json,authentication-import.json,financials-client-before-hashes.json,financials-client-after-hashes.json, all raw.log/.exit.txtfiles, both compiled type-wire JSONs, andtests\focused-tests.trx,tests\focused-scope-tests.trx,tests\target-profile-baseline.trx. Fixture scripts/sources, untouched baseline snapshot, actual generated clients/wrappers/templates-derived projects, compiled outputs and historical attempts are preserved in this named proof folder.