Repository navigation
Migrate Migrations shared directives to v3 beta wrappers - #3855
Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 11 commits into
Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 11 commits into
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 11 commits into
Conversation
Review all four subject directives against actual beta specs, preserve source lineage, and pin supported operations and unaffected neighbors. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the full queued compatible-spec Release pipeline with Kiota 1.36.1 and official Authentication 2.38.1: status OK, 13 exports covering 11 surviving operations and two dispatchers. Client C# and generated projects are byte-identical; commit the regenerated client lock alongside cmdlets and their lock, preserving tracked Beta casing. Raw parity remains 0/11 because the baseline emitter uses Mg rather than MgBeta. Compiled exact-route and prefix-normalized name checks cover all 11 surviving operations; all 14 reviewed suppressions are absent. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Ramses Sanchez-Hernandez (ramsessanchez)
requested a review
from a team
as a code owner
October 22, 2026 02:43
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use three GeneratorConfig run settings and separate explicit beta context for naming, suppression, overrides and full-spec service tests with derived data enabled and disabled. Refresh exact compatible operation IDs/spec blob after normal powershell-v3 integration while preserving legacy lineage, all four subject dispositions and the v1 exclusion. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the full queued compatible-spec Kiota+cmdlet Release pipeline against normally merged powershell-v3 including #3849: exit 0, status OK, 135.2 seconds, 13 compiled exports. Kiota 1.36.1; original official Authentication 2.38.1; .NET SDK 10.0.403. All regenerated client/cmdlet source and projects are byte-identical; only the client spec-description hash changes, included in this combined beta generation boundary. Fresh compiled checks preserve 11 unique surviving operations, two GET/List defaults and all 14 suppressions; seven mutation/action WhatIf checks pass. Raw parity remains prefix-only Mg versus MgBeta (0/13 routes), not a parity pass. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Retain the four shared selector dispositions and explicit v1 exclusion. Assert all eleven direct generated calls acquire the beta request adapter with derived data on/off, and record normal Authentication 2.41.2 packaging/profile transport ownership in the module audit. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full four-mutex queued beta Release pipeline on normal844672 target: exit0/statusOK28.3seconds13exports. Regenerate client/cmdlet/projects/manifests with Kiota1.36.1 and approved source-equivalent Authentication2.41.2. Client sources/projects/locks are byte-identical; eleven direct cmdlets now pass beta transport context and the module project prunes every shared dependency, retaining only three ownedDLLs. Retain actual current transport evidence: factory betaURLs/typedGET+bodyPOST/PATCH200/results/actions/binder/WhatIf+declinedConfirm succeed in Global/USGov without client mutation or duplicate Authclosure. Full transport acceptance remains blocked by dropped boundHeaders on PATCH204GET refetch (#3886), not patched here. Raw parity remains known Mg/MgBeta prefix-only0/13. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Retain all shared selector evidence and explicit beta-only scope after normal #3886 integration. Require generated PATCH to use only its own builder/body/headers, no implicit GET or GET-only/readback inputs; 204 returns no object and 200 preserves the actual response. Recheck no required query inputs in this compatible module spec and retain explicit beta adapters/default neighbors. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued beta Release on normally merged6475 target after final source correction: exit0/statusOK152.1seconds13exports. Kiota1.36.1/cap1 and original source-equivalent packaged Authentication2.41.2. Client sources/projects/manifests/locks are byte-identical where unchanged; retain combined fresh client+cmdlet boundary with actual generated PATCH no-implicit-GET and existing GET parameter-validation deltas. Fresh Global/USGov normalmanifest realfactory proofs pass: PATCH204 exactlyone mutation/zeroobjects/noGET while GET403, PATCH200 actualtypedmodelafteronePATCH, explicitGETindependent; all11survivingroutes/14suppressions/defaults/binder/body/actionsafety/cache/lifecycle/normalAuthclosure retained.185targetedtests/4Mapped. Raw publishedparity remains solely Mg/MgBeta prefix0/13, notrawpass. Prior failedrefetchproofs unchanged as history. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N/A: this is the Migrations module's shared-directive migration.
Changes proposed in this pull request
History, scope and commit boundaries
Original migration
477bc868c9and beta generation6bbeb48122, plus all intervening target integrations/corrections, are preserved. Prior head27bf4d1c7297e0f579b64ed2d1620fee3693e515and its 844672 transport exit2/header-loss evidence remain historical and unchanged. The implicit-readback/header-loss expectation was superseded by the user-directed behavior, not relabeled as a pass.Current normal merge:
a1cee6600e55874302fc8da7ec09e3e68969f9ba.Own final source/test/audit correction:
fce63c20023f4b35f3a5cb3b03ef6d84b6a49ede.Separate combined fresh beta generation/head:
120ce884e238761361135f0bdb4e3f3b4f923c4f.The fresh full run regenerates Kiota/client/cmdlets/projects/manifests. Client source/projects/locks are byte-identical; the actual current beta delta removes the Update cmdlet's implicit GET and adds six emitter-generated blank lines in existing GET sources, with no GET parameter-validation behavior change. Existing tracked
wrapper/Betacasing is preserved. No rebases, amendments, force-pushes, prerequisite overlays, new PRs or merges.Current exact input/package identities
c4be453290a9f3c9f264607fbf594676343b958785b5fb01c8a2d204767ed3c04ec0b6979194d16d6475f3f5beb4908d39ea356db32bf1e0fd3273cb2FC09BFE6B70D313BC56DF8ADCCFB1976FB4E90A1898BF8A916B4B8B792898EB; complete 64-file physical payload verified811105ACE57F6967ADFB9B36A52AA85099F250060588118F2978CF136A31CE4F; three owned DLLs with exact normal-bin manifest/DLL equivalenceAuthentication search-path FIRST root is the original normally packaged source-equivalent build at
C:\Users\ramsess\.copilot\session-state\4aa86cf9-d43c-4d2b-a4a3-aeaed01b8f29\files\authentication-v2-sync\final-source\modules. This is not a stock Gallery2.41.2 package or old2.38. Normal manifests require2.41.2 without RequiredAssemblies/ScriptsToProcess; wrapper bins/packages have only module/client/runtime DLLs. A single Auth-owned Kiota/RMS/UriTemplate/Multipart closure is verified with correct package origins/load contexts, without preloads/shims/copies.Runtime-isolation probe correction (same unchanged head; no build/test rerun)
Authentication OnImport in an additional runspace can reset the shared GraphSession datastore. The earlier runtime files/handoff under
post3886-6475-finalare retained unchanged, but their pre-import Mock setup is not post-import memory-isolation proof. This observation alone does not establish credential I/O. Source, Kiota generation, 152.1-second beta full build, 13 exports, and 185-test TRX remain valid and were not rerun or relabeled.The corrected runtime evidence is in
C:\Users\ramsess\.copilot\session-state\1af088f7-c64b-44b4-a5ca-989eae0f9b70\files\post3886-6475-memory-final, with canonicalhandoff.jsonlinking the original full-build/TRX/hash/profile evidence. After the last additional-runspace normal module import and before the first Connect, the probe calls the existing normalSet-MgTestDataStorehelper. It asserts and records the real reflectedGraphSession.Instance.DataStore.GetType().FullNameasMicrosoft.Graph.Authentication.Test.Mocks.MockDataStore: 32 setup/lifecycle guards and 19 per-request HTTP guards in each cloud, including before Connect, context change, reconnect and logout, and after disconnect. A test-only terminal handler verifies the actual shared datastore before every captured request; no package/production/global/loader change.Only the affected runtime probes were rerun, against the same current normal compiled bins/head. Global and USGov both exit0/PASS with all prior typed body/result, independent PATCH204/PATCH200, explicit GET, query/binder, safety/defaults/cloud-root/cache/lifecycle/Auth-closure assertions unchanged. Raw published parity remains the original frozen Mg/MgBeta 0/13 limitation, not rerun or normalized.
Fresh final validation
The command variable $RepoRoot denotes the isolated owner worktree
C:\Users\ramsess\Repos\copilot-worktrees\msgraph-sdk-powershell\ramsessanchez-fantastic-happiness. The command variable $RuntimeEvidence denotesC:\Users\ramsess\.copilot\session-state\1af088f7-c64b-44b4-a5ca-989eae0f9b70\files\post3886-6475-memory-finalfor the corrected runtime-only probes. The command variable $Evidence continues to denote the unchanged full-build/TRX folderC:\Users\ramsess\.copilot\session-state\1af088f7-c64b-44b4-a5ca-989eae0f9b70\files\post3886-6475-final.The same full-build invocation uses process-local isolated Kiota1.36.1+fd3bf87790149b87f40f7eae1a5feb9016625943,
KIOTA_Generation__MaxDegreeOfParallelism=1, and PSModulePath beginning with the approved Authentication root, followed by the existing user/ProgramFiles/PowerShell7 module roots. Fresh-child import confirms exact Auth2.41.2; .NET10.0.403/PowerShell7 Core. No global installs or environment modifications, live Graph/OAuth, or credential store.dotnet build .\tools\WrapperGenerator.Tests\WrapperGenerator.Tests.csproj --no-incremental --no-restore --nologo --verbosity minimaldotnet test .\tools\WrapperGenerator.Tests\WrapperGenerator.Tests.csproj --no-build --no-restore --filter 'FullyQualifiedName~MigrationsDirectiveTests|FullyQualifiedName~CmdletConfiguratorTests|FullyQualifiedName~NamingTests|FullyQualifiedName~RequiredQueryTests' --logger 'trx;LogFileName=targeted.trx' --results-directory $Evidence --nologo --verbosity normal.\tools\Get-WrapperDirectiveMigrationInventory.ps1 -Module Migrations -FailOnUnresolved -OutputPath "$Evidence\strict-inventory.json"& 'C:\Users\ramsess\.copilot\session-state\871a5292-dc5b-423e-8083-5165b0006603\files\Invoke-QueuedModuleBuild.ps1' -RepoRoot $RepoRoot -Module Migrations -ApiVersion beta -Configuration Releasepwsh -NoProfile -NonInteractive -File "$RuntimeEvidence\Test-MigrationsMemoryFinal.ps1" -RepoRoot $RepoRoot -EvidenceRoot $RuntimeEvidence -Environment Global(prescribed local PSModulePath)-Environment USGovpwsh -NoProfile -NonInteractive -File "$Evidence\Pack-MigrationsProof.ps1" -RepoRoot $RepoRoot -EvidenceRoot $Evidencedotnet pack --no-buildfrom the completed full output; three ownedDLLs and exact manifest/bin hashes.pwsh -NoProfile -NonInteractive -File .\tools\Compare-WrapperCmdletNames.ps1 -GeneratedPath .\src\Migrations\wrapper\Beta\Cmdlets -OutLedger "$Evidence\raw-parity-beta.csv"(prescribed local PSModulePath)Real compiled beta acceptance
The corrected cloud runs use actual Connect-MgGraph + the existing MockDataStore reset AFTER final extra-runspace imports + GraphHttpClientFactory authentication middleware with an offline terminal handler, not a bare marker client. Reflected real shared datastore checks are recorded before Connect, every HTTP boundary, request-context changes, reconnect and logout. All exact path IDs remain escaped; beta/cloud roots and shared client/base address are asserted. Typed list/item GETs, supported optional Top/Filter/Select/Sort/Count, typed POST/PATCH JSON/nested bodies and actual results, bodyless DELETE and all four bodyless actions pass. All seven mutations/actions demonstrate WhatIfzeroHTTP and one genuine No prompt/zeroHTTP; invalid models/enums/incompatible Get/List bindings reject beforeHTTP.
For PATCH204, the handler returns403 to every GET: the mutation still succeeds after only one PATCH, returns zero objects, and sends no GET. PATCH200 likewise returns its actual server model after only one PATCH under the forbidden-GET condition. Caller-explicit GET independently forwards its headers/select query and owns its403/result outcome. This module has zero required query operations (whole real compatible spec verified), no authored grouped/composite PATCH alternatives, PUT or media surface; none are invented. PATCH receives no GET-only optional query or new readback flag.
The beta/root/client cache is reused normally; request-context changes and reconnect rebuild it while preserving cloud roots, and disconnect yields NoGraphSession beforeHTTP. Manifest/DLL/package hashes and normal Auth load contexts are captured. These are deterministic offline proofs, not tenant/service certification or all Graph functionality.
Evidence and boundaries
Under the new
C:\Users\ramsess\.copilot\session-state\1af088f7-c64b-44b4-a5ca-989eae0f9b70\files\post3886-6475-final:full-beta.log/full-beta.exit,targeted-build.log/targeted-tests.log/targeted.trx,strict-inventory.json,compiled-beta-Global.json/compiled-beta-USGov.jsonwith raw captures, both cloud logs/exits and assembly identities, complete Auth64/archive/tool/queue provenance, normal manifest/package/input hashes,raw-parity-beta.csv/log/exit, and the original scalarhandoff.json(unchanged). The CURRENT runtime-isolation handoff isC:\Users\ramsess\.copilot\session-state\1af088f7-c64b-44b4-a5ca-989eae0f9b70\files\post3886-6475-memory-final\handoff.json, with correctedcompiled-beta-Global.json/compiled-beta-USGov.json, raw logs/exits,datastore-beta-*.json, assembly identities and the corrected script under that new root. Original prior-target failures/evidence are untouched.Only owned Migrations source/tests/generated output is in the full Git diff (including deletions/renames); no bin/obj/DLL/nupkg/log/session artifacts, v1 module generation, other-owner fixes, unsupported PostPath3881 overlay, or optional-query3897 expansion. This reuses the same open ready PR without merge/approval/protection bypass.
Other links