Repository navigation
Migrate shared DeviceManagement.Enrollment directives to v3 - #3888
Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 18 commits into
Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 18 commits into
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 18 commits into
Conversation
Bridge all eleven beta legacy selector matches, suppress shared cmdlet routes, and preserve neighboring CRUD and derived action names. Record both compatible profiles in the reviewed ledger and keep the original AutoRest directives active. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run full compatible-spec Release generation with Kiota 1.36.1 and Authentication 2.38.1. Client and cmdlet sources plus project files regenerate identically; only the Kiota version lock changes. The compiled module exports 38 cmdlets and parity matches all 34 direct operations plus four dispatchers. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run full compatible-spec Release generation with Kiota 1.36.1 and Authentication 2.38.1, preserving committed Beta directory casing. The module exports 368 cmdlets; all 13 reviewed suppressed routes are absent, and every unaffected baseline route remains. Combined output removes eleven generated cmdlets and refreshes profile locks; surviving sources and project files regenerate identically. Beta parity retains unrelated pre-existing Mg/MgBeta naming mismatches. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use separate explicit profile context with the three-setting GeneratorConfig. Independently validate all eleven original beta operations and the three actual final-unqualified functions, refresh all current IDs and spec blobs, and represent v1.0 as a default reviewed no-match. All 95 targeted tests pass. Actual strict inventory still fails beta's 11 reviewed versus 8 literal matches pending normal #3847 merge; no helper implementation copied. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued compatible Release build with Kiota1.36.1 parallelism1 and official Authentication2.38.1 exits0, statusOK in21.2s, with38 fresh compiled exports. All38 prior routes retained and reviewed PATCH absent; current raw parity38/38 passes. Client/cmdlet/project sources regenerate identically; only spec hash lock changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued compatible Release build with Kiota1.36.1 parallelism1 and official Authentication2.38.1 exits0, statusOK in39.2s, with374 fresh exports. All368 prior compiled routes retained and13 reviewed suppressed routes absent. Current spec adds six restore actions, each compiled with WhatIf/Confirm verified; generated Kiota client, model, cmdlets and lock update together. Preserve Beta casing. Raw parity0/374 remains failing with baseline beta naming differences and new restore rows; three pre-existing direct assignedPrincipals alias functions remain unsupported by the global emitter, not suppressed or claimed exported. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Consume normal #3847 merge604bd968 and remove rejected source-translation ledger fields. Current selector matches all eleven original beta survivors and zero v1.0 operations; retain a finite historical function-path audit in tests. All three ordinary strict mappings pass and all96 targeted tests pass. Preserve shared suppressions, neighboring operations, original directives and client-only parameter-alias limitations. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued compatible-spec Release generation ran after final source commit on normal604bd968 target. Exit0/statusOK in31.9s with38 fresh compiled exports and all prior routes retained. Ordinary strictall3Mapped,96 targeted tests, raw parity38/38 and actual binder/default/no-session safety pass. Client, cmdlets, projects and locks regenerate byte-identically; this empty commit preserves the explicitly required separate profile boundary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued compatible-spec Release generation ran after final source commit on normal604bd968 target. Exit0/statusOK in33.8s with374 fresh exports; all374 prior routes retained and13 reviewed suppressions absent. Actual default/binder/no-session checks and six restore WhatIf/Confirm checks pass. Combined client/cmdlet/project generation is identical except the aligned-spec Kiota hash lock. Preserve Beta casing and existing client-only parameter-alias limits. Raw parity remains0/374:368 pre-existing naming mismatches and6 no-oracle restore rows, not a claimed pass or a naming sweep. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Ramses Sanchez-Hernandez (ramsessanchez)
requested a review
from a team
as a code owner
November 2, 2026 21:43
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued compatible Release build on normal844672 exits0/statusOK in53.4s,38 fresh exports. Regenerate complete Kiota/client/cmdlets/projects/manifests with adapted normal Authentication2.41.2 and Kiota1.36.1cap1. Kiota sources and locks remain identical; generated cmdlets carry explicit v1.0 adapter context and project owns only three wrapper DLLs without dependency preloads. Actual normal factory offline HTTP confirms typed body/results, bodyless DELETE/actions, binder and WhatIf/declinedConfirm zeroHTTP, cloud/profile/cache and single Authentication closure. Selected PATCH204 refetch drops bound generic Headers: actual FAIL retained for unmerged3886; not an all-runtime-pass claim. Ordinarystrict3Mapped/96 targeted testsPASS. Priorhistory retained. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued compatible Release build on normal844672 exits0/statusOK in63.9s,374 fresh exports. Regenerate complete Kiota/client/cmdlets/projects/manifests with adapted normal Authentication2.41.2 and Kiota1.36.1cap1. Kiota sources and locks remain identical; generated cmdlets carry explicit beta adapter context and project owns only three wrapper DLLs without dependency preloads. Preserve committed Beta casing. Actual normal factory offline HTTP preserves beta and USGov roots despite global-v1.0 HttpClient.BaseAddress, shared transport and one Authentication Kiota identity; typed JSON/results and representative safety gates execute. Selected PATCH204 refetch drops bound generic Headers: actual FAIL retained for unmerged3886; no overlay/global fix/all-runtime-pass claim. Preserve client-only direct assignedPrincipals alias limits and raw beta parity mismatches. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add actual same-profile conditionalAccessSettings generation tests in both derived modes: one PATCH, no automatic GET/null fallback, only actual typed result if present, headers and ShouldProcess preserved, no readback switch. Document caller-explicit GET behavior without changing directive/config/ledger selections. Combined170testsPASS and ordinarystrict3Mapped on normal6475. Old844672header-failureproof preserved unchanged; new positive HTTP probes are separate artifacts. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued compatible Release build after ownfinalsourceea87f7a647 on normal6475 exits0/statusOK in87.7s with38fresh exports. Combined client/cmdlet/project/lock generation preserves identical Kiota client and locks; generated mutations remove implicit GET readback and retain native operation headers/queries. No hand-edited generated source. Fresh realFactoryGlobal+USGov gates each15PASS0FAIL: PATCH204 onePATCH/noobject/noGET even with forbiddenGET, PATCH200 actualtypedmodel/onePATCH, independent explicitGETheaders/error/result; typedCRUD/actions, defaults/binders, genuineNo/WhatIf0HTTP, cloud/profile/cache and originalAuth64singleclosure. Prior844672 failure artifacts remain unchanged and are user-superseded, not relabeled. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Original full queued compatible Release build after ownfinalsourceea87f7a647 on normal6475 exits0/statusOK in452.3s with374fresh exports. Preserve separate combined profile boundary, Beta casing, original selection/neighbor coverage. Kiota client/project/locks regenerate byte-identically; emitted mutations remove implicit GET and retain native query/header contracts. No global overlays or hand-edited generated source. Fresh realFactoryGlobal+USGov normal imports each15PASS0FAIL under actual post-import reflected MockDataStore guards: PATCH204 onePATCH/noobject/noGET even with forbiddenGET, PATCH200 actualtypedmodel/onePATCH, independent explicitGETheaders/error/result. TypedCRUD/actions, defaults/binders, genuineNo/WhatIf0HTTP, cloud/profile/cache and singleAuthidentityPASS. Old failed/no-guard proof retained unchanged; only runtime probes corrected, no redundant FULL/source/TRX reruns. Rawbeta naming/oracle limits remain unnormalized. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No linked issue.
Changes proposed in this pull request
src/DeviceManagement.Enrollment/DeviceManagement.Enrollment.mdto the v3 shared configuration. Preserve the active original directives, existing derived naming, neighboring CRUD and owned Autopilot actions. Both v1.0 and beta are required; neither is excluded. Ignoresrc/readme.graph.mdand every profile-local directive. Parameter aliases/transforms and schema/response directives remain deferred; none occur in this shared file. Do not resurrect the excluded Actions module or add naming/collision/schema policies.Current final validation: normal target
6475f3f5beb4908d39ea356db32bf1e0fd3273cb.Normal merge:
8b6dadcf1f7a008a048d8a1d595398d0e7422e18; authored test/doc correction:ea87f7a6470ad79473f4eb98ed4cc9ca106175bb; canonical current head:81d287a5de25352f8c7daf5f7806426b3982f39f.8d2b0a195d83bd4342a9cd7648a80aec12aad4f281d287a5de25352f8c7daf5f7806426b3982f39fThose are builder-reported execution times, excluding shared-slot queue waits. Each full generation ran once, sequentially v1.0 then beta, after final authored changes. Combined Kiota-client/cmdlet/project/lock regeneration preserved byte-identical clients, projects and locks; generated mutations changed in 19 v1.0 / 200 beta files. No generated sources were hand-edited. Existing
Betacasing, all earlier migration/generation boundaries, normal target ancestry and Copilot App coauthors are preserved. No rebase, squash, force-push, unmerged overlay, approval or merge was performed. Full uncapped net Git scope was checked: 444 paths, all module-owned source/generated output plus the module test; no bin/obj/DLL/nupkg/log/TRX artifacts committed.Compatible spec blobs remain unchanged:
e9cde3860c4d6be4cc2aa2ddb02830f0865a3edd7a9b70f01dbfc02a3875149273e2d0835f60cdf3Current evidence locations and isolation correction
Build/source/TRX evidence (
$buildRoot):C:\Users\ramsess\.copilot\session-state\f80169c8-2e6f-4478-bb8e-8ca70a2294c5\files\post3886-6475-final.Canonical corrected runtime/handoff evidence (
$runtimeRoot):C:\Users\ramsess\.copilot\session-state\f80169c8-2e6f-4478-bb8e-8ca70a2294c5\files\post3886-6475-memory-final.An additional runspace's normal Authentication import can reset the shared datastore to DiskDataStore. The corrected probe reapplies the existing
Set-MgTestDataStoreafter the last additional-runspace import and before Connect, then checks the reflected realGraphSession.DataStorebefore HTTP and request-context/reconnect/disconnect/logout. All four canonical runs record 26 actual MockDataStore checks each (104 total), zero failures, with typeMicrosoft.Graph.Authentication.Test.Mocks.MockDataStore. Earlier completed unguarded v1 runtime reports/scripts remain unchanged in$buildRoot; only those affected offline gates were rerun in the new directory. No source, FULL build, TRX or generation reruns were introduced for this probe-only correction. Datastore type alone is not evidence that credential I/O occurred in older runs.Normal Authentication/build environment
PowerShell 7.6.9/Core only; PowerShell 5.1 is explicitly unsupported. The first process-local PSModulePath entry is the exact normally packaged adapted Authentication 2.41.2 root:
C:\Users\ramsess\.copilot\session-state\4aa86cf9-d43c-4d2b-a4a3-aeaed01b8f29\files\authentication-v2-sync\final-source\modules.It is followed by the existing user, Program Files, and PowerShell 7 module paths. Fresh imports verify that exact module root/version. All64 original file SHA256s are verified against
auth-package-hashes.json; physical package SHA256 is2FC09BFE6B70D313BC56DF8ADCCFB1976FB4E90A1898BF8A916B4B8B792898EB. This is not stock Gallery Authentication or old 2.38 acceptance. Normal wrapper manifests require 2.41.2, contain no RequiredAssemblies preloads, and wrapper bins contain exactly their three owned DLLs; Authentication owns the single Kiota/RMS/UriTemplate/Multipart closure.Isolated Kiota:
1.36.1+fd3bf87790149b87f40f7eae1a5feb9016625943, process-localKIOTA_Generation__MaxDegreeOfParallelism=1; PATH starts withC:\Users\ramsess\.copilot\session-state\871a5292-dc5b-423e-8083-5165b0006603\files\tools\kiota. No global installation, package mutation, manual dependency injection or loader shim is used.Exact current commands and outcomes
Both passed exit 0/status OK with the counts/times above. The unchanged four-mutex queue ran the full builder using compatible specs. No SkipKiota, GenerateOnly, NoCollisionData, legacy fallback or NO-CMDLETS substitution. Logs:
$buildRoot\full-v1.0.logandfull-beta.log, each with its exit file.Results: strict all3 Mapped / exit0; 170 executed / 170 passed / 0 failed / 0 not-executed, including 16 module cases, with real scalar counters and raw TRX; isolated inventory regression passed exit0 after full generation stopped writing the worktree. Focused module tests generate the actual conditionalAccessSettings path for both profiles and derived-data modes, asserting one PATCH call, no automatic GET/null fallback, actual-result-only output, headers, ShouldProcess, explicit profile and no readback flags.
All four canonical current runtime commands passed exit0, 15 PASS / 0 FAIL each (60/0 total). Each fresh normal-manifest import uses the real Connect-MgGraph token pipeline, reflected in-memory datastore, real GraphHttpClientFactory, and an offline terminal handler. Each captures 17 terminal requests and five genuine declined-confirmation prompts (68 captures/20 prompts total), with zero live Graph/OAuth requests. They are not bare marker-client substitutes.
Passing cases prove:
/v1.0/. Global/USGov routing, alternating profile adapters, cache reuse, request-context invalidation, reconnect and disconnect preserve transport identity and explicit NoGraphSession behavior.Current query audit resolves all352 referenced parameters to their actual optional definitions and inspects inline/path inputs: no required query operations in either owned compatible profile. There are no invented Query inputs to demonstrate. Optional GET query values round-trip natively; DELETE remains bodyless and no-query neighbors are retained. The generic required-query source suite also passes as part of the combined run.
Raw naming parity remains v1.0 38/38 PASS / exit0, beta0/374 FAIL / exit1: 368 pre-existing naming mismatches (263 prefix-only,105 additional) plus six restore rows absent from the frozen oracle. These known frozen limits are neither normalized nor waived as a raw parity pass; no naming sweep or operation suppression hides them.
Historical evidence and unchanged limits
The earlier #3891/844672 implicit-GET header failures remain untouched under
enrollment-auth-844672. They are user-superseded by the newly merged no-readback contract, not remaining current failures and not old records relabeled PASS. Earlier604bd/08/candidate and unguarded runtime evidence likewise remains intact. Initial migration280914c952, literal-source correctiona71b863343, previous profile boundaries, and all prior coauthors/history are retained.Three direct role-definition assignedPrincipals functions remain unsuppressed but client-only because OData parameter aliases are unsupported; the inherited three are explicitly suppressed by shared directive intent. This is representative offline behavior proof, not tenant certification or all-API coverage. No live Graph calls, Desktop compatibility work, new capability/schema/naming policy, #3881 overlay or #3897 optional-query work is included. Existing YamlReader NU1903/analyzer warnings and verbatim generated comment whitespace remain explicit baseline limits. No wrapper nupkg build is claimed: actual normal generated-manifest/bin proofs are hashed separately from the verified original Authentication package.
Canonical
$runtimeRoot\handoff.jsonrecords actual scalar TRX/strict/profile/runtime/datastore counters, canonical head/merge/correction/separate generation commits, absolute old valid build/TRX references, full uncapped Git scope, spec/source/Auth64/tool/queue/manifest/assembly hashes and artifact paths. Raw logs/exits/captures and actual-store proof files are retained in the two new evidence roots, not committed to the repository.Other links
src/DeviceManagement.Enrollment/DeviceManagement.Enrollment.md,src/DeviceManagement.Enrollment/wrapper/DeviceManagement.Enrollment_directiveMigrationMap.json, andtools/WrapperGenerator.Tests/DeviceManagementEnrollmentDirectiveMigrationTests.cs.