Skip to content

Audit DeviceManagement.Functions shared directives for v3 - #3854

Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 15 commits into
powershell-v3from
ramsessanchez-devicemanagement-functions-v3
Open

Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 15 commits into
powershell-v3from
ramsessanchez-devicemanagement-functions-v3

Conversation

@ramsessanchez

@ramsessanchez Ramses Sanchez-Hernandez (ramsessanchez) commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

N/A - DeviceManagement.Functions shared-directive audit and final existing-PR revalidation.

Changes proposed in this pull request

  • Audit only src/DeviceManagement.Functions/DeviceManagement.Functions.md. Its shared YAML contains a placeholder and zero original shared directives or operation-ID selectors. The reviewed ledger remains mappings: [], and the authored configuration remains empty. No fabricated overrides, suppressions, groups, legacy bridges, API-absence claims or function aliases. All global/profile-local directives and readmes are ignored and untouched. Parameter aliases/transforms and schema/response customizations outside the shared file remain deferred. DeviceManagement.Actions is unchanged.
  • Normally integrate final powershell-v3 6475f3f5beb4908d39ea356db32bf1e0fd3273cb (Remove automatic GET after successful PATCH #3886 and merged Support mandatory Query-prefixed parameters for required queries #3882), preserving all earlier history. Pin the actual compatible operation inventory: v1.0 has 3 GET functions; beta has 13 GET functions; neither contains PATCH or required query parameters, including inherited declarations. Inline function arguments remain mandatory path inputs, and optional OData names/aliases remain unchanged. Preserve exact IDs, structural/derived names, both permission overloads, all neighbors and committed wrapper/Beta casing. PATCH204/no-readback behavior is not applicable to this GET-only module; no mutation, forced RMS load or new collection/query feature is invented.
  • Force-rebuild current generator/tests, run real targeted TRX/ordinary strict inventory, then perform complete queued generation/Release builds v1.0 then beta. Fresh normal-manifest imports verify all functions, real authenticated factory transport and typed GET behavior in Global and USGov. Follow the runtime-isolation addendum with a runtime-only rerun that reflects and guards the actual shared MockDataStore after all imports and before/after HTTP and lifecycle/logout. Keep the same PR/head, existing readiness, original source, builds, TRX and prior proofs unchanged; no merge or new PR.

Preserved history and final commit boundaries

Original audit/profile commits (f1b32e9aa6, 6215c09278, 8faea2e59c), post-3849 corrections/generations (4b2ab87699, 19eee56ad6, 0db2609c0c) and Authentication3891 work (758e996ba3, 4e4ddafec1, b6639e6957, 33d47f0648) remain intact.

Final commit Purpose
98dda93cf3c679a98fbcc49bb7b7c0c8c0e1a33f Normal target merge of 6475f3f5 into the existing branch
bd307e54273664ebe0a514f8139cd23ae6a517a7 Owned source/test audit of actual GET-only/no-required-query contracts
d239cafc2db49cc9ed262d779f7b0a5f18324f3d Separate combined v1.0 full-generation boundary, explicitly empty because regenerated committable output is identical
b774673608ec37cc21b9175ff34865920b2b99b8 Separate combined beta full-generation boundary, explicitly empty because regenerated committable output is identical; current head

Both final runs freshly generated client/cmdlet/project/lock/normal manifests. Client/cmdlet/project/lock output is equivalent after Git normalization, so the two empty commits preserve the requested combined generation boundaries without fabricated changes. Authored/generation commits include the Copilot App co-author trailer. Complete local Git scope, including any deleted/renamed paths, was checked: only owned Functions source/tests/generated outputs differ from the target. No Authentication/runtime/generator/template/other-module patches, binaries, bin/obj, packages or session logs are committed.

Final target and tooling evidence

Only the new 6475 artifacts below are final-target evidence. Old 08e409, 844672 and pre-guard runtime proofs remain historical, unmodified and are not relabeled.

PowerShell 7.6.9/Core, .NET SDK 10.0.403, isolated Kiota 1.36.1+fd3bf87790149b87f40f7eae1a5feb9016625943, process-local Kiota model parallelism 1. Acceptance uses the adapted normally packaged Authentication 2.41.2 whose shipping source matches the normal target, not stock Gallery/old2.38/shims/preloaded/copied dependencies.

First process-local PSModulePath root:

C:\Users\ramsess\.copilot\session-state\4aa86cf9-d43c-4d2b-a4a3-aeaed01b8f29\files\authentication-v2-sync\final-source\modules

Existing Documents/Program Files/PowerShell 7 module roots follow. Fresh child import location/version, all 64 file SHA256s and the physical Authentication package SHA256 2FC09BFE6B70D313BC56DF8ADCCFB1976FB4E90A1898BF8A916B4B8B792898EB are verified. Each normal wrapper manifest requires Authentication2.41.2, has no dependency preloads/RequiredAssemblies, and each bin contains exactly its own module/client/runtime DLLs. Loaded Auth/Kiota/UriTemplate identities come from the single normal package and correct isolated contexts; RMS/Multipart are packaged but not force-loaded or mutation-certified here.

$repo = 'C:\Users\ramsess\Repos\copilot-worktrees\msgraph-sdk-powershell\ramsessanchez-fluffy-tribble'
$buildProof = 'C:\Users\ramsess\.copilot\session-state\119ea141-d2a1-4a04-9aed-ab00d3bc10f9\files\post3886-6475-final'
$runtimeProof = 'C:\Users\ramsess\.copilot\session-state\119ea141-d2a1-4a04-9aed-ab00d3bc10f9\files\post3886-6475-memory-final'

Exact validation commands and outcomes

dotnet build .\tools\WrapperGenerator.Tests\WrapperGenerator.Tests.csproj -c Release --no-restore --no-incremental --nologo --verbosity quiet
# PASS exit0: forced generator/test rebuild after final owned changes; 0 errors.
dotnet test .\tools\WrapperGenerator.Tests\WrapperGenerator.Tests.csproj -c Release --no-build --no-restore --filter 'FullyQualifiedName~DeviceManagementFunctionsDirectiveMigrationTests|FullyQualifiedName~CmdletConfiguratorTests|FullyQualifiedName~NamingTests|FullyQualifiedName~RequiredQueryTests' --logger 'trx;LogFileName=targeted.trx' --results-directory $buildProof --nologo --verbosity quiet
# PASS exit0: actual TRX total=167, executed=167, passed=167, failed=0, notExecuted=0.
.\tools\Get-WrapperDirectiveMigrationInventory.ps1 -Module DeviceManagement.Functions -FailOnUnresolved
# PASS: ordinary strict inventory rows/mapped/deferred/unresolved=0; reviewed mappings=[].
& "$buildProof\Invoke-FullBuild.ps1" -RepoRoot $repo -ApiVersion v1.0
# PASS full queue/builder exit0, Status OK, module104.3s, 3 compiled exports.
& "$buildProof\Invoke-FullBuild.ps1" -RepoRoot $repo -ApiVersion beta
# PASS full queue/builder exit0, Status OK, module108.9s, 13 compiled exports.

The retained helper sets and verifies the environment above and calls the unchanged four-mutex Invoke-QueuedModuleBuild.ps1 -RepoRoot $repo -Module DeviceManagement.Functions -ApiVersion <profile> -Configuration Release, which invokes the complete normal builder against openApiDocs_KiotaCompat. v1.0 ran before beta. No SkipKiota, GenerateOnly, NoCollisionData, legacy fallback or NO-CMDLETS acceptance. Queue elapsed time and module build seconds are recorded separately.

Profile Full exit / status Module seconds Fresh exports / exact compiled GET routes Current compatible spec blob
v1.0 0 / OK 104.3 3 / 3 76896f6c6f954fbe1f1474a6dac925dc66b79e37
beta 0 / OK 108.9 13 / 13 a27fdd5c9e3a5e09c2914e8c07ba48732e89f5da

The targeted suite includes required-query framework regressions but is not a full-suite or owned PATCH claim. Actual module tests prove no required query declarations, so mandatory Query<Name> acceptance is inapplicable here; optional standard OData names/aliases and function path inputs remain unchanged. No optional-query3897 work or unmerged3881 overlay.

Guarded normal-manifest, real-factory offline acceptance

The four corrected runtime commands use the same completed bins/head. No source, generation, FULL build, TRX, queue, package or production code was changed for the isolation addendum:

pwsh -NoProfile -NonInteractive -File "$runtimeProof\Test-CompiledFunctions.ps1" -RepoRoot $repo -ApiVersion v1.0 -Environment Global
# PASS exit0: 3 exports/routes, 6 authenticated GET captures + typed results, 4 invalid binders, 25 actual datastore guards.
pwsh -NoProfile -NonInteractive -File "$runtimeProof\Test-CompiledFunctions.ps1" -RepoRoot $repo -ApiVersion v1.0 -Environment USGov
# PASS exit0: same counters, exact USGov/v1.0 requests and 25 datastore guards.
pwsh -NoProfile -NonInteractive -File "$runtimeProof\Test-CompiledFunctions.ps1" -RepoRoot $repo -ApiVersion beta -Environment Global
# PASS exit0: 13 exports/routes, 8 authenticated GET captures + typed results, 4 invalid binders, 29 datastore guards.
pwsh -NoProfile -NonInteractive -File "$runtimeProof\Test-CompiledFunctions.ps1" -RepoRoot $repo -ApiVersion beta -Environment USGov
# PASS exit0: same counters, exact USGov/beta requests and 29 datastore guards.

The actual reflected shared GraphSession.DataStore.GetType().FullName is Microsoft.Graph.Authentication.Test.Mocks.MockDataStore at all 108 recorded guard points. The existing normal Set-MgTestDataStore helper runs after normal module imports; no additional runspace module import follows. Guards check actual shared-session identity and store type before/after each HTTP call, Connect, request-context change, reconnect and Disconnect/logout. Old unguarded runtime reports/handoff stay unchanged. Datastore-type observation alone is not evidence that credential I/O occurred in a prior probe.

Normal Connect-MgGraph sessions use the existing in-memory store, synthetic tokens, real GraphHttpClientFactory authentication handler and an offline terminal handler. No bare marker client, live Graph/OAuth/credential-store interaction or dependency injection is used. 28 authenticated GET captures/typed results, 16 missing/null/empty/invalid binder cases before HTTP, 0 off-host/live-network requests. All owned compiled function names/routes and mandatory inline argument metadata are checked. Representative requests prove nested scoped permission collections, beta parameterless primitive-string permissions, analytics/Boolean enrollment and typed role-scope tags. Filter/Search/Top/Skip/Count and existing Select/Expand/OrderBy aliases bind to native wire queries; per-request Headers are preserved. URL-like encoded function arguments stay on the selected cloud host. Factory BaseAddress remains global/v1.0 while generated beta/USGov requests use their correct roots; cache reuse, request-context replacement, new-token reconnect and disconnected NoGraphSession behavior pass.

This GET-only audit does not certify PATCH204/PATCH200, implicit readback, mutation bodies/RMS, WhatIf/Confirm, DELETE query behavior, all APIs or live service validity. #3886's new one-operation PATCH contract applies where PATCH actually exists; no mutation is invented in Functions.

Honest unchanged raw parity and retained evidence

pwsh -NoProfile -NonInteractive -File .\tools\Compare-WrapperCmdletNames.ps1 -GeneratedPath .\src\DeviceManagement.Functions\wrapper\v1.0\Cmdlets -OutLedger "$buildProof\parity-v1.0.csv"
# Exit1 baseline limitation: 1/3 matches; 2 existing mismatches.
pwsh -NoProfile -NonInteractive -File .\tools\Compare-WrapperCmdletNames.ps1 -GeneratedPath .\src\DeviceManagement.Functions\wrapper\Beta\Cmdlets -OutLedger "$buildProof\parity-beta.csv"
# Exit1 baseline limitation: 0/13 matches; 11 existing mismatches and 2 no-oracle rows.

No beta-prefix normalization or unrelated naming repair is used to manufacture a parity pass. Existing Invoke-MgExperienceDeviceManagement derived naming remains. The existing NU1903 YamlReader warning is retained.

Canonical current handoff: $runtimeProof\handoff.json, with actual scalar counts, live PR/head, original full-build/TRX/strict paths+hashes, current profile commits/specs, Auth64/physical package identities, normal manifests/three-DLL hashes, all guarded HTTP/context results and complete uncapped Git scope. actual-datastore-guards.json records actual guard types/stages. $buildProof\handoff.json and all prior raw outputs remain preserved; only runtime evidence is superseded. No extra wrapper pack was requested. Generator pre-build DLL hashes are retained separately from immutable source hashes: normal dotnet-run rebuilds stamp current Git HEAD in AssemblyInformationalVersion, documented in generator-binary-provenance.json rather than relabeling binaries as unchanged source.

Other links

Record the empty shared directive inventory and exact compatible-spec evidence without inventing overrides. Pin real v1.0 and beta function routes, existing derived names, and unaffected suppression decisions.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the complete queued Release pipeline with Kiota 1.36.1 and official Authentication 2.38.1. The freshly generated client and cmdlets compile and export three commands. Only the client lock version differs; generated source and projects are otherwise byte-equivalent after Git line-ending normalization. Existing oracle name mismatches remain outside this empty shared-directive audit.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the complete queued Release pipeline with Kiota 1.36.1 and official Authentication 2.38.1. The freshly generated client and cmdlets compile and export thirteen commands. Only client/cmdlet lock provenance changes; generated source and projects remain equivalent after Git line-ending normalization. Preserve the existing Beta output tree casing and pre-existing command names.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Adapt module naming, suppression and full-spec service regression calls to the normally merged GeneratorConfig API, explicitly passing the derived-data profile separately in both profiles and raw mode. Refresh aligned operation IDs and current compatible-spec audit hashes without changing shared directives, authored overrides or neighboring function names.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Re-run the complete queued Kiota 1.36.1 and wrapper Release pipeline against powershell-v3 08e409a with official Authentication 2.38.1. Exit 0, Status OK, 70.3 seconds, three fresh manifest exports, all three exact compiled GET routes and both mandatory inline arguments verified. Client/cmdlet source and projects are unchanged after Git normalization; the client spec-description hash is refreshed for aligned operation IDs. Retain the two pre-existing raw parity mismatches.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Re-run the complete queued Kiota 1.36.1 and wrapper Release pipeline against powershell-v3 08e409a with official Authentication 2.38.1. Exit 0, Status OK, 109.8 seconds, thirteen fresh manifest exports, all thirteen exact compiled GET routes and both mandatory inline arguments verified. Client/cmdlet source and projects are unchanged after Git normalization; the client spec-description hash is refreshed for aligned operation IDs. Preserve Beta casing, eleven raw parity mismatches and two no-oracle rows without inventing naming overrides.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Normally integrate Authentication 3891 and assert every owned generated GET function passes the separate runtime profile to GetRequestAdapter in both oracle modes. Refresh the shared audit for the Authentication 2.41.2 dependency ownership without changing original function IDs, parameters, names or empty authored configuration.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the complete mutex-queued Release client and cmdlet pipeline against normally merged 844672d with adapted source-equivalent Authentication 2.41.2 (64 package SHA256s verified) and Kiota 1.36.1/cap1. Exit 0, OK, 18.4 seconds, three compiled exports. Regenerated commands pass the v1.0 runtime profile and the project prunes all non-owned dependencies; normal manifest requires Authentication 2.41.2 without preloads and bin contains only three owned DLLs. Client and lock output remain equivalent. Offline Global/USGov GET tests preserve typed results and query/binder semantics, not mutation or live-service claims.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the complete mutex-queued Release client and cmdlet pipeline after v1.0 against normally merged 844672d with adapted source-equivalent Authentication 2.41.2 and Kiota 1.36.1/cap1. Exit 0, OK, 25.1 seconds, thirteen compiled exports. Regenerated commands pass the beta runtime profile and the project prunes all non-owned dependencies; normal manifest requires Authentication 2.41.2 without preloads and bin contains only three owned DLLs. Preserve Beta casing, client/lock equivalence and every existing function name/parameter/alias. Real factory offline Global/USGov GET tests verify beta service roots, primitive/scoped permissions, typed neighbors, query aliases and binder errors; raw naming parity limitations remain explicit.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
… merge

Pin that both actual compatible Functions documents contain only GET functions with no inherited or operation-local required query inputs. Preserve inline mandatory arguments, optional OData binding, original operation IDs, derived names and the empty authored directive ledger. Record final normal powershell-v3 6475f3f context without inventing PATCH or implicit-readback coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Fresh complete mutex-queued Kiota/client/cmdlet/project/lock/manifest Release pipeline on normally merged powershell-v3 6475f3f, Auth2.41.2 package64 hashes and physical nupkg verified, Kiota1.36.1 cap1. Exit0 StatusOK, module time104.3s, three actual compiled exports. Committable generated client, cmdlets, projects and locks are identical after Git normalization, so this explicitly empty commit preserves the required v1.0 generation boundary without fabricated deltas. Fresh normal-manifest real-factory Global/USGov GET proof passes exact routes, typed results, optional query/binder/cache/context/reconnect semantics. Actual specs have no PATCH or required queries; no mutation/refetch/forced-RMS coverage claimed.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Fresh complete sequential beta mutex-queued Kiota/client/cmdlet/project/lock/manifest Release pipeline on normally merged powershell-v3 6475f3f, adapted normal Auth2.41.2 complete64file manifest and physical package verified, Kiota1.36.1 cap1. Exit0 StatusOK, module time108.9s, thirteen actual compiled exports. Committable generated client/cmdlet/project/lock output is identical after Git normalization, so this explicitly empty commit preserves the required combined beta generation boundary. Fresh real-factory Global/USGov GET proof preserves typed primitive/scoped permissions, neighbors, optional aliases/queries, inline binders and profile/cloud cache/context/reconnect semantics. No PATCH or required query operations exist in actual Functions specs; no invented mutation/refetch/forced-RMS proof.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant