Repository navigation
Migrate shared Identity.SignIns directives and regenerate v3 wrappers - #3904
Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 15 commits into
Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 15 commits into
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 15 commits into
Conversation
Review all nine shared cmdlet groups against actual v1.0 and beta legacy and compatible specifications. Preserve partial authentication-strength variants, structural and derived naming, and deferred response/parameter behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the full queued Release pipeline with Kiota 1.36.1 and compatible v1.0 input. The newly generated module imports with Authentication 2.38.1 and exports 632 cmdlets; compiled routes preserve 51 reviewed renames and 11 neighbors while excluding 39 reviewed suppressions. Generated projects are byte-identical; client, cmdlet and lock changes stay together. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep runtime profiles separate from shared authored configuration, refresh all aligned literal operation evidence, and independently prove complete original selector lineage and removals. Distinguish item reference entity types and configuration-taking validation without grouping incompatible contracts or dropping endpoints. Preserve existing derived precedence and all deferred directives. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run full queued Release generation with isolated Kiota 1.36.1 and original Authentication 2.38.1 after target integration and source/API corrections. Fresh full module imports 638 cmdlets and 561 routes; all 39 reviewed suppressions are absent, all 51 rename routes and 11 neighbors are retained. Keep new compatible resource-account-key methods, client, cmdlets and lock together; projects are byte-identical. Preserve unmodified generator output, including Kiota's existing trailing-space style. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run full queued beta Release pipeline on compatible input with Kiota 1.36.1 and original Authentication 2.38.1. Fresh module imports 1004 cmdlets/891 distinct routes, preserves 66 reviewed renames, 14 neighbors and all ten collision routes, and omits all 50 shared suppressed operations. This is compiled route/export evidence, not required-query or body-runtime proof. Client, cmdlets, generated projects and lock stay together; no bin/obj or logs included. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep four unsuppressed beta rights operations explicitly client-only under the existing value-property collection classifier. Separate compiled export proof from native required-query and typed-body runtime gates; no generator or dependency workaround is applied. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add source-backed tests covering every surviving effective required query in both profiles with derived data on and off, preserving v1 suppression boundaries. Document mandatory QueryId/no old Id alias and adapted Authentication 2.41.2 session-factory validation without changing authored directive selection or global code. 110 targeted tests and strict inventory pass on normally merged 4eb3ca3. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued Release on normal4eb3ca3 with isolated Kiota1.36.1 and hash-verified packaged adapted Authentication2.41.2 succeeds59.9seconds and638exports. Keep client/cmdlet/project/lock output combined; identical outputs remain honest. Preserve native query suppression and ordinary naming boundaries; no dependency preload or global workaround. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued beta Release on normal4eb3ca3 succeeds134.6seconds and1004exports. Four surviving reference DELETE commands bind mandatory QueryId to native @id with no Id alias; preserve two shared-directive suppressions and all item-reference endpoints. Keep client/cmdlet/project/lock output combined; identical client/lock output remains honest. Runtime fullmodule query/body/safety PASS is distinct from remaining3886PATCH204GETgenericHeaders failure; no global workaround. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Validate the actual provider operation on both profiles with derived data on and off: keep mandatory IDs, typed body, headers, one ShouldProcess and output metadata, while prohibiting implicit GET/readback flags. Document PATCH204 no object and PATCH200 actual typed result with caller-explicit GET. Shared directive selection and frozen client-only limits remain unchanged. Combined module/naming/configurator/required-query/PATCH tests execute184passingcases on normal6475target. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full unchanged-queue Release on normal6475 target succeeds580.5seconds and638exports. Generated Update commands issue only PATCH and return only their response, preserving path/body/header/ShouldProcess metadata. Keep combined client/cmdlet/project/lock boundary; identical client/project/lock output is not manufactured. Authored selection and all prior generation history remain intact. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full unchanged-queue beta Release on normal6475target succeeds188.9seconds and1004exports. Preserve all QueryId bindings, shared suppressions, distinct item/action contracts and prior profile commit boundaries. Generated PATCH commands no longer issue implicit GET; client/project/lock outputs are byte-identical and not manufactured. No global, Auth, template, optional-query or deferred PostPath changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Ramses Sanchez-Hernandez (ramsessanchez)
requested a review
from a team
as a code owner
November 6, 2026 02:12
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
src/readme.graph.mdare explicitly excluded. The response-content removal remains DeferredSchema; parameter aliases/transforms remain deferred and unchanged.QueryIdmandatory only on the four surviving beta reference DELETEs, with no oldIdalias; preserve two additional shared-selected suppressions and all four v1.0 required-query suppressions. PATCH204 succeeds with one PATCH, no returned object and no automatic GET; PATCH200 returns its own typed model, with caller-explicit GET remaining independent.powershell-v3at6475f3f5beb4908d39ea356db32bf1e0fd3273cb(merge9fc852618769611a4d4a5e14021c8e124f38080e), preserve the original migration/generation history, and regenerate both supported profiles. The latest combined client/cmdlet generation boundaries are v1.085304b398d37c08e19d9bcdae857c2d496ae8164and beta2f16fec8161057f62afeeadadabe51f82664927b. Client/project/lock outputs are byte-identical on these final runs; the generated PATCH command changes are real. This PR intentionally includes generated v3 wrapper sources underwrapperas required by the migration work, not edits to legacy AutoRest-generated files.Validation (actual normal target, not an isolated candidate):
Exact executed fresh-process runtime matrix (corrected post-import in-memory datastore isolation):
pwsh -NoProfile -NonInteractive -File C:\Users\ramsess\.copilot\session-state\48755c4f-a9af-445b-b17f-7fadee401750\files\post3886-6475-memory-final\Invoke-RuntimeCase.ps1 -RepoRoot C:\Users\ramsess\Repos\copilot-worktrees\msgraph-sdk-powershell\ramsessanchez-glowing-spoon -Profile v1.0 -Environment Global— exit 0/PASS.pwsh -NoProfile -NonInteractive -File C:\Users\ramsess\.copilot\session-state\48755c4f-a9af-445b-b17f-7fadee401750\files\post3886-6475-memory-final\Invoke-RuntimeCase.ps1 -RepoRoot C:\Users\ramsess\Repos\copilot-worktrees\msgraph-sdk-powershell\ramsessanchez-glowing-spoon -Profile v1.0 -Environment USGov— exit 0/PASS.pwsh -NoProfile -NonInteractive -File C:\Users\ramsess\.copilot\session-state\48755c4f-a9af-445b-b17f-7fadee401750\files\post3886-6475-memory-final\Invoke-RuntimeCase.ps1 -RepoRoot C:\Users\ramsess\Repos\copilot-worktrees\msgraph-sdk-powershell\ramsessanchez-glowing-spoon -Profile beta -Environment Global— exit 0/PASS.pwsh -NoProfile -NonInteractive -File C:\Users\ramsess\.copilot\session-state\48755c4f-a9af-445b-b17f-7fadee401750\files\post3886-6475-memory-final\Invoke-RuntimeCase.ps1 -RepoRoot C:\Users\ramsess\Repos\copilot-worktrees\msgraph-sdk-powershell\ramsessanchez-glowing-spoon -Profile beta -Environment USGov— exit 0/PASS.dotnet build .\tools\WrapperGenerator.Tests\WrapperGenerator.Tests.csproj --no-restore --no-incremental --verbosity minimal— passed; original unchanged source-build evidence reused, not rerun for the probe-only correction.dotnet test .\tools\WrapperGenerator.Tests\WrapperGenerator.Tests.csproj --no-restore --no-build --filter 'FullyQualifiedName~IdentitySignInsDirectiveMigrationTests|FullyQualifiedName~CmdletConfiguratorTests|FullyQualifiedName~NamingTests|FullyQualifiedName~RequiredQueryTests|FullyQualifiedName~PatchOperationTests' --logger 'trx;LogFileName=targeted.trx' --results-directory C:\Users\ramsess\.copilot\session-state\48755c4f-a9af-445b-b17f-7fadee401750\files\post3886-6475-final --verbosity minimal— 184 executed, 184 passed, zero failed/not executed; original unchanged TRX reused.& .\tools\Get-WrapperDirectiveMigrationInventory.ps1 -Module Identity.SignIns -FailOnUnresolved -OutputPath C:\Users\ramsess\.copilot\session-state\48755c4f-a9af-445b-b17f-7fadee401750\files\post3886-6475-final\strict-inventory.json— passed: nine Mapped, one DeferredSchema, zero unresolved/invalid; unchanged original evidence reused.pwsh -NoProfile -NonInteractive -File C:\Users\ramsess\.copilot\session-state\871a5292-dc5b-423e-8083-5165b0006603\files\Invoke-QueuedModuleBuild.ps1 -RepoRoot C:\Users\ramsess\Repos\copilot-worktrees\msgraph-sdk-powershell\ramsessanchez-glowing-spoon -Module Identity.SignIns -ApiVersion v1.0 -Configuration Release— full unchanged-queue generation/build passed, exit 0/OK, 638 exports in 580.5s; original full-build output reused without regeneration.pwsh -NoProfile -NonInteractive -File C:\Users\ramsess\.copilot\session-state\871a5292-dc5b-423e-8083-5165b0006603\files\Invoke-QueuedModuleBuild.ps1 -RepoRoot C:\Users\ramsess\Repos\copilot-worktrees\msgraph-sdk-powershell\ramsessanchez-glowing-spoon -Module Identity.SignIns -ApiVersion beta -Configuration Release— full unchanged-queue generation/build passed, exit 0/OK, 1004 exports in 188.9s; original full-build output reused without regeneration.pwsh -NoProfile -NonInteractive -File C:\Users\ramsess\.copilot\session-state\48755c4f-a9af-445b-b17f-7fadee401750\files\post3886-6475-final\Test-SignInsCompiledFinal.ps1 -RepoRoot C:\Users\ramsess\Repos\copilot-worktrees\msgraph-sdk-powershell\ramsessanchez-glowing-spoon -Profile v1.0and the same command with-Profile beta— passed on the original final normal manifests: exact exports/routes, reviewed suppression/rename outcomes, neighboring routes, mandatory stringQueryId/binder metadata, noIdalias, three owned DLLs and no dependency preloads. The same normal manifests/binaries were freshly imported by the corrected runtime cases; all original binary/manifest hashes remain unchanged.The four exact
Invoke-RuntimeCase.ps1commands above passed using realConnect-MgGraphplus the guarded in-memory store and the real HTTP factory with offline terminal capture. Covers exact action JSON/results versus bodyless item action, four required-query DELETE wires/escaping/IfMatch/custom headers, missing/empty/null binder rejection before HTTP, unchanged item references, WhatIf, genuine Yes/No single-prompt behavior, ordinary List/item-ID defaults, PATCH204 one request/no output/no GET with GET configured to return 403, PATCH200 one request/typed model, independent explicit GET/error, session invalidation/reconnect/disconnect and packaged assembly identities. No live Graph/OAuth requests.Kiota is the existing isolated 1.36.1+fd3bf87790149b87f40f7eae1a5feb9016625943, with process-local parallelism 1. Authentication is the normally packaged adapted 2.41.2, not stock Gallery 2.41.2 or old 2.38.1; all 64 file hashes and physical package SHA256
2FC09BFE6B70D313BC56DF8ADCCFB1976FB4E90A1898BF8A916B4B8B792898EBremain unchanged. No global installation, DLL injection, generator/template patch, skipped Kiota or fallback specification is used.Compatible specification Git blobs: v1.0
bf12b2d70abe2babe5a1336999a936503855f7b0; beta842138aad4ca3371d315b1a5c6610d0ff7cdbf17. Both profiles are supported; none is excluded.Probe-only runtime isolation correction (same PR/head; no source or build rerun): Normal Authentication imported into the extra confirmation runspace reset the shared datastore to
Microsoft.Graph.PowerShell.Authentication.Common.DiskDataStore. That observed type alone does not establish credential I/O. The earlier raw transport proofs and handoff remain unchanged as historical evidence, not post-import memory-guarded proof.The four runtime commands above were rerun only against the same normal generated bins. The corrected probe reapplies the existing
Set-MgTestDataStorehelper after the last additional-runspace module import and before the first Connect. It asserts and records the actual reflected realGraphSession.DataStore.GetType().FullNameasMicrosoft.Graph.Authentication.Test.Mocks.MockDataStorebefore Connect/HTTP/reconnect/disconnect/logout, with the terminal handler independently checking that type on every captured request. All four corrected cases pass: 47 actual datastore guard checks per v1.0/cloud case and 150 per beta/cloud case (394 in total), with every transport observing MockDataStore. Positive single-request PATCH, QueryId, binder, body, default and safety acceptance is unchanged.Corrected guarded evidence:
C:\Users\ramsess\.copilot\session-state\48755c4f-a9af-445b-b17f-7fadee401750\files\post3886-6475-memory-final\handoff.jsonandruntime-<profile>-<cloud>.json; reproducerTest-SignInsRuntimeMemoryFinal.ps1via the four exactInvoke-RuntimeCase.ps1commands above. Original full-build/TRX evidence is reused unchanged fromC:\Users\ramsess\.copilot\session-state\48755c4f-a9af-445b-b17f-7fadee401750\files\post3886-6475-final. No Authentication/package/production edits, full generation, tests, new commits, dependency injection or new PR were needed. All 64 adapted Authentication hashes and the physical package remain unchanged.Honest limits: Four beta rights GETs returning
usageRightsIncludedwith scalar-enumvalueremain unsuppressed but client-only under the existing GET classifier; they are not counted as exported neighbors. RawCompare-WrapperCmdletNames.ps1parity remains imperfect and is reported without Beta-prefix normalization; see the recorded raw ledgers below. Offline acceptance is not certification of every live Graph endpoint. Desktop PowerShell 5.1 is unsupported. The existing Microsoft.OpenApi.YamlReader NU1903 dependency warning remains outside this module-only scope.Unchanged full-build/TRX evidence root:
C:\Users\ramsess\.copilot\session-state\48755c4f-a9af-445b-b17f-7fadee401750\files\post3886-6475-final. Corrected runtime evidence and canonical handoff:C:\Users\ramsess\.copilot\session-state\48755c4f-a9af-445b-b17f-7fadee401750\files\post3886-6475-memory-final\handoff.json. Old raw proofs/handoff remain unchanged; their earlier datastore setup claim is not relabeled as a guarded run.pwsh -NoProfile -NonInteractive -File .\tools\Compare-WrapperCmdletNames.ps1 -GeneratedPath .\src\Identity.SignIns\wrapper\v1.0\Cmdlets -OutLedger C:\Users\ramsess\.copilot\session-state\48755c4f-a9af-445b-b17f-7fadee401750\files\post3886-6475-final\raw-parity-v1.0.csv— raw parity exit 1: 613 matched, 19 mismatch, 6 no-oracle (not claimed as a passing gate).pwsh -NoProfile -NonInteractive -File .\tools\Compare-WrapperCmdletNames.ps1 -GeneratedPath .\src\Identity.SignIns\wrapper\beta\Cmdlets -OutLedger C:\Users\ramsess\.copilot\session-state\48755c4f-a9af-445b-b17f-7fadee401750\files\post3886-6475-final\raw-parity-beta.csv— raw parity exit 1: 993 mismatch, 11 no-oracle (not claimed as a passing gate).Other links