Skip to content

Refresh Bookings generated output for current v3 query and PATCH contracts - #3906

Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 19 commits into
powershell-v3from
ramsessanchez-bookings-v3-migration
Open

Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 19 commits into
powershell-v3from
ramsessanchez-bookings-v3-migration

Conversation

@ramsessanchez

Copy link
Copy Markdown
Contributor

N/A

Changes proposed in this pull request

Refresh Bookings' committed generated output after the merged v3 Authentication, required-query and PATCH-result changes. The original directive migration is already merged in #3839; this is a generated-output follow-up, not a reopening or a second directive migration.

  • Regenerate complete Kiota clients, cmdlets, projects and locks for both v1.0 and beta. Generated workers use their actual profile with the adapted Authentication 2.41.2 package; normal wrapper manifests have no dependency preloads and each bin contains only its three owned DLLs.
  • Bind calendarView's required native start/end inputs through mandatory string QueryStart/QueryEnd parameters, including both paired List/Get sets. Preserve the independently declared v1.0 Count range; beta Count does not acquire nonexistent range inputs. Optional OData aliases and exact nextLink isolation remain unchanged.
  • Apply the merged one-operation PATCH contract: 204 succeeds with no output and no implicit GET; 200 returns the actual typed response after one PATCH. Callers explicitly invoke GET with its own headers and required queries if they want retrieval. No PassThru, ReadBack or Refetch option is added.

All 44 authored configurations, Bookings' three original shared directives, reviewed evidence and compatible specs remain unchanged from target 6475f3f5beb4908d39ea356db32bf1e0fd3273cb. The current retirement policy suppresses root-level Bookings cmdlets while retaining all 29 beta client/source paths and 53 operations. Supported /solutions/... cmdlets and neighbors remain active. Historical source proof and prior migration/generation commits are preserved.

Validation

Both profiles ran sequentially through the unchanged four-mutex full-build queue using isolated Kiota 1.36.1 (parallelism 1) and the normally packaged adapted Authentication 2.41.2. No skipped generators, raw collision mode, fallback spec, dependency injection or generated-source edits were used.

Full build Result
pwsh -NoProfile -NonInteractive -File $Queue -RepoRoot $PWD -Module Bookings -ApiVersion v1.0 -Configuration Release Passed; 217 compiled exports; 70.8 seconds in the builder.
pwsh -NoProfile -NonInteractive -File $Queue -RepoRoot $PWD -Module Bookings -ApiVersion beta -Configuration Release Passed; 253 compiled exports; 126.8 seconds in the builder.

$Queue is the existing four-slot queue wrapper; it invokes the repository's unchanged Build-WrapperModule.ps1 with -SpecRoot .\openApiDocs_KiotaCompat and no skip flags.

  • dotnet test .\tools\WrapperGenerator.Tests\WrapperGenerator.Tests.csproj --filter 'FullyQualifiedName~BookingsDirectiveMigrationTests|FullyQualifiedName~NamingTests|FullyQualifiedName~CmdletConfiguratorTests|FullyQualifiedName~DerivedCollisionResolutionsTests|FullyQualifiedName~RequiredQueryTests|FullyQualifiedName~PatchOperationTests|FullyQualifiedName~MutationRouteTests|FullyQualifiedName~EmitterTests' --logger 'trx;LogFileName=targeted.trx' --results-directory $EvidenceRoot --verbosity normal - 398 executed, 398 passed, 0 failed, 0 skipped.
  • .\tools\Get-WrapperDirectiveMigrationInventory.ps1 -Module Bookings -AsJson -FailOnUnresolved - all three directives Mapped.
  • dotnet build .\tools\WrapperGenerator\WrapperGenerator.csproj -c Release --no-restore --no-incremental --verbosity quiet and dotnet build .\src\GraphWrapperRuntime\Runtime\Microsoft.Graph.Wrapper.Runtime.csproj -c Release --no-incremental --verbosity quiet - passed before the full generation runs.
  • Fresh normal-manifest imports and actual authenticated GraphHttpClientFactory offline acceptance in v1.0/beta x Global/USGov - all four profile/cloud cases passed, 33 checks each. After all module imports, the probe reapplies the existing in-memory store and verifies its actual reflected MockDataStore type before/after transport/lifecycle and before logout (260 guarded observations total). No production source, package or full build was changed for this probe-isolation correction.

The actual HTTP checks require one PATCH and zero objects on 204 with GET deliberately returning 403, one PATCH and the actual typed model on 200, independent explicit GET headers/ranges/results/error, typed POST/action/DELETE bodies/results, genuine declined Confirm and WhatIf with zero HTTP, required-range binder failures before HTTP, native query encoding, paging isolation, List defaults, session lifecycle and one Authentication-owned dependency/load-context closure. No live Graph, OAuth or credential-store calls were made.

Scope and limits: This PR changes generated Bookings output only; global/profile-local directives, deferred aliases/transforms/schema rules and authored naming are untouched. Existing raw Mg versus MgBeta, function/action names and missing frozen oracle entries are not repaired or normalized into a passing parity claim. Offline 204 behavior is framework evidence, not a claim that every Graph API returns 204. Earlier implicit-readback failure reports remain historical; the user-directed no-readback contract supersedes them.

Commit boundaries: All earlier local migration/integration and separate profile generation history is retained. Final normal merge: c681013c5634b6d05ead6ea00173db15cf8f1e43; current v1.0 generation: 3601c023b3385b95e788220fb3b472a9e1155d4d; current beta generation: 3b836808769348b888614d2ce87f6a5fe4ef493d. Each profile commit contains its combined generated client/cmdlet/project/lock delta; unchanged client/lock bytes are not fabricated.

Other links

Record exact compatible-profile operation evidence, retain existing curated behavior, and pin shared directive and neighboring naming coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run full Kiota 1.36.1 and cmdlet generation with a successful Release build and 217 compiled exports. Generated client/cmdlet sources and projects are unchanged; only the Kiota version lock advances from 1.34.1.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Prepare the separately authorized additive multi-route opt-in: preserve all 53 exact pairs, retain published legacy defaults for 50 pairs and solutions defaults for three actions. Pin compatible-spec identities and published metadata in module-specific tests. Shared runtime implementation remains a separate prerequisite; no route tree is suppressed.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Resolve the original selector against both legacy sources and explicitly map the exact GET/PATCH solutions roots to compatible operation IDs. Pin both complete source match sets and compatible targets without conflating renamed operation IDs with API absence. Strict inventory revalidation awaits prerequisite #3847.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Enforce Microsoft's 2024-04-30 retirement at both compatible refresh entrypoints even without upstream deprecation metadata. Byte-preserve unrelated paths and schemas while removing 29 retired paths and 53 operations; keep all solutions successors and historical sources. Withdraw the prepared legacy-default policy and update exact shared-directive evidence for current operation IDs.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Remove reserved legacy-translation fields from literal profiles now that compatible IDs equal the original IDs. Preserve the complete actual historical GET/PATCH root match set in notes and source-reading regression assertions.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued Kiota 1.36.1 and cmdlet generation with a real Release build: 217 compiled exports, zero retired roots/builders, 18 live-operation checks and two runtime list/item probes. Generated sources and projects are byte-identical; only the compatible description hash in the client lock changes.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run full queued Kiota 1.36.1 and cmdlet generation with a real Release build and official Authentication 2.38.1: 253 compiled exports and no collisions. Verify zero retired root routes or request builders, 18 live-operation checks and two runtime list/item probes. Include complete beta client, cmdlets, generated projects and locks; no skipped generators or collision bypass.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep removed-operation arrays empty when a retired path contains only path-level metadata; pin exact report counts and clarify the documented retirement exception.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Normally integrate 844672d. Resolve historical Bookings retirement conflicts to the authoritative merged policy: suppress retired cmdlets while retaining current beta source/client routes. Preserve previous migration and generation history; no publication.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued Kiota1.36.1 and cmdlet generation against normally merged 844672d with adapted Authentication2.41.2: real Release build and 217 compiled exports. Preserve current source/client routes and cmdlet suppression; regenerate profile-explicit transport calls and module project pruning. Publication remains pending coordinator decision.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued Kiota1.36.1 and cmdlet generation against normally merged 844672d with adapted Authentication2.41.2: real Release build and 253 compiled exports. Generate explicit beta transport context and normal dependency pruning, while keeping retired source/client routes and cmdlet-only suppression. Publication remains pending coordinator decision.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued Kiota1.36.1 and cmdlet generation against normally merged 4eb3ca3 with adapted Authentication2.41.2: real Release build and 217 compiled exports. Generate mandatory QueryStart/QueryEnd on surviving calendarView contracts, preserving optional OData, ordinary defaults and current cmdlet-only retirement policy. Local publication decision remains parent-owned.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued Kiota1.36.1 and cmdlet generation against normally merged 4eb3ca3 with adapted Authentication2.41.2: real Release build and 253 compiled exports. Generate mandatory QueryStart/QueryEnd on surviving calendarView List/Get contracts without adding ranges to the beta count neighbor; retain retired client/source routes and shared cmdlet suppression. Local publication decision remains parent-owned.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued Kiota1.36.1 and cmdlet generation against normally merged 6475f3f using adapted Authentication2.41.2: real Release build and 217 compiled exports. PATCH204 emits no object and no implicit GET; PATCH200 returns the actual response. Preserve mandatory native queries, current retired-cmdlet-only policy and complete client/project generation boundary.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued Kiota1.36.1 and cmdlet generation against normally merged 6475f3f using adapted Authentication2.41.2: real Release build and 253 compiled exports. PATCH204 succeeds without output or implicit GET; PATCH200 returns the actual response. Keep required query contracts, current beta client/source retention and retired-cmdlet-only suppression, preserving the combined full generation boundary.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant