Skip to content

Complete Search v3 shared-directive audit and generation - #3884

Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 18 commits into
powershell-v3from
ramsessanchez-search-v3-migration
Open

Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 18 commits into
powershell-v3from
ramsessanchez-search-v3-migration

Conversation

@ramsessanchez

@ramsessanchez Ramses Sanchez-Hernandez (ramsessanchez) commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

N/A (module migration; no separate issue).

Changes proposed in this pull request

  • Preserve the shared src\Search\Search.md no-directive audit and empty migration ledger. There are no cmdlet, parameter or schema selectors to invent or bridge. Every profile-local directive and src\readme.graph.md is ignored and unchanged. Both supported compatible profiles, v1.0 and beta, are generated and built; neither is excluded.
  • Preserve all 63/145 operations, the two exact shared description-backed IndustryData GET noun repairs, List/Get defaults, mandatory IDs and frozen raw parity limits. The item statistics function retains the published Statistics noun, the collection function retains its structural GetStatistics name, and the distinct nested activity navigation retains ActivityFlow from its source description. No selector, profile-scoped rule, new group/option/schema, or naming expansion is introduced.
  • Normally merge final target 6475f3f5beb4908d39ea356db32bf1e0fd3273cb and update only coupled Search expectations. Successful PATCH204 now performs one PATCH, no GET, no returned object; PATCH200 returns its typed response from one PATCH. Callers explicitly GET if desired. Fresh complete-module real authenticated offline tests exercise both positive contracts with a GET403 guard, then independent GET query/header/result/error behavior. Historical Remove automatic GET after successful PATCH #3886 header-loss reports are preserved but are user-superseded, not a remaining blocker.

Current integration and commit boundaries

Purpose Commit
Original shared audit f233d7bd2777958a6024c23dff1efe100d8804e1
Earlier normal #3849 integration and API/naming correction e9eaa59dea018c58031d442a51fbc7f15f9e7fa8 / 19e91c1f77
Earlier complete profile generation, retained 111c4c8aa1 (v1.0), a03064c701 (beta)
Earlier normal #3891 Authentication integration e9eb237cdb35a5eaa8d8268222aee3f420f44b6f
Earlier Auth acceptance and profile generations, retained 2a26499173, d54b43cc4f, 4fae00389f (v1.0), 755fa37817 (beta)
Final normal #3886 integration beb2c83dccf8bf1e692a0b60074bb5f2e241c142
Final owned test/probe/doc correction b48218d4ab
Final combined v1.0 client/cmdlet/project/lock generation c78d95771e137b319c4a1708fd0e7561cfc091e1
Final combined beta client/cmdlet/project/lock generation ee159b5cc9e9f83c4322b639f8bf80cd5c70f8fe
Current canonical head 5e4487476491a2ef2daeb54f99e1ba475e1aa731

All previous history is preserved. Each new profile boundary comes from the complete unchanged four-mutex build queue, not manual .g.cs edits or skipping Kiota. Client/lock bytes that remain identical are reported honestly. No bin/obj, DLL/nupkg/log, dependency injection, global Auth changes, other-owner edits or unmerged #3881/#3897 fix is included.

Current compatible blobs are unchanged: v1.0 10bfa3ec66104d39da29c39eeeeb01154a2ff4ca (63 operations), beta 7bf19d7a55f303509ef23bd89b0bc75ea60cb604 (145). Actual legacy lineage-only blobs are 874ec28befe8da54ca689ce4df6cd32204fe83e8 / abdbd822db5d44f2e0713f7f3b517c3d51b7b8b9; generation never falls back to them. Strict inventory is zero rows/empty mappings because the original shared file is genuinely empty.

Final normal-target validation

Evidence root:
$B = 'C:\Users\ramsess\.copilot\session-state\ca78475c-0123-4fc4-ab37-67304ec13f5a\files\post3886-6475-final'
retains unchanged full-build/TRX/source/generation proof. Corrected runtime-only evidence and the new canonical handoff are in
$E = 'C:\Users\ramsess\.copilot\session-state\ca78475c-0123-4fc4-ab37-67304ec13f5a\files\post3886-6475-memory-final'.

Probe isolation correction, same PR head: an additional-runspace Authentication import resets the actual shared DataStore to DiskDataStore. The original runtime probe called Set-MgTestDataStore before that later import, so the old reports do not certify post-import memory isolation. They and the original handoff remain untouched. Only the four offline runtime cells were rerun, against the same compiled bins/head, using the artifact probe "$E\Test-SearchDirectiveMigration.Memory.ps1". It finishes all extra-runspace imports before first Connect/HTTP, reapplies the existing Set-MgTestDataStore helper after the last import, then guards/records the actual reflected GraphSession.DataStore.GetType().FullName before Connect, transport, reconnect, context changes and disconnect/logout; every captured HTTP request also records and verifies it.

The actual post-import type before reapplication is Microsoft.Graph.PowerShell.Authentication.Common.DiskDataStore; every subsequent guard and HTTP capture has Microsoft.Graph.Authentication.Test.Mocks.MockDataStore. This observed reset is not evidence that credential I/O occurred. No normal package/OnImport/production/module source, full build, TRX or generation commit was changed or rerun for this setup-only fix.

Every full-build invocation sets process-local isolated Kiota 1.36.1+fd3bf87790149b87f40f7eae1a5feb9016625943 and KIOTA_Generation__MaxDegreeOfParallelism=1. PSModulePath starts with the exact adapted normal Authentication root
C:\Users\ramsess\.copilot\session-state\4aa86cf9-d43c-4d2b-a4a3-aeaed01b8f29\files\authentication-v2-sync\final-source\modules,
then the existing user and Program Files PowerShell module paths. Fresh import verifies 2.41.2 from that root, all 64 physical file SHA256s match, and the physical Authentication nupkg SHA is
2FC09BFE6B70D313BC56DF8ADCCFB1976FB4E90A1898BF8A916B4B8B792898EB.
No Gallery/old2.38 substitute, preload or load-context shim is used. Auth/runtime/templates/builder are unchanged by the final PATCH merge. Normal wrapper manifests require Auth2.41.2 with no RequiredAssemblies; bins contain only their three owned DLLs. No new wrapper nupkg is claimed.

Exact command Actual final result
dotnet test .\tools\WrapperGenerator.Tests\WrapperGenerator.Tests.csproj --no-restore --filter 'FullyQualifiedName~SearchDirectiveMigrationTests|FullyQualifiedName~CmdletConfiguratorTests|FullyQualifiedName~NamingTests|FullyQualifiedName~RequiredQueryTests|FullyQualifiedName~PatchOperationTests' --logger 'trx;LogFileName=targeted.trx' --results-directory $B Unchanged valid source proof: exit 0; actual TRX 164 total, 164 executed, 164 passed, 0 failed, 0 not executed. Not rerun for probe setup.
tools\Get-WrapperDirectiveMigrationInventory.ps1 -Module Search -FailOnUnresolved Exit 0; Rows/Mapped/Deferred/Unresolved all zero; empty ledger.
pwsh -NoProfile -NonInteractive -File C:\Users\ramsess\.copilot\session-state\871a5292-dc5b-423e-8083-5165b0006603\files\Invoke-QueuedModuleBuild.ps1 -RepoRoot C:\Users\ramsess\Repos\copilot-worktrees\msgraph-sdk-powershell\ramsessanchez-special-happiness -Module Search -ApiVersion v1.0 -Configuration Release Exit 0, Search OK, 324.60 seconds, 72 exports; all63 exact compiled routes.
Same full queue command with -ApiVersion beta, after v1.0 completes Exit 0, Search OK, 121.00 seconds, 166 exports; all145 exact compiled routes.
pwsh -NoProfile -NonInteractive -File "$E\Test-SearchDirectiveMigration.Memory.ps1" -RepoRoot C:\Users\ramsess\Repos\copilot-worktrees\msgraph-sdk-powershell\ramsessanchez-special-happiness -ApiVersion v1.0 -Environment Global -OutputPath "$E\compiled-v1.0-Global.json" Exit 0, PASS;170 assertions,23 actual Mock guards,19 offline authenticated HTTP requests,5 genuine declined prompts.
Same corrected artifact command with -ApiVersion v1.0 -Environment USGov -OutputPath "$E\compiled-v1.0-USGov.json" Exit 0, PASS;170 assertions,23 actual Mock guards,19 requests,5 genuine declined prompts.
Same corrected artifact command with -ApiVersion beta -Environment Global -OutputPath "$E\compiled-beta-Global.json" Exit 0, PASS;233 assertions,27 actual Mock guards,25 offline authenticated HTTP requests,6 genuine declined prompts.
Same corrected artifact command with -ApiVersion beta -Environment USGov -OutputPath "$E\compiled-beta-USGov.json" Exit 0, PASS;233 assertions,27 actual Mock guards,25 requests,6 genuine declined prompts.
pwsh -NoProfile -NonInteractive -File .\tools\Compare-WrapperCmdletNames.ps1 -GeneratedPath .\src\Search\wrapper\v1.0\Cmdlets -OutLedger "$B\parity-v1.0.csv" Unchanged exit 1;raw71matched/1existingmismatch.
Same raw parity command with beta path and "$B\parity-beta.csv" Unchanged exit 1;raw164mismatches/2no-oracle,0/166matched;notnormalized.

Fresh complete normal-manifest modules verify all 63/145 exact operations and the unchanged repairs/defaults/neighbors/binder gates. Real Connect-MgGraph with an offline token, existing in-memory MockDataStore and GraphHttpClientFactory feeds a terminal capture handler after Authentication. No live Graph/OAuth/credentials-store calls occur. The real factory keeps global /v1.0/ BaseAddress while generated beta uses /beta, USGov uses graph.microsoft.us, and alternating profile/cache, timeout invalidation, reconnect/disconnect and single packaged Authentication/Kiota/RMS/URI identities are checked.

Typed connection POST/PATCH JSON, typed 200 results, typed external-item PUT content/result, search-action nested JSON, bodyless DELETE and beta start action are checked. Every representative mutation's WhatIf and genuine No send zero HTTP with one declined prompt; invalid binding fails before HTTP. PATCH204 is a successful single mutation with no output; PATCH200 is a single mutation with its actual model. GET is configured to reject during each PATCH, proving no hidden readback. An independent explicit GET then uses its own bound header and native $select query, returns its model, and separately surfaces a 403 error without replaying PATCH.

Search's real specs have no mandatory-query operations or reference DELETE surface; the merged required-query tests cover framework contracts without authoring module queries. No artificial group/alias/refetch switch is introduced. Tests are offline behavior proof, not tenant/service certification or coverage of every Graph function.

The old implicit-readback header failure is superseded by the new contract; its old search-844672-revalidation reports are untouched. Frozen raw oracle parity is not claimed green or normalized: the v1 qualified addActivities naming mismatch remains; beta prefix/structural mismatches and the collection statistics/nested flow no-oracle rows remain. No endpoint is pruned for missing metadata. Existing NU1903 remains unchanged. The new $E\handoff.json references the unchanged full-build/TRX/source/profile/assembly/Auth hashes at $B and contains the new guarded runtime proofs, actual datastore stages/types and artifact probe hash. The original $B\handoff.json and all its raw evidence remain unchanged; only runtime isolation proof is superseded. No repeat build, test, source or generation run was needed.

Other links

Record the empty shared directive inventory and compatible-spec evidence without adding overrides. Cover unchanged real-spec operations in both profiles and document the existing beta IndustryData generation collisions.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the full compatible-spec Release pipeline through the shared queue with official Authentication 2.38.1. The compiled module exports 72 cmdlets. Generated client sources, cmdlets, projects, and the cmdlet lock are byte-identical after Git line-ending normalization; only the client lock records Kiota 1.36.1 instead of 1.34.1.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Document the successful 72-export v1.0 build, actual queued beta wrapper-generator failure, and published parameter-set/schema evidence needed for a reviewed shared capability. No routes are suppressed and no public noun is invented.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve the empty directive ledger. Use source-backed Statistics and ActivityFlow nouns for distinct IndustryData operations, retain all routes and normal list defaults, and remove superseded selectors/profile rules. Exercise both real specs with separate runtime profiles and derived data on/off, and add full compiled-module HTTP regression coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Assert all 63 v1.0 and 145 beta compatible operations survive in the actual full module. Exercise repaired requests, unchanged list defaults, Kiota result types, mandatory IDs, rejected selectors and neighbors over stub HTTP. Record successful queued builds and honest raw oracle-parity limitations.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued Kiota 1.36.1 and cmdlet Release generation succeeded on the final shared configuration: status OK, 17.40 seconds, 72 exports and all 63 exact operations in the compiled module. Client/cmdlet source and projects remain byte-identical; only the client lock description hash changes for the aligned compatible input.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Create the previously absent beta output in one combined profile boundary: complete Kiota 1.36.1 client, generated cmdlets, client/module projects and both lock files. Full queued Release build is OK in 30.50 seconds with 166 exports; all 145 exact operations survive. Fresh compiled tests pass 76 assertions and 10 stub-HTTP requests without a tenant connection. Preserve generator-owned whitespace without hand edits.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve all authored naming and directive evidence. Verify emitted explicit runtime profiles and use normal manifests, real authenticated factory sessions, offline typed transport and single dependency identities for the Authentication 3891 refresh. Record any unmerged generic-header refetch failure instead of hiding it.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use the actual wrapper DLL names and nullable manifest preload field in the compiled gate, persist captures before a failing result, and document the new844672 builds separately from historical evidence. Real factory tests verify typed transport, cloud/profile/cache and assembly identity; the unmerged3886 header-loss assertion remains a genuine failure.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued Kiota1.36.1 and cmdlet Release generation against normal844672 and exact adapted Auth2.41.2: exit0/OK/35.20s/72exports. Preserve source/locks where identical; changed cmdlets emit explicit v1.0 adapters and the generated module project prunes the Auth-owned closure. Actual expanded runtime gate retains generic-header refetch failure3886; not an all-runtime pass.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full sequential queued Kiota1.36.1 and cmdlet Release generation against normal844672 and exact adapted Auth2.41.2: exit0/OK/59.00s/166exports. Preserve client source/locks where identical; changed cmdlets emit explicit beta adapters and the generated project retains only owned DLLs. Real factory Global/USGov requests use beta roots without changing client BaseAddress; generic-header refetch failure3886 remains explicit.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Adapt owned acceptance to normal6475:204success is one PATCH/noobject with GET403guard;200returnsits typed single-response model. Verify caller-directed GET's independent query/header/result/error, typed PUT content, existing safety/cloud/cache/identity coverage and no new API choices. Preserve historicalfailure evidence and all names/routes/ledger.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the complete normal6475 four-mutex Kiota1.36.1/client/cmdlet Release pipeline with exact adapted Auth2.41.2:exit0/OK/324.60s/72exports/all63routes. Generated PATCH commands no longer issue implicit GET; native GET query metadata refreshes normally. Client/projects/locks genuinely byte-identical. Fresh Global+USGov realfactoryproof passes147assertions/19HTTP/5genuineNoprompts percloud, including204nooutput/onePATCH,200typedresponseandcallerGETindependence.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run full normal6475 sequential four-mutex Kiota1.36.1/client/cmdlet Release pipeline with exactadaptedAuth2.41.2:exit0/OK/121.00s/166exports/all145routes. Generated PATCH commands drop implicit readback; native GET query metadata refreshes; client/projects/locks genuinely identical. Global+USGov freshfullmodule realfactoryproof passes206assertions/25HTTP/6genuineNoprompts percloud, including204nooutput/onePATCH,200typedresponseandcallerGETindependence.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Separate final6475 bothprofile builds and Global/USGov positive runtime outcomes from preserved historicalrefetch-headerfailures. Report actual164TRX/ordinarystrict0, normal72/166exports and frozenrawparity without normalization.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant