Repository navigation
Audit Identity.Partner v3 shared directives and regenerate both profiles - #3852
Merged
Ramses Sanchez-Hernandez (ramsessanchez) merged 16 commits intoNov 13, 2026
Conversation
Record the absent shared directive source, pinned compatible profile evidence, and intentionally empty mappings. Cover every real v1.0 and beta operation with module-specific unchanged naming and suppression regressions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the full Kiota 1.36.1 and wrapper Release pipeline against the pinned compatible v1.0 spec. Client sources, cmdlets, and generated projects are byte-identical after Git line-ending normalization; only the Kiota version in the lock file changes. Compiled discovery exports all 42 baseline cmdlets over 36 distinct routes, with unchanged operation inventory. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the full Kiota 1.36.1 and wrapper Release pipeline against the pinned compatible beta spec, preserving the committed Beta output casing. Client sources, cmdlets, and generated projects are byte-identical after Git line-ending normalization. Only lock metadata changes: Kiota version and compatible spec path casing. Compiled discovery exports all 42 baseline cmdlets over 36 distinct routes, with unchanged operation inventory. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Ramses Sanchez-Hernandez (ramsessanchez)
requested a review
from a team
as a code owner
October 22, 2026 01:33
Retain the module template require of readme.graph.md now that the shared audit occupies the legacy configuration path. Global directives remain untouched and outside migration scope; add a regression assertion without changing any generated output. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Refresh real-spec operation IDs and blob evidence; pass each actual profile separately to derived naming and suppression APIs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Fresh full queued Kiota and wrapper generation plus Release build on 08e409a: OK, 42 exports. Sources and projects are byte-identical after Git normalization; the actual combined generation delta is the compatible-spec lock hash. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Fresh full queued Kiota and wrapper generation plus Release build on 08e409a: OK, 42 exports. Sources and projects remain identical after Git normalization, preserving Beta casing and baseline Mg-prefix behavior; the actual combined generation delta is the compatible-spec lock hash. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
… sync Validate real-spec emission with separate actual profile context and record current packaged Authentication ownership without changing shared directive intent. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Fresh queued full Kiota/client and cmdlet/project generation plus Release normal manifest on merged 844672 target; explicit v1.0 adapter context and complete Authentication-owned dependency isolation. Typed offline transport is retained with the unmerged generic-header refetch defect reported separately. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Fresh queued full Kiota/client and cmdlet/project generation plus Release normal manifest on merged 844672 target, preserving Beta casing. All 36 transport workers explicitly select beta and wrapper packages defer the complete dependency closure to Authentication. The generic-header refetch defect remains reported, not overlaid. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Audit native query inputs for every real-spec operation and assert all six PATCH workers emit one mutation, no GET, preserved headers, and typed response output only when present. Preserve old refetch evidence as historical and the shared empty migration scope. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Fresh full queued Kiota/client and cmdlet generation plus Release normal manifest on merged 6475 target. Preserve all routes and public names; native PATCH returns only its own response and makes no follow-up GET. Client and lock regeneration is byte-identical where no actual delta exists. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Fresh full queued Kiota/client and cmdlet generation plus Release normal manifest on merged 6475 target. Preserve Beta casing, original route/default/name surface, and beta transport context; return only native PATCH results with no automatic GET. Byte-identical client and locks remain unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Ramses Sanchez-Hernandez (ramsessanchez)
merged commit Nov 13, 2026
b2bb15c
into
powershell-v3
6 checks passed
Ramses Sanchez-Hernandez (ramsessanchez)
deleted the
ramsessanchez-identity-partner-v3-migration
branch
November 13, 2026 00:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N/A - revalidation of this existing module migration PR; no linked issue.
Changes proposed in this pull request
src\Identity.Partner\Identity.Partner.md, its legacy defaultrequireinclude, intentionally empty reviewed mapping ledger, and empty curated configuration. No shared directives, selectors, suppressions, nouns, aliases, or variant groups were invented.powershell-v3at6475f3f5beb4908d39ea356db32bf1e0fd3273cb(merged Remove automatic GET after successful PATCH #3886), preserving prior heada0eb1c7945and all earlier migration/generation history. Update only this module's coupled real-spec regressions and audit to the user-directed single-PATCH/no-readback behavior. Audit every actual module operation, not just migrated directives: both profiles contain six PATCH families, zero PATCH query inputs, and zero required query inputs across all operations, including inherited path declarations.Current result: both required full builds, 162 targeted tests, strict inventory, and all four guarded Global/USGov runtime gates pass. PATCH204 succeeds with one selected PATCH, no output, no implicit GET even when GET would return 403. PATCH200 returns the actual declared typed model from one PATCH. A caller-explicit GET owns its independent headers, queries, typed result, and error. The old pre-#3886 missing-header-on-implicit-refetch failures are user-superseded historical evidence, not current failures and not relabeled passing runs. No new PassThru/ReadBack/Refetch switch exists. The pre-existing raw beta name-prefix parity failure remains explicit below.
Scope and unchanged source intent. The shared markdown did not exist at baseline
51d441eeb5; there is no original shared selector/source-operation set to translate. Both profiles are present and required, neither excluded: 18 paths/36 operations each (18 GET, 6 POST, 6 PATCH, 6 DELETE). Six customer, service-management-detail, relationship, access-assignment, operation, and request collection/item/count families remain unsuppressed and structurally named. Shared authored groups/renames/suppressions are N/A because the reviewed ledger/configuration are empty. POST actions, PUT/media, and grouped/composite PATCH surfaces are N/A because they do not exist in these actual specs; no endpoints were invented for a fixture. Profile-local readmes andsrc\readme.graph.mddirectives remain ignored and unchanged. Parameter aliases/transforms and schema/response directives remain Deferred, with none in the absent shared source. No Legacy bridge fields, #3881 PostPath fix copying, optional-query #3897 implementation, unrelated naming work, or other-owner source changes.openApiDocs_KiotaCompat\v1.0\Identity.Partner.ymlf967cae62269bd5421dc94f296c72de301c1df24openApiDocs_KiotaCompat\beta\Identity.Partner.yml2079834335f9781a8043cbf068a3b83065fa39fdNew additive boundaries: normal target merge
65f23361cef835f70a53e622b9871e26690c1ea2; own source/test/doc correction29128c15d971a0383409f2d0beda47e2b76817f6; combined v1.0 generatione370e5c45a174e948d58667cbfa9cb02b48fd9ee; combined beta generation/current head2a53ef58cd54df90ba07eb9df39e5aacc8ec4b18. Every commit has the required Copilot App co-author. All prior commits are preserved. Ordinary non-force push only; no amend, rebase, duplicate PR, merge, approval, or bypass. Uncapped Git diff scope was checked: 92 files, entirely module-owned source/generated output plusIdentityPartnerDirectiveMigrationTests.cs; no binary/bin/obj/nupkg/log/session-artifact commits. Committedwrapper\v1.0andwrapper\Betacasing is preserved.NEW 6475 evidence, 2026-11-06 UTC. Older 08e409/844672 results remain untouched and are not current-target evidence.
This environment was set process-locally in each invoking process. Fresh imports use the exact first-root adapted normal Authentication 2.41.2, not Gallery/old 2.38/shims. All 64 files and SHA256s, the physical nupkg SHA256
2FC09BFE6B70D313BC56DF8ADCCFB1976FB4E90A1898BF8A916B4B8B792898EB, and the unchanged four-mutex queue SHA2564A4478BCAA682E9628F361BEF299DFCFF5D785629666CC41F135F1F431A543E8were reverified. Shipping Auth/runtime/templates remain source-equivalent to accepted normal packaging. PowerShell 7/Core only; isolated Kiota1.36.1+fd3bf87790149b87f40f7eae1a5feb9016625943, concurrency 1. No global installation/environment edits, dependency DLL injection/preloads, or load-context shims.Results: nonincremental test build PASS exit 0; final targeted TRX PASS exit 0: 162 total/executed/passed, 0 failed/not executed, including own real-spec emission/profile/native-query assertions plus required-query and ordinary/grouped/composite no-readback framework regressions. Strict PASS exit 0, Rows/Mapped/Deferred/Unresolved all 0, the reviewed absent-shared-source outcome, not manufactured nonzero mapping evidence. Existing NU1903 YamlReader warnings remain; dependencies are unchanged. Final authored/tested inputs were verified byte-identical at final head; no unrelated worktree-stability framework fix.
Both required full queue invocations ran after final authored changes, v1.0 THEN beta, and each profile's supplemental own-wrapper nonincremental build followed its full run. Unchanged full builder uses
openApiDocs_KiotaCompat; no SkipKiota/GenerateOnly/NoCollisionData/fallback or exit-0/NO-CMDLETS substitution. Long queue-process times include waiting for a shared slot and are not builder performance measurements.Normal manifests require Authentication 2.41.2, without
RequiredAssemblies; each bin contains only module/client/runtime DLLs. Authentication owns the single Kiota/RMS/UriTemplate/Multipart closure. Exact assembly and manifest hashes are in the compiled proofs. The required queue does not set-Pack, so no new wrapper nupkg/install certificate is claimed; the physical accepted Authentication nupkg hash is verified separately.Probe-only datastore isolation correction. Importing Authentication into the genuine-No host's additional runspace can reset the shared datastore. The final script imports all modules first, reapplies the existing
Set-MgTestDataStorehelper after the last import and before Connect, then reflects the actual sharedGraphSession.Instance.DataStorebefore transport and lifecycle/logout. Each final proof retains 92 actual-type checks, all exactlyMicrosoft.Graph.Authentication.Test.Mocks.MockDataStore, including before initial Connect/factory/each HTTP phase/reconnect/explicit logout/cleanup. It also checks the reflected session is the same shared instance. This is not a label-only claim. Older unguarded v1 probes are retained unchanged, are not memory-isolation certification, and do not alone imply credential I/O. Only affected offline probes were rerun in the NEW memory-final directory; no production/Auth/package/full-generation/TRX changes or reruns for this correction.All four PASS, exit 0, separate fresh normal-manifest imports with real Connect-MgGraph + in-memory MockDataStore + GraphHttpClientFactory token pipeline + offline terminal handler, not a bare marker client. Per profile/cloud: 42 exact exports/GraphRoute associations, all 36 current spec operations, six default List/Get/count neighboring families; 42 authenticated HTTP captures; 18 WhatIf and 18 genuine declined Confirm prompts with zero HTTP; 3 invalid body/parameter-set/GET-only-PATCH bindings before HTTP. Six PATCH204 cases return no output with only the selected PATCH while GET is configured 403; six PATCH200 cases return their actual declared models with one PATCH. Typed relationship POST/PATCH bodies preserve duration/enum/nested roles/customer JSON and headers. Bodyless DELETE, escaped IDs, bound top/filter/select, and explicit GET's independent successful result/header/select and 403 error are asserted. Actual query metadata has no required Query inputs and PATCH exposes no GET-only/readback inputs; required-query runtime cases are therefore N/A for this module, not silently waived.
Compiled beta/cloud URLs are explicitly
graph.microsoft.com/beta,graph.microsoft.us/beta, andgraph.microsoft.us/v1.0as appropriate even though the real factory BaseAddress stayshttps://graph.microsoft.com/v1.0/. Shared client/BaseAddress are not mutated. Repeated compiled GET reuses the adapter; four alternating profile cache requests retain correct roots; request-context/reconnect invalidate client/adapter correctly; disconnect returns NoGraphSession without HTTP. Loaded Auth/Kiota/RMS/UriTemplate identities are unique, from the accepted package and expected Default/private contexts. All old compiled names/routes are unchanged. Offline evidence proves local contracts, not remote tenant/service validity. No live Graph/OAuth/credential-store transport is used in the guarded final runs.Unnormalized raw parity: v1.0 PASS exit 0, 42/42; beta FAIL exit 1, 0/42, all exactly the unchanged
Mgversus oracleMgBetaprefix difference. This documented baseline naming limitation is not a new no-readback/runtime failure and has not been normalized into a pass.Retained evidence: canonical scalar
handoff.jsonis in$runtimeEvidence, referencing unchanged full/TRX/source/spec/Auth64/tool/queue records in$buildEvidence. It includes current target/head/prior head/merge/correction/per-profile generation commits, actual scalar test/strict/build counters, absolute proof paths and SHA256 artifact records. New guardedcompiled-<profile>-<cloud>.json,.log,-result.json,.json.requests.json, and.json.datastore.jsonhold actual HTTP/body/header/response counts, load contexts, hashes, and reflected datastore phases.runtime-matrix-summary.jsonandmemory-correction-lineage.jsonseparate new isolation proof from old claims. Build root retainsfull-v1.0.log,full-beta.log, per-command results/nonincremental/Kiota logs, finaltargeted.trx/targeted-tests.log, strict JSON, original/current source/spec identities, and raw parity. Initial local probe helper-scope failures and a local result-parser false match on the table headerFailedAtare preserved with correction records; the actual full v1 queue run was already exit0/OK and was not rerun or relabeled. Historical targets and all old raw evidence remain untouched.Other links