Repository navigation
Audit Mail shared directives for v3 wrappers - #3840
Merged
Ramses Sanchez-Hernandez (ramsessanchez) merged 13 commits intoNov 12, 2026
Merged
Ramses Sanchez-Hernandez (ramsessanchez) merged 13 commits into
Ramses Sanchez-Hernandez (ramsessanchez) merged 13 commits into
Conversation
Record exact compatible operation evidence, preserve existing derived coverage, and distinguish excluded beta input from absent API operations. Add focused Mail regression coverage without duplicate overrides. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the full Release build against openApiDocs_KiotaCompat v1.0 with Kiota 1.36.1. Client and cmdlet sources, generated projects, and dependency locks are unchanged; only Kiota version metadata in the client lock changes. The compiled module exports 146 commands and all 132 direct operations match published parity. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Ramses Sanchez-Hernandez (ramsessanchez)
marked this pull request as ready for review
October 22, 2026 00:36
Ramses Sanchez-Hernandez (ramsessanchez)
requested a review
from a team
as a code owner
October 22, 2026 00:36
Ramses Sanchez-Hernandez (ramsessanchez)
force-pushed
the
ramsessanchez-mail-v3-migration
branch
from
October 22, 2026 00:37
f7ed1ac to
8ece835
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Pass the derived run profile separately from GeneratorConfig, refresh current literal operation IDs and spec evidence, and assert complete original source selection equals current compatible survivors. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the shared queued full Kiota and wrapper Release pipeline on powershell-v3 08e409a with Kiota 1.36.1 and official Authentication 2.38.1. Generated cmdlets/projects remain identical; persist the two Kiota mail-folder delta documentation refreshes and updated spec lock hash. The fresh module exports 146 commands and raw parity matches 146/146 routes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Exercise the real Mail compatible document through the current generator and verify ordinary/migrated reply commands and item GET use the explicit v1.0 request adapter context while the exact content suppression remains intact. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the shared queued full Kiota/client/cmdlet/project/manifest Release pipeline against normal target 844672d with Kiota 1.36.1 and the verified adapted Authentication package. Persist explicit v1.0 adapter calls and the dependency-ownership project template; client/spec/dependency locks remain unchanged. Normal manifest requires Authentication 2.41.2 with only three owned wrapper DLLs and no dependency preloads. Fresh compiled Global and USGov offline factory-pipeline gates and raw parity pass. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Revalidate all twelve actual Mail PATCH routes through the real compatible document, retaining only each mutation result with no implicit GET. Assert the current Mail input has no required query parameters while preserving migrated replies, source selection and suppressed content behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run full shared queued Kiota/client/cmdlet/project/manifest Release generation on target 6475f3f. Remove implicit GET readback from all twelve PATCH cmdlets; retain actual PATCH200 results and no output for PATCH204. Other generated delta is required-query emitter whitespace on GET surfaces; client/spec/project/dependency locks are unchanged. Fresh Global and USGov offline factory-pipeline probes verify migrated replies, existing message PATCH204/200, explicit caller GET, safety, binders and normal Authentication ownership. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Make Mail_cmdletConfigurations.cs own the exact content GET suppression and six reply-all renames, including New verbs for reply drafts. Remove their derived entries and mark their reviewed ownership so parity derivation cannot recreate duplicates. Preserve the frozen input and unrelated parity drift; pin behavior with data disabled and unchanged neighboring routes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued Kiota client and wrapper Release regeneration completed successfully after e9bafa1, using the compatible Mail spec, Kiota 1.36.1 and verified adapted Authentication 2.41.2. All generated client/cmdlet/project/lock sources are byte-identical, so this intentionally empty commit preserves the required generation boundary without fabricated file changes. The fresh module exports 146 cmdlets; raw compiled parity and memory-isolated Global/USGov representative transport preserve behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Ramses Sanchez-Hernandez (ramsessanchez)
merged commit Nov 12, 2026
563d417
into
powershell-v3
6 checks passed
Ramses Sanchez-Hernandez (ramsessanchez)
deleted the
ramsessanchez-mail-v3-migration
branch
November 12, 2026 01:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N/A
Changes proposed in this pull request
Make the Mail module configuration the source of truth for its three reviewed shared directives instead of relying on parity files that may be retired. Following the user's ownership request, the one suppression and six reply-all renames have moved out of derived parity JSON into
src/Mail/wrapper/Mail_cmdletConfigurations.cs, with unchanged generated command behavior.replyAll/threecreateReplyAllnames. Draft creation also has explicitNewverb overrides. The existing curated replyTo suppression is unchanged.parity-suppressions.v1.0.jsonentry and sixparity-renames.v1.0.jsonentries. The reviewed maps now declareCmdletConfiguratorand explicitly opt intoreplacesParityData: true. The small derivation change recognizes only those opted-in operations and recordsmodule-configurationin the resolution ledger, so a later derivation cannot recreate the duplicates. The frozen input and all unrelated rules remain intact.The scope is still the three shared cmdlet groups in
src/Mail/Mail.md. Original directives remain active and source-intent evidence accounts for all seven original same-profile selections and current compatible survivors. Every globalsrc/readme.graph.mdand profile-local directive is ignored. Aliases/transforms and schema/response changes remain deferred. No unrelated naming sweep, grouped route, authored profile filter, runtime/Auth patch, or other module edit.Supported profile and source evidence
Only v1.0 has an approved compatible Mail spec. Beta remains explicitly excluded because
openApiDocs_KiotaCompat/beta/Mail.ymlis absent, not because its API operations are proven absent or beta is generally unsupported. No beta build, transport invocation, or legacy-spec fallback.42f7093190db0aefecdd6c079ab37123f96d5d4ce1a19a44755a1c5a2f61ef2c8ebe88cc0949551bpowershell-v36475f3f5beb4908d39ea356db32bf1e0fd3273cb9f8c39ee3dade7cc91bc4cc5341ceb3741fd944aCommit boundaries and requested regeneration
All prior audit, normal target merges, source corrections, and client/cmdlet generation commits are preserved. Normal merge
a974dbfab3ffd32c9c383901f6c31085d36a4bdaincluded merged #3886, and the previous head was62ded8206be7c3377082ee9449b2c2a600375431.e9bafa1095f5ab27aacdb7d3093b6740958181fdmoves the reviewed parity entries into module configuration and updates related evidence, docs, derivation and tests.9f8c39ee3dade7cc91bc4cc5341ceb3741fd944arecords the separately requested full v1.0 Kiota client + cmdlet/project/manifest regeneration after that change. It is intentionally empty: all generated client/cmdlet/project/lock source content is byte-identical. No source changes were fabricated to imply regeneration.Both new commits carry the required coauthor and were pushed normally to this same existing PR; no amendment, rebase, force-push, duplicate PR, or merge.
Latest exact commands and results
Current evidence root (
$evidence):C:\Users\ramsess\.copilot\session-state\aa9ad2a2-473c-4a39-b1eb-152ad5636d52\files\mail-config-ownership.Worktree (
$repo):C:\Users\ramsess\Repos\copilot-worktrees\msgraph-sdk-powershell\ramsessanchez-bookish-winner.dotnet build .\tools\WrapperGenerator\WrapperGenerator.csproj --configuration Release --no-incremental --verbosity quiet- passed, exit 0.dotnet test .\tools\WrapperGenerator.Tests\WrapperGenerator.Tests.csproj --configuration Release --filter 'FullyQualifiedName~MailDirectiveMigrationTests|FullyQualifiedName~CmdletConfiguratorTests|FullyQualifiedName~NamingTests|FullyQualifiedName~DerivedCollisionResolutionsTests|FullyQualifiedName~RequiredQueryTests|FullyQualifiedName~PatchOperationTests' --logger 'trx;LogFileName=targeted.trx' --results-directory $evidence --verbosity quiet- passed, exit 0; actual TRX total/executed/passed 187, failed/not-executed 0. This includes the data-disabled ownership and future derivation regression..\tools\Get-WrapperDirectiveMigrationInventory.ps1 -Module Mail -FailOnUnresolved -OutputPath (Join-Path $evidence 'strict-inventory.json')- passed; exactly threeMappeddirectives, all implemented byCmdletConfigurator, with explicit beta exclusions.& 'C:\Users\ramsess\.copilot\session-state\871a5292-dc5b-423e-8083-5165b0006603\files\Invoke-QueuedModuleBuild.ps1' -RepoRoot $repo -Module Mail -ApiVersion v1.0 -Configuration Release- passed, exit 0,OK, 40.1 seconds, 146 exports. Full unchanged compatible-spec four-mutex pipeline, isolated Kiota1.36.1+fd3bf87790149b87f40f7eae1a5feb9016625943, process-local cap 1, verified adapted Authentication 2.41.2. No SkipKiota, GenerateOnly, NoCollisionData, or fallback. Slot 1 released automatically.pwsh -NoProfile -NonInteractive -File 'C:\Users\ramsess\.copilot\session-state\aa9ad2a2-473c-4a39-b1eb-152ad5636d52\files\post3886-6475-memory-final\Test-MailMemoryFinalRuntime.ps1' -RepoRoot $repo -EvidenceRoot $evidence -Environment Globaland the same command with-Environment USGov- both passed, exit 0, against the fresh normal manifest/bin. A copy of the exact script is retained in the current evidence folder.pwsh -NoProfile -NonInteractive -File .\tools\Compare-WrapperCmdletNames.ps1 -GeneratedPath .\src\Mail\wrapper\v1.0\Cmdlets -OutLedger (Join-Path $evidence 'raw-parity.csv')- passed, exit 0; raw compiled command parity 146/146, no skipped routes, normalization, mismatches or deliberate corrections.Unrelated pre-existing derivation drift, not a pass
pwsh -NoProfile -NonInteractive -File .\tools\Derive-ParityResolutions.ps1 -Validatealready failed before this change and still fails on the same 24 unrelated drives/shares list-permission suppression entries against the current Authentication oracle. Those rules were not changed. Before/after comparison records identical existing drift, while a fresh derivation changes only the seven intended Mail entries (six renames and one suppression, no added rules). The regression fixture verifies owned rules are omitted and neighboring derived rules remain. The whole-corpus drift gate is not claimed to pass.Baseline/current failures, exact 24-route equivalence, old/current derivation snapshots, and the initially corrected fixture placeholder mismatch are retained. The frozen input ledger is unchanged. No unrelated suppression refresh or parity-policy change is included.
Fresh compiled/runtime scope
Per Global/USGov run: 146 exports, 22 exact migrated/neighbor/worker/PATCH route assertions, 20 authenticated factory-pipeline offline requests, nine WhatIf and nine genuine declined-confirmation calls with zero HTTP, and two invalid bindings rejected before HTTP. The extra confirmation runspace imports before Connect; the normal in-memory helper is reapplied after its last import, with 19 actual reflected MockDataStore lifecycle checks and an actual MockDataStore assertion on each of the 20 HTTP captures. No credential-store I/O is inferred from old unguarded claims.
The six moved reply actions retain typed JSON and typed/void results. Existing direct/folder/child-folder message PATCH204 returns no output after exactly one PATCH while GET rejects with 403; PATCH200 returns the actual typed Message from one PATCH. Caller-explicit GET remains independent with its own
$select, header, 403/200 and result. Typed public item/default-list GET, optional Top, path escaping, bodyless send/content DELETE, adapter reuse, request-context/reconnect/disconnect and packaged assembly identities remain intact. Selected USGov requests retaingraph.microsoft.us/v1.0without mutating the real factory's Global-v1 BaseAddress or shared client.All 64 normal adapted Authentication package files and the physical nupkg SHA256
2FC09BFE6B70D313BC56DF8ADCCFB1976FB4E90A1898BF8A916B4B8B792898EBare verified. The wrapper requires 2.41.2, has no dependency preloads and contains only its three owned DLLs; Authentication owns the single Kiota/RMS/UriTemplate/Multipart closure. No old gallery/2.38 substitution, copied DLL bundle, shim, global environment edit, or install.Limits remain explicit: all 12 Mail PATCH sources are pinned but offline behavior probes cover the three message paths only; no required Mail queries exist, so mandatory query runtime tests are N/A. No grouped/composite surface, whole-module body/full-surface, live Graph/OAuth/network, pagination, PUT/media, package-install, PowerShell 5.1, or beta certification. No #3881/#3897 overlay or runtime changes; the obsolete implicit-GET header-loss expectation remains superseded. Existing NU1903 warnings are unchanged.
Current raw proof is under
mail-config-ownership: full build log/exit, TRX, strict JSON, fresh compiled Global/USGov JSON/logs, datastore checks, raw parity CSV, generated bin hashes, Auth64 verification and scoped/baseline derivation comparisons. Olderpost3886-6475-finalandpost3886-6475-memory-finalhandoffs and raw proofs remain untouched and historical.Other links