Repository navigation
Migrate Planner shared directives to v3 cmdlet configuration - #3890
Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 22 commits into
Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 22 commits into
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 22 commits into
Conversation
Preserve all eight shared AutoRest directives and map complete same-profile legacy selectors to pinned compatible operations. Cover suppressions and retained resource/function neighbors in module-specific regression tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…ration Run the complete queued Release pipeline against pinned Kiota-compatible v1.0 Planner with Kiota 1.36.1 and official Authentication 2.38.1. Client/project output is byte-identical except the regenerated client lock; generated cmdlets enforce the reviewed suppressions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…ration Run the complete queued Release pipeline with pinned compatible beta spec, Kiota 1.36.1 and official Authentication 2.38.1; retain tracked Beta casing. All 122 surviving baseline supported routes retain their names; the pinned spec lacks 18 stale generated goal routes, removed by normal regeneration. Preserve existing unrelated beta naming limitations without suppressing unique routes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…tadata Treat legacy operations without action/function metadata as resource operations when reviewing UserPlannerPlanCount and UserPlannerTaskCount. Add exact both-profile evidence and positive regression coverage; the existing v1 parity suppression is preserved and beta gains the shared directive's suppression. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…rection The corrected complete queued Kiota plus cmdlet/project Release pipeline succeeded in 43 seconds with 54 compiled exports. All generated client, cmdlet, project and lockfile output is byte-identical because v1.0 derived configuration already suppressed these two count routes; retain the required separate profile-generation boundary without fabricated source changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
… migration Repeat the complete queued Kiota plus cmdlet/project Release pipeline after the reviewed count correction. The generated client/projects/lockfiles are byte-identical; beta correctly drops only the two UserPlannerPlanCount/UserPlannerTaskCount cmdlets and exports 135 commands, retaining every other supported baseline route and name. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…z-planner-v3-migration
…iants Refresh all eight reviewed groups against current actual legacy and compatible specs. v1.0 uses complete supported literal evidence; beta retains 206 original survivors including 24 actual-kind guarded final action/function bridges, which still require normal merge of the reviewed Legacy inventory helper. Keep exact shared route configuration and parent/count fidelity unchanged. Update only Planner tests to three-setting GeneratorConfig with explicit separate runtime profiles for naming, suppression and full actual-spec generation; cover both oracle modes. Targeted Planner/configurator/naming regressions pass 117 tests. Strict current inventory honestly fails only beta directive 1 until #3847 merges. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the current-target full queued Kiota and cmdlet/client/project Release pipeline with Kiota1.36.1 cap1 and official Authentication2.38.1: exit0/OK54exports18.6seconds. All171reviewed suppressions absent, all50nonmigrated compatible routes present,10neighbors retained; raw current parity54/54. Client/cmdlet/project output is byte-identical except current spec client lock metadata. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the current-target full queued Kiota and cmdlet/client/project Release pipeline with Kiota1.36.1 cap1 and official Authentication2.38.1: exit0/OK238exports34.4seconds. Preserve tracked Beta casing and all120prior surviving route names; emit86additional current spec routes with no authored collision policy. All254shared suppressions remain absent and18neighbors remain present.
Do not claim full-surface coverage: the baseline shared emitter skips GET /planner/tasks_v2/{task-id}/customFieldValues/{customFieldValue-id} because its scalar value property is misclassified as a collection. Raw beta parity remains failing0/238 (132mismatches and106no-oracle), with no suppressions added to conceal those limitations. Final publication still requires normally merged reviewed Legacy helper and strict PASS.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…z-planner-v3-migration
Integrate the normally merged required-path ID alignment, refresh all609current method/path/ID rows, and remove rejected Legacy integration fields. Both unchanged original selections are complete with ordinary literal evidence:137v1.0 and206beta. Preserve unchanged shared exact suppressions, count fidelity, parent calls and a one-time historical route audit in tests. Actual normal strict inventory maps all8directives, and119Planner/configurator/naming regressions pass. No helper overlay, global generator change, profile-scoped authored rule or unrelated scalar-value emitter fix. Final generation and validation target PowerShell7/Core only. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…alignment Run full queued Kiota plus cmdlet/client/project Release pipeline on final source46243172be and normal target604bd968, using Kiota1.36.1 cap1 and original official Auth2.38.1 on PowerShell7/Core. Exit0/OK54exports20.0seconds;171suppressions absent,50unique routes,10neighbors, offline defaults/binder/WhatIf checks pass; raw parity54/54. Combined profile output is byte-identical; preserve the required generation commit boundary without fabricated deltas. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…ignment Run full queued Kiota plus cmdlet/client/project Release pipeline after final source46243172be on normal604bd968, Kiota1.36.1 cap1 and original official Auth2.38.1 on PowerShell7/Core. Exit0/OK238exports41.3seconds;254shared suppressions absent,206unique compiled routes,18neighbors, offline defaults/binder/WhatIf checks pass. Combined client/cmdlet/project sources byte-identical except updated compatible spec lock hash; preserve tracked Beta casing. Frozen nonmigrated scalarCustomFieldValue.value item-GET emitter omission and raw beta parity0of238 remain explicit baseline limits, not rewritten or suppressed. No actual network/mutation serialization or PowerShell5.1 validation claimed. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Ramses Sanchez-Hernandez (ramsessanchez)
requested a review
from a team
as a code owner
November 2, 2026 21:47
…z-planner-v3-migration
Assert actual whole-spec generation explicitly passes each separate runtime profile to GetRequestAdapter and never emits a bare/default or opposite-profile call, with derived naming data on and off. Keep existing literal directive evidence, shared authored rules, selected surfaces and frozen schema limits unchanged. Actual119module/configurator/namingtests pass; all8ordinary strict directives Mapped. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Complete full queued Kiota plus cmdlet/client/project Release generation after final source198407936e against target844672: exit0/OK54exports28.4seconds, canonical adaptedAuth2.41.2complete64filepackage andKiota1.36.1cap1. Emit explicit v1.0 runtime service root and regenerated project ownership: wrapper bin contains only its three owned DLLs; Authentication owns complete Kiota/RMS/UriTemplate/Multipart closure without preloads. Kiota client source byte-identical; preserve separate combined profile-generation boundary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Complete sequential full queued Kiota plus cmdlet/client/project Release generation after final source198407936e against target844672: exit0/OK238exports57.9seconds, canonical adaptedAuth2.41.2complete64filepackage andKiota1.36.1cap1. Emit explicit beta runtime service root and regenerated project ownership: three wrapper-owned DLLs only, no dependency preloads or duplicate Auth/Kiota. Kiota client source byte-identical; preserve separate combined profile-generation boundary and tracked Beta casing. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…z-planner-v3-migration
Assert whole actual-module generation emits one PATCH with no sibling GET or null-result readback and keeps headers, ShouldProcess and typed200output. Audit both actual Planner profiles for zero required native query inputs without inventing aliases. Preserve original shared literal selection, defaults, count/IfMatch intent and frozen scalar-value omission.191combined Planner/configurator/naming/required-query/PATCH tests pass; ordinary strict8Mapped. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued Kiota/client/cmdlet/project Release generation against normal6475afterfinalsource01698f6cd6:exit0/OK54exports57.7seconds; supplemental no-incremental build exit0. Preserve client and lock output where byte-identical; generated PATCH commands now perform one mutation with no automatic GET, keep typed200output and native headers/ShouldProcess. Canonical64fileadaptedAuth2.41.2/Kiota1.36.1cap1; nooverlays. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued Kiota/client/cmdlet/project Release generation against normal6475afterfinalsource01698f6cd6:exit0/OK238exports201.3seconds; supplemental no-incremental build exit0. Preserve client and lock output where byte-identical; generated PATCH commands now perform one mutation with no automatic GET, keep typed200output and native headers/ShouldProcess. Canonical64fileadaptedAuth2.41.2/Kiota1.36.1cap1; nooverlays; preserve tracked Beta casing and prior generation history. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No separate issue is linked.
Changes proposed in this pull request
src/Planner/Planner.md. Preserve original AutoRest directives, reviewed annotations, the ordinary exact method/path/ID ledger, published defaults and positive/unaffected-neighbor tests. Required profiles remain exactly v1.0 and beta, with no exclusions and trackedwrapper/Betacasing preserved.6475f3f5beb4908d39ea356db32bf1e0fd3273cb, on the same branch/PR and without rebasing, amending, cherry-picking or force-pushing. Preserve prior source and separate combined profile-generation boundaries. No new capability, schema/naming policy, Legacy bridge, global helper/runtime/Auth/template edits or unmerged Fix Kiota PostPath typed navigation without renaming operation types #3881/optional-query [v3 wrappers] Support arbitrary optional query parameters #3897 work.Ignored/deferred scope: ignore all profile-local readmes and
src/readme.graph.md. Parameter/schema aliases and transforms remain deferred; none occur in the shared Planner source. PowerShell 7/Core only; 5.1 unsupported/out of scope. No live Graph/OAuth/credential-store operations or dependency-injection shims.Reviewed dispositions
The shared 254-entry exact configuration is unchanged: 171 unique v1.0 / 254 unique beta suppressions. The one-time historical qualified action/function route audit remains only in module tests.
Integration and commit boundaries
fde35d161fc57eafb99c/0dabcef99a997caca220,87d5896d4c/cb858af6849cf25c267b,0eed050fa95eab3ca588/cf4f6e988a69bb91a03c,46243172be604bd968af8229a5e8/c9c39382d53c857d71dd,198407936eab0680c6bd/ba1c90225ebc69c503d92be1633100c5a1e183845713a46f4a01698f6cd62d427294da: 40 files, client/lock byte-identical where no deltac22d1b7aa5: 140 files, client/lock byte-identical where no deltaCanonical head:
c22d1b7aa59a37c0d31586e076faf15bb7fc0c02. Co-author trailers retained. Full uncapped Git no-rename scope: 757 paths; no bin/obj, binaries, packages or session logs are committed. This is not a capped/rename-collapsed REST count.Actual final source/build evidence
6b17e5c670edb0cfa60f0e0c3f4f03f43ca9e950dd3e46fdb6f30eb2c530119979654f2876dca775ae762ea25793ba27bc4c013870176fd8e94ef8d3ff945046e9fb2d11ae0207f1ea3e4d0cbc7ae32dBoth use the exact normally packaged adapted Authentication2.41.2 root:
C:\Users\ramsess\.copilot\session-state\4aa86cf9-d43c-4d2b-a4a3-aeaed01b8f29\files\authentication-v2-sync\final-source\modules.All 64 SHA256 file identities and physical Authentication nupkg SHA256
2FC09BFE6B70D313BC56DF8ADCCFB1976FB4E90A1898BF8A916B4B8B792898EBare verified. No stock Gallery/old2.38 substitution, global installation or loader shim.Process-local PATH prepends the isolated Kiota directory. Version is 1.36.1+fd3bf87790149b87f40f7eae1a5feb9016625943, concurrency cap1. PSModulePath starts with that exact adapted Auth root, then the existing user, Program Files and PowerShell7 module roots. The original shared four-mutex queue is unchanged and fingerprinted.
Both supplemental
dotnet build --no-incremental --no-restorechecks also pass. No SkipKiota, GenerateOnly, NoCollisionData, legacy fallback or NO-CMDLETS acceptance. Required full profiles were not rerun for the later probe-isolation setup correction.Fresh normal manifests require Auth2.41.2, have zero RequiredAssemblies preloads, and bins/packages contain only the module, typed client and runtime DLLs. No duplicate Authentication/Kiota/RMS/UriTemplate/Multipart ownership. Exact migrated operations, defaults, native path-ID metadata, neighbors and frozen omissions remain checked against actual compiled outputs.
Exact final validation commands and results
Build/source evidence root (immutable after completing the original full profiles/tests):
In the same prescribed process-local environment, sequentially:
All four exit0; full-generation OK populations/times above. Raw queue/build/nonincremental logs and actual exits are retained, including queue wait; timing above is the builder's actual module-generation/build time.
Passed: ordinary strict 8 rows / 8 Mapped / 0 unresolved, exit0; actual targeted TRX 191 total/executed/passed, 0 failed/notExecuted; runtime TRX 28 total/executed/passed, 0 failed/notExecuted. The targeted project also received a fresh nonincremental build. Module tests prove zero inherited/operation-level required native query parameters in both actual Planner specs, complete selections, no automatic GET/null-readback in emitted PATCH, typed nonnull-output guard, headers and ShouldProcess.
Fresh compiled metadata gates:
All four pass, exit0, against the final canonical normal-manifest assemblies. The cloud transport proof is separately paired with each metadata record.
Actual guarded transport commands:
These are real generated module requests through Connect-MgGraph + GraphHttpClientFactory's token pipeline + terminal offline handler, not just source/WhatIf assertions. Captures contain actual method, encoded URI, JSON body, generic header, If-Match, response status and per-case request counts. All tests are offline; no Graph/OAuth calls.
Runtime-isolation setup correction: normal OnImport in a second runspace resets the shared datastore. The final probes reapply the existing
Set-MgTestDataStoreafter the last additional-runspace module import and before the first Connect. They assert and record the actual reflectedGraphSession.DataStore.GetType().FullNamebefore each transport/lifecycle case, factory construction, context change, reconnect and disconnect/logout. Every recorded type isMicrosoft.Graph.Authentication.Test.Mocks.MockDataStore. No production Auth/loader/source/package change. Earlier completed unguarded v1 proofs remain unchanged in$b; only affected offline runtime probes were rerun into$m. Beta's first final HTTP gates use the guard. Valid prior build/TRX inputs and their absolute paths/hashes are referenced, not regenerated or relabeled. No credential-I/O inference is made from the prior datastore type.Positive new PATCH contract:
Other real passing cases: typed GET/POST bodies/results, date/enum/model PATCH JSON, published List default, bodyless DELETE with If-Match, beta typed archive/move and bodyless extendExpiry actions, invalid-binder zeroHTTP, WhatIf zeroHTTP and genuine declined Confirm zeroHTTP with one prompt each. Cache/profile/client reuse, context/reconnect invalidation, logout error identity and single normal Authentication-owned assembly closure pass.
Factory BaseAddress stays
https://graph.microsoft.com/v1.0/even in USGov tests; actual generated requests use the correct cloud host and explicit beta/v1.0 service root. Alternating typed profile requests do not mutate that shared authenticated client. Required-query source tests establish no applicable Planner required native inputs; no aliases or unsupported query bindings were invented. Optional query behavior is unchanged.Supplemental native pack of already completed full outputs and existing package gates:
All pass, exit0: 54/238 package exports match manifests, zero orphan workers, actual NoGraphSession dispatcher, complex/enum conversions, 1/2 scalar cases and 19 untyped cases per profile. Packaged DLL hashes match the final compiled bins; normal manifest/package/assembly hashes are retained. Pack is not a substitute for FULL generation.
Raw parity remains explicit: v1.0 exit0, 54/54 match; beta exit1, 0/238 match, with 132 existing mismatches (117 Mg/MgBeta-prefix-only, 15 other names) and 106 no-oracle rows. Prefixes are not normalized into a claimed raw pass.
Frozen limits
The beta client-only item GET omission remains unchanged:
/planner/tasks_v2/{task-id}/customFieldValues/{customFieldValue-id}. Kiota supports it; the existing shared emitter mistakes scalarCustomFieldValue.valuefor a collection property. No unrelated schema/emitter fix, suppression or all-surface claim. Beta population remains 461 operations: 254 reviewed suppressions, 206 emitted unique routes, one frozen nonmigrated omission. Live tenant paging/delta and all Graph functionality are not certified.Old
844672four-row exit1 implicit-refetch/header reports and earlier 604bd/08 evidence remain untouched. That contract was superseded by the user's #3886 one-operation decision; new gates prove new behavior rather than editing old FAIL records into PASS. No #3881 or optional-query #3897 overlay.Canonical current handoff:
$m\handoff.json, containing scalar actual counters, exact normal merge/source/profile commits, live PR/head, original build/TRX paths/hashes, strict mappings, profile/spec/Auth64 identities, compiled/package data, actual memory-store guard/capture paths and a full artifact SHA256 inventory.Other links
PlannerDirectiveMigrationTests.csretain original source intent and historical route audits.