Repository navigation
Audit PersonalContacts shared directives for v3 - #3846
Merged
Ramses Sanchez-Hernandez (ramsessanchez) merged 15 commits intoNov 12, 2026
Merged
Ramses Sanchez-Hernandez (ramsessanchez) merged 15 commits into
Ramses Sanchez-Hernandez (ramsessanchez) merged 15 commits into
Conversation
Record the intentionally empty reviewed ledger and pin unaffected operations against both real Kiota-compatible profile specifications without introducing overrides. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the full Release Kiota 1.36.1 and wrapper pipeline against the compatible v1.0 spec. Generated client/cmdlet sources and projects remain unchanged; only the Kiota tool-version lock changes. Compiled import exports the same 78 cmdlets and operation-name parity passes 70/70 plus 8 dispatchers. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run full Release Kiota 1.36.1 and wrapper generation against the compatible beta spec, using official Authentication 2.38.1 after the 2.41.0 isolated-loader import failure. Compiled manifest imports all 78 baseline cmdlets including the Kiota Date parameter. Client/cmdlet sources and projects are unchanged; lock files record the CLI version and canonical beta spec path. Preserve committed Beta output casing and inherited naming differences. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Ramses Sanchez-Hernandez (ramsessanchez)
requested a review
from a team
as a code owner
October 22, 2026 00:49
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep generation profile separate from GeneratorConfig, propagate it explicitly to suppression and naming with derived data enabled and disabled, and guard beta against v1.0 derived permanent-delete names. Refresh real operation-ID evidence and compatible spec blobs after normal target integration. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the full queued Kiota 1.36.1 and wrapper Release pipeline against integrated target 08e409a and compatible spec d7a60e3. Build status OK in 73.00s; fresh official Authentication 2.38.1 manifest import preserves all 78 baseline exports. Verify 70 exact compiled routes, 21 audited neighbors, 5 action routes, and ShouldProcess/WhatIf/Confirm on all 35 mutations. Client/cmdlet source and generated projects remain unchanged; only the Kiota description hash changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the full queued Kiota 1.36.1 and wrapper Release pipeline against integrated target 08e409a and compatible beta spec ad65c52. Build status OK in 126.10s; fresh original official Authentication 2.38.1 manifest import preserves all 78 baseline exports and beta Date binding. Verify 70 exact compiled routes, 21 audited neighbors, 5 beta action routes, and ShouldProcess/WhatIf/Confirm on all 35 mutations. Client/cmdlet source and generated projects remain unchanged; only the Kiota description hash changes. Raw beta oracle naming differences remain explicit, not normalized away. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Separate current adapted Authentication 2.41.2 transport and dependency-ownership requirements from preserved historical 2.38.1 proof. Keep the shared directive audit empty and all existing profile-specific naming and source restrictions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued Release Kiota+wrapper generation on normally merged 844672d succeeds with 78 exports in 17.10s. Regenerate explicit v1.0 adapter context in 70 request cmdlets and new project dependency ownership; normal manifest requires adapted Authentication 2.41.2 with only three owned DLLs and no preloads. Fresh compiled routes and offline authenticated factory Global/USGov typed CRUD/profile/safety/context checks pass. Preserve and report the existing bound-Headers-on-refetch limitation from unmerged #3886 rather than claiming it passed. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued Release Kiota+wrapper generation on normally merged 844672d succeeds with 78 exports in 28.00s. Regenerate explicit beta adapter context in 70 request cmdlets and dependency-ownership project; normal manifest requires adapted Authentication 2.41.2 with only three owned DLLs and no preloads. Actual authenticated factory Global/USGov requests retain beta roots despite the factory v1.0 BaseAddress, with typed beta postal-address CRUD, selected 204 refetch, and safety/context gates. Preserve inherited raw beta naming differences and explicitly failed generic refetch-header check pending unmerged #3886. Do not waive or overlay that framework limitation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Validate actual real-spec PATCH surfaces for both profiles: all eleven PATCH emitters send no implicit GET, preserve native headers/body and explicit profile, return only nonnull own results, and introduce no GET-only queries or readback switches. Verify zero required-query APIs without inventing fixtures or overrides. Document current 204 no-output and independent GET behavior while preserving old refetch proof as superseded history. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued Kiota+wrapper Release generation against6475f3f5 succeeds with78exports in74.60s, followed by no-incremental build. Preserve all client/project/lock bytes; normal emitter removes implicit GET from all11PATCH cmdlets and adds only required-query template whitespace to27GET sources. Fresh normalcompiled78names/70routes and realfactoryGlobal/USGov each30HTTP/4declines prove204onePATCH/nooutput underGET403,200onePATCHtyped,independentGET,nativequeries,all11paths/body/headers,safety/cache/ALC. No raw baseline naming or source-scope changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued Kiota+wrapper Release generation against6475f3f5 succeeds with78exports in199.20s, followed by no-incremental build. Preserve client/project/lock bytes; remove implicit GET from all11PATCH emitters and retain normal GET template whitespace. Fresh normalcompiled78names/70routes and post-import reflectedMockDataStore guarded Global/USGov realfactory probes each30HTTP/4declines prove204onePATCH/nooutput/noGET403,200onePATCHtyped,explicitGET,nativequeries,all11paths/body/headers,safety/cache/ALC. Runtime probe isolation only; no shipping Auth/runtime changes or old proof rewrites. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Ramses Sanchez-Hernandez (ramsessanchez)
merged commit Nov 12, 2026
fbc5ff1
into
powershell-v3
6 checks passed
Ramses Sanchez-Hernandez (ramsessanchez)
deleted the
ramsessanchez-personalcontacts-v3-migration
branch
November 12, 2026 23:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
src/PersonalContacts/PersonalContacts.md: zero shared cmdlet/deferred directives, an honest empty reviewedmappings: [], and unchanged empty configurator. Preserve the active AutoRest configuration, existing IDs/names/defaults/neighbors and shared intent; no invented overrides/groups or translated legacy fields.src/readme.graph.md. Parameter aliases/transforms and schema/response directives remain deferred classes, with none in this shared source. Preserve committedv1.0andBetaoutput casing.Current target, head and additive history
Target
6475f3f5beb4908d39ea356db32bf1e0fd3273cb; current PR head24c3de76a59cbce560e122204a18eab9efe01424.92851b4123f1595e62f061aaecef1009417c91a2ff0b443504312ac433cec6d720384ba3e621304aand all earlier migration/profile boundaries.bf460f06d79fbae9dfa1595e86163a58200e0cbf66572af1861ef2f48859b9755cdb408f7219d1a724c3de76a59cbce560e122204a18eab9efe01424Every new commit has the required Copilot App co-author trailer. No rebase, amend, force push, cherry-pick, new PR, unmerged #3881 overlay, #3897 implementation, framework/other-owner changes or automatic merge. Client sources, projects and Kiota locks are Git-identical after the current full runs; no source deltas are fabricated.
Actual full builds and normally packaged Authentication
Full required profiles ran v1.0 then beta through the unchanged four-slot queue, not SkipKiota/GenerateOnly/NoCollisionData/fallback or a zero-cmdlet substitute. Each profile's supplemental
--no-incrementalbuild ran after its full queue command and before compiled acceptance, exit 0. Slots released automatically.d7a60e304e2116012e806bc33ef578ba2c9cda85ad65c527d83a7af23877005de6435d49e92b9662Use the exact adapted Authentication 2.41.2 normal package first on process-local PSModulePath:
C:\Users\ramsess\.copilot\session-state\4aa86cf9-d43c-4d2b-a4a3-aeaed01b8f29\files\authentication-v2-sync\final-source\modules.All 64 file SHA256s and physical package SHA256
2FC09BFE6B70D313BC56DF8ADCCFB1976FB4E90A1898BF8A916B4B8B792898EBare verified. Shipping Auth/runtime/templates are unchanged from the accepted normally merged source. Fresh imports require that exact package; no Gallery substitute, old 2.38 acceptance, dependency reconstruction, preload, loader shim or global install.Tooling: Kiota
1.36.1+fd3bf87790149b87f40f7eae1a5feb9016625943, process-local model parallelism 1, .NET 10.0.403 / PS7 Core. Normal manifests require Authentication 2.41.2, no RequiredAssemblies preloads; bins and native package snapshots contain only the three owned client/runtime/module DLLs.Current tests, strict inventory and compiled checks
Results: build exit 0; actual TRX 192 total/executed/passed, 0 failed/not-executed; ordinary strict exit 0, zero rows/mapped/deferred/unresolved/invalid/candidates and valid empty ledger. No unrelated shared test changes.
Each profile's fresh normal manifest verifies 78 baseline exports, 70 exact same-profile GraphRoutes, 21 audited neighbors, five profile-specific action names/routes, all 35 ShouldProcess mutation contracts, all 11 no-readback PATCH emitters, explicit runtime profile and zero invented Query inputs. Grouped/composite alternatives and mandatory Query inputs are not applicable to this module's actual source; shared required-query regression tests still ran. No missing/null/empty Query claims are fabricated for nonexistent APIs.
New positive real-HTTP acceptance, not relabeled historical proof
Valid unchanged build/TRX/strict/normal-compiled/package proof is retained under
$buildProof:C:\Users\ramsess\.copilot\session-state\b987a4ae-e8cd-44c9-8b9a-9bfd66817f41\files\post3886-6475-final.Corrected datastore-isolated runtime and canonical
$proofhandoff are under:C:\Users\ramsess\.copilot\session-state\b987a4ae-e8cd-44c9-8b9a-9bfd66817f41\files\post3886-6475-memory-final.Both memory-only runners exit 0. Each invokes fresh Global and USGov
Test-PersonalContacts-Transport.ps1children against the same normal compiled bins. The separately completed compiled imports, nativedotnet pack --no-buildsnapshots and fresh package imports remain under$buildProof; neither supplemental packing nor the isolation correction replaces/restarts full generation.The existing
Set-MgTestDataStorehelper is reapplied after the last secondary-runspace module import and before the first Connect. The reflected actual sharedGraphSession.DataStore.GetType().FullNameis verified asMicrosoft.Graph.Authentication.Test.Mocks.MockDataStorebefore transport and every context/reconnect/logout lifecycle operation: 76 actual stage/type checks per case (304 total), with helper/source hashes retained. The post-secondary-import value was actually observed asDiskDataStorebefore reapplying the helper. The earlier unguarded v1 runtime reports are preserved unchanged, not relabeled; only affected offline gates were repeated. Beta's first runtime pass was guarded. No source, full build, TRX, or generation commit was repeated because of this probe-only correction. A previous datastore type alone is not evidence that credential I/O occurred.Connect-MgGraph, existing MockDataStore and real authenticatedGraphHttpClientFactory.$select; it is not issued by PATCH.Propertyon PATCH fail before HTTP./v1.0or/betaand.com/.ushost despite the factory's unchanged global/v1.0/BaseAddress. One accepted normal Auth/Kiota/RMS/URI identity/context is verified; no shared-client mutation or assembly injection.The old bound-header-on-implicit-refetch failure is USER-SUPERSEDED by the new no-implicit-GET behavior, not an unresolved gate, waiver, or an old FAIL relabeled PASS. All old evidence remains untouched. Offline controlled response tests prove framework behavior, not every tenant API's live response policy.
Raw parity and unchanged frozen limitations
Current raw v1.0 parity passes 78/78 (exit 0); beta raw parity remains 0/78 (exit 1), with inherited
Mg/MgBetaprefix and five permanent-delete action-name differences. No normalized beta pass is claimed; complete baseline command names remain unchanged.Three existing photo-content PUT operations remain unsuppressed but un-emitted because of unsupported success-response shape; tests do not claim those compiled exports. Existing NU1903 YamlReader and CS0618 Authentication build warnings remain outside this module scope. No #3881 PostPath or #3897 optional-query work was copied.
Earlier migration/generation/Authentication commits, original
auth-compatible2.38 root, old failures and candidate proofs remain intact. Canonicalhandoff.jsonretains scalar counters, exact current head/target/commits, source/spec/Auth64/tool/queue identities, full Git scope including deleted/renamed paths, all command exits/TRX, normal manifest/package/assembly hashes and actual HTTP captures.Other links