Repository navigation
Migrate Education shared directives to v3 wrapper configuration - #3868
Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 20 commits into
Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 20 commits into
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 20 commits into
Conversation
Bridge every actual legacy regex match to compatible DELETE routes in both profiles. Preserve neighboring reference operations and existing curated coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run full queued Release generation and build with Kiota 1.36.1 and compatible v1.0 spec. All generated client/cmdlet sources and projects remain unchanged; only the Kiota lock tool version changes. Compiled module exports 450 cmdlets; seven selected DELETE routes are absent and all 21 reference neighbors remain. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Unblock full beta generation using exact published beta/v1.0 oracle evidence, matching existing v1.0 collision suppressions. Suppress only the two nested GET collisions; retain the published assignmentCategories routes and all neighboring reference operations. These baseline collision rules are separate from the seven shared directive DELETE mappings. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run full queued Release generation and build from the required compatible beta spec with Kiota 1.36.1. Add the previously missing beta client, cmdlets, generated projects and lock files together. Compiled module exports 450 cmdlets; all seven selected DELETE operations are absent and all 21 reference neighbors remain. Retain unchanged generator output, including existing Kiota whitespace and unrelated beta naming limitations. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve the complete original seven-operation legacy selection per profile, verified against refreshed current compatible specs. Current literal selectors equal all surviving routes, so use the existing supported inventory schema. Pin original operation lineage and exact current selection in tests while retaining prior shared-policy collision repairs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the complete queued Kiota and wrapper Release pipeline against target abab9da with Kiota 1.36.1 and model parallelism 1. Regenerated cmdlets and projects are byte-identical; retain current generated client model changes and lock together. Compiled module exports 450 cmdlets, suppresses the selected seven DELETE routes and preserves 21 neighbors; direct naming parity passes 402/402. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the complete queued Kiota and wrapper Release pipeline against target abab9da with Kiota 1.36.1 and model parallelism 1. Regenerated cmdlets and projects remain byte-identical; retain generated client model changes and lock together. Compiled module exports 450 cmdlets, suppresses the selected seven DELETE routes and preserves 21 neighbors. Preserve known baseline beta naming limitations without broadening this shared-directive migration. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Ramses Sanchez-Hernandez (ramsessanchez)
requested a review
from a team
as a code owner
October 27, 2026 19:06
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use merged #3849 GeneratorConfig run settings without a profile argument. Pass the profile explicitly to every suppression check, and cover naming and real-spec reference generation with data on/off so beta cannot accidentally reuse the v1.0 oracle. Preserve the complete seven-operation source selection, 21 neighbors, and published count/delta collision repairs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the complete queued Kiota/client and wrapper Release pipeline against normally merged 08e409a with Kiota 1.36.1, parallelism 1, and official Authentication 2.38.1. All regenerated sources, projects and locks are byte-identical; this explicit empty generation boundary records the required real run. Build exits 0, status OK, 450 exports in 132.6 seconds. Fresh compiled audit proves seven suppressed DELETE routes, 21 preserved neighbors with mutation WhatIf/Confirm, and both published count/delta routes. Current raw parity passes all 450/450 routes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the complete queued Kiota/client and wrapper Release pipeline against normally merged 08e409a with Kiota 1.36.1, parallelism 1, and official Authentication 2.38.1. All regenerated sources, projects and locks are byte-identical; this explicit empty generation boundary records the required real run. Build exits 0, status OK, 450 exports in 135.9 seconds. Fresh compiled audit proves seven suppressed DELETE routes, 21 preserved neighbors with mutation WhatIf/Confirm, and both published count/delta routes. Current raw parity reports unchanged beta naming limitations over all 450 routes (the updated tool now also validates dispatchers); not claimed as a pass. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Assert every real-spec generated reference neighbor uses GetRequestAdapter with its explicit v1.0 or beta profile and never the legacy bare overload. Preserve shared directives, authored rules and explicit runtime oracle profile checks. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run complete queued Kiota and wrapper Release pipeline against normal target844672d7 with source-equivalent packaged Authentication2.41.2. Preserve regenerated explicit v1.0 adapter calls and own-three-DLL project packaging together; typed client and locks regenerate unchanged. Build exit0/OK450exports27.3s. Fresh Global/USGov normal-manifest factory HTTP validates selected suppressions,21neighbors,natural ID/defaults,typed GET/nested POST/PATCH204 refetch,bodyless DELETE/action,binder and genuine No. Known3886 refetch custom-header loss remains explicit; no framework workaround. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run sequential complete queued Kiota and wrapper Release pipeline against normal target844672d7 with source-equivalent packaged Authentication2.41.2. Preserve regenerated explicit beta adapter calls and own-three-DLL project packaging together; typed client and locks regenerate unchanged. Build exit0/OK450exports38.6s. Fresh Global/USGov normal-manifest authenticated factory requests preserve /beta and cloud hosts without changing factory BaseAddress; full mutation/binder/safety/load identity gates pass. Baseline raw parity and known3886 refetch custom-header limitations remain explicit, not fixed or waived. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add real-spec module regressions proving PATCH emits one native mutation with only its own result and no sibling GET dependency/readback flag, for both API profiles with or without a sibling GET. Independently prove all seven required @id DELETE query operations remain the original suppressed shared selection. Preserve source intent and all unrelated surfaces. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run full queued Kiota/client and cmdlet Release generation against normal target6475f3f5 plus non-incremental compile with packaged Authentication2.41.2. Emit PATCH204 success without output or implicit GET and PATCH200 actual response only. Preserve existing source-selected query suppressions and all neighboring routes. Fullbuild exits0/OK450exports140.9s; actual typed/body/query/header/safety offline Global probe passes new contract. Client, projects and locks regenerated byte-identically; retain all real cmdlet deltas together. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run sequential full queued Kiota/client and cmdlet Release generation against normal target6475f3f5 plus non-incremental compile with packaged Authentication2.41.2. Emit PATCH204 success without output or implicit GET and PATCH200 actual response only. Preserve original query suppressions and all neighboring routes. Fullbuild exits0/OK450exports494.6s. Client, projects and locks regenerate byte-identically; retain all real cmdlet deltas in this separate profile boundary. Runtime acceptance uses new memory-guarded probes without production or build reruns. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N/A - Education shared-directive migration and final normal-target revalidation.
Changes proposed in this pull request
src/Education/Education.mddirective, the two original curated rules, both published count/delta collision repairs, and all 21 collection-reference GET/POST and item-reference DELETE neighbors. No restored selected operations, new groups, aliases, invented suppression or naming expansion.src/readme.graph.mdare ignored and untouched. No shared parameter/schema directive classes are present to implement or defer.6475f3f5beb4908d39ea356db32bf1e0fd3273cb, including merged Remove automatic GET after successful PATCH #3886, and regenerate both full profiles. PATCH 204 now succeeds with one PATCH, no output, no automatic GET. PATCH 200 returns its actual typed response in one PATCH. Caller-explicit Get has an independent header/query/result/error contract; no PassThru/ReadBack/Refetch flag or GET-only PATCH parameters are introduced. Module tests pin this with and without a sibling GET.Current head:
51d0b1b15978ceec21c303fc84b345f7a56bf28c. Normal target merge:4b96119dd2d59178fb316f9b7ca922846ca9fe51. Prior published head25a6c981b3cc225caa7ee1265ddbb7fbbc49477eand all original source/profile commits are preserved. No rebase, amend, force-push, copied unmerged prerequisite or global/other-module edit.New PATCH contract, not relabeled historical proof: the old four #3886 PATCH-204/readback-header failures remain unchanged in the earlier
Education-844672-revalidationreports. Those implicit-GET expectations are user-superseded, not waived or flipped to PASS. New compiled captures positively verify no GET after PATCH 204/200 while GET is configured to reject with 403.Current command/results
<build-proof>=C:\Users\ramsess\.copilot\session-state\d2c3231b-2ade-435d-b7f7-cc8d42f864f5\files\post3886-6475-final.<runtime-proof>= the separate corrected offline evidence rootC:\Users\ramsess\.copilot\session-state\d2c3231b-2ade-435d-b7f7-cc8d42f864f5\files\post3886-6475-memory-final.pwsh -NoProfile -NonInteractive -File tools\Get-WrapperDirectiveMigrationInventory.ps1 -Module Education -FailOnUnresolved -OutputPath <build-proof>\strict-inventory.jsondotnet test tools\WrapperGenerator.Tests\WrapperGenerator.Tests.csproj --filter 'FullyQualifiedName~EducationDirectiveMigrationTests|FullyQualifiedName~CmdletConfiguratorTests|FullyQualifiedName~NamingTests|FullyQualifiedName~DerivedCollisionResolutionsTests|FullyQualifiedName~RequiredQueryTests|FullyQualifiedName~PatchOperationTests' --no-restore --verbosity minimal --logger 'trx;LogFileName=targeted.trx' --results-directory <build-proof>pwsh -NoProfile -NonInteractive -File C:\Users\ramsess\.copilot\session-state\871a5292-dc5b-423e-8083-5165b0006603\files\Invoke-QueuedModuleBuild.ps1 -RepoRoot <Education-worktree> -Module Education -ApiVersion v1.0 -Configuration Release-ApiVersion beta, after v1.0 completeddotnet build src\Education\wrapper\v1.0\Microsoft.Graph.Wrapper.Education.csproj -c Release --no-incremental --no-restore --nologo --verbosity minimaland same forbetapwsh -NoProfile -NonInteractive -File <runtime-proof>\Confirm-EducationRuntime.ps1 -RepoRoot <Education-worktree> -Profile <v1.0 or beta> -Environment <Global or USGov> -OutputPath <runtime-proof>\compiled-<profile>-<cloud>.jsonpwsh -NoProfile -NonInteractive -File tools\Compare-WrapperCmdletNames.ps1 -GeneratedPath src\Education\wrapper\v1.0\Cmdlets -OutLedger <build-proof>\parity-v1.0.csvsrc\Education\wrapper\beta\Cmdlets, outputparity-beta.csvBoth full runs use the existing isolated Kiota
1.36.1+fd3bf87790149b87f40f7eae1a5feb9016625943, process-local model parallelism 1, .NET SDK10.0.403, and the designated normally packaged adapted Authentication 2.41.2 root first in process-local PSModulePath. They use compatible specs and no SkipKiota, GenerateOnly, NoCollisionData, fallback or NO-CMDLETS acceptance.Required-query and source policy
The complete current Education specs contain exactly seven required
@idquery operations per profile, all belonging to the original shared suppressed DELETE selection. Module tests independently prove that full set; compiled checks confirm zero surviving required-query cmdlets. No QueryId or mandatory-query operation is restored, suppressed additionally, or invented for a test. Item-reference no-query DELETE neighbors remain bodyless with their mandatory path IDs and If-Match header. Optional Select aliases keep their current native$selectwire encoding; no optional-query expansion is claimed.Positive compiled transport/binder/safety acceptance
EducationClassresponse, including distinct response ID/nested course; no GET, with GET still configured to reject. No GET-only input or readback flag is exposed.Across the corrected final matrix: 72 offline authenticated requests / 16 genuine declined prompts / 0 live Graph requests. No new grouped/composite policy, PUT/media gate or unsupported capability is invented for this suppression-only migration.
Runtime-isolation addendum applied without rebuilding
The parent's reproduced additional-runspace import can replace shared GraphSession.DataStore. The corrected probe imports the normal module in all runspaces first, then reapplies the existing
Set-MgTestDataStorehelper before Connect or HTTP, and reflects the actual shared DataStore type before transport, reconnect/context changes and logout. All 34 recorded checks per run (136 total) equalMicrosoft.Graph.Authentication.Test.Mocks.MockDataStore, including immediately before/after disconnect. Actual types, stage names, source script, requests and load contexts are retained in the new runtime proof.The preliminary unguarded v1.0 precommit probe remains unchanged in
<build-proof>and is not current runtime acceptance. No credential-I/O claim is inferred from that earlier type setup. Only offline probes were corrected; full builds, TRX, source and generation commits were not rerun or changed for this setup fix.Normal Authentication/package identity
The complete 64-file SHA256 manifest and physical Authentication nupkg SHA256
2FC09BFE6B70D313BC56DF8ADCCFB1976FB4E90A1898BF8A916B4B8B792898EBare verified. Shipping Authentication/runtime/templates remain source-equivalent to the prior normally integrated package. This is the designated local adapted package, not Gallery Authentication, old 2.38, a copied closure or a shim.Fresh normal wrapper manifests require Authentication 2.41.2, have no RequiredAssemblies preloads, and bins contain only the module/client/runtime three owned DLLs. Each runtime run records 12 unique actually loaded Auth/Kiota-related identities, packaged paths, SHA256s and correct Default/Authentication load contexts. No duplicate RMS/UriTemplate/Kiota closure is added. No wrapper nupkg was needed or produced; actual manifest/assembly hashes and the physical Authentication package are the measured artifacts. PowerShell 7/Core only; PowerShell 5.1 remains unsupported.
History and separate full-generation boundaries
f0f1c65628b8340bc46f,a59e54b222305c9243d47ffb832ce1,1422b414ff,1d6a69b161,5c02be72a509c047c4a7,4536380e82,ae433c49b0,e92779024ad8d308c09a,50e20cca43,a509ec056b,25a6c981b34b96119dd26475f3f5merge; no copied unmerged framework source.c743fa03c25396d3978851d0b1b159Compatible Education spec Git blobs remain v1.0
062d6659bf55e305f450d8dd79a9ea6cfafa4b5f, betae440ad323d7887ad6c67c01a8bc877528f6966cb; original legacy blobs70cf3fb99240cb90e3914b3afb41527a96a9d8e4/9e542b610385ae40648b13b8ccfab6e068b7b3ad.Evidence: corrected canonical
<runtime-proof>\handoff.jsonrecords actual scalar TRX/strict/build/runtime counters, final target/head/merge/source/profile commits, original/current input hashes, Auth64 identities, all actual request captures, datastore checks, contexts and absolute artifact SHA256 references. It references unchanged<build-proof>\targeted.trx,targeted-tests.log,strict-inventory.json,full-v1.0.log,full-beta.log, per-command exit metadata and non-incremental logs. Corrected four-cloud/profile results are<runtime-proof>\compiled-<profile>-<cloud>.json/.log.full-git-name-status.txtchecks the complete Git diff including deletes/renames, not a capped REST file list.Old target/failed/candidate evidence remains untouched. Baseline beta raw parity and existing NU1903 warnings are explicitly retained limits. No #3881 PostPath overlay, #3897 optional-query change, other-owner/global fix, new PR, merge/approval/bypass, binary/artifact commit or archival.
Other links