Repository navigation
Conversation
equal, not_equal, less_than, less_or_equal, greater_than and greater_or_equal only rejected empty lists, so an empty tuple was accepted and failed later at query time. Reject any empty non-string sequence at build time. str and bytes are excluded so equal('') stays valid.
Fixes weaviate#2265
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
Author
|
I have read the Contributor License Agreement and I agree to it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2265
Problem
Filter.by_property(...).equal(())and the five sibling builders (not_equal,less_than,less_or_equal,greater_than,greater_or_equal) only rejected emptylists. An empty tuple was accepted, and theWeaviateInvalidInputErroronly appeared later, when a query converted the filter to gRPC, so the traceback pointed at the query instead of the line that built the filter.Change
The six checks in
weaviate/collections/classes/filters.pynow reject any empty non-string sequence (isinstance(val, Sequence) and not isinstance(val, (str, bytes))), matching how_to_value_listtreats sequences.strandbytesare excluded soequal("")remains a valid filter.Tests
test_empty_tuple_raises(parametrized over the six methods): fails onmain(6 failed), passes with this change.test_empty_string_equal_is_valid: guards thatequal("")still works.pytest test/collection/test_filter.py: 83 passed.ruff format --checkis clean, and flake8 is clean on the changed files.AI assistance
I used Claude (Anthropic) to help locate the code and draft the change. I reviewed the diff, ran the tests, and can explain every line.