Repository navigation
Conversation
docs/mujoco-groups.md defines which geom and site groups hold visuals, collision geometry, render-and-collide geometry, task frames, and engineering frames, following MuJoCo Menagerie and MuJoCo's default visibility (groups 0-2 shown). scripts/check_mujoco_groups.py reports violations, and tests/integration/test_mujoco_groups.py runs it on every model in geodude_assets, ada_assets, and prl_assets.
This was referenced Oct 17, 2026
- Collision geometry must be hidden with group 3, not alpha 0, so a viewer's group-3 toggle can reveal it (as Menagerie robots do). - Mark the models that do not comply yet as strict expected failures, linked to personalrobotics/geodude_assets#28 and personalrobotics/prl_assets#18. A fixed model makes its expected failure pass, which fails the suite until its entry is removed.
siddhss5
marked this pull request as ready for review
October 17, 2026 18:00
Collaborator
Author
|
CI here is red for reasons that predate this PR: sscbirrt's tests are missing |
This was referenced Oct 17, 2026
personalrobotics/prl_assets#19, personalrobotics/geodude_assets#29, and personalrobotics/ada_assets#36 brought every model in line; all 26 pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds one convention for MuJoCo geom and site groups across the workspace's asset models, plus a checker and an integration test that enforce it. Today groups are assigned ad hoc: robots follow MuJoCo Menagerie, but the ABH hands, every
prl_assetsobject, and the sites of different robots disagree. So viewers show different kinds of content by default depending on which model loaded.Changes
docs/mujoco-groups.md, the canonical convention, follows Menagerie and MuJoCo's default visibility (groups 0–2 shown):{0, 1, 2, 4}, not all of them.scripts/check_mujoco_groups.py MODEL.xml ...reports each geom and site that breaks the rules and exits non-zero. It reads what the convention can determine mechanically:contype/conaffinity;tests/integration/test_mujoco_groups.pyruns the checker on every model ingeodude_assets,ada_assets, andprl_assets. Models that do not comply yet are strict expected failures linked to their issues. A fixed model therefore makes its entry fail until the entry is removed, so the list cannot go stale.Survey that motivated it
33 models were checked:
No code in mj_manipulator, geodude, ada_mj, ssrobot, or sscbirrt reads group numbers, so this changes only what viewers show.
Asset fixes (merged)
worktopsite 2 → 4.KNOWN_VIOLATIONSis now empty. It stays as the mechanism for any future non-compliant model.Testing
Against the asset repos' current
main, the integration test gives 26 passed (all models). Workspace Integration CI is red for reasons that predate this PR (#173). The new files passruff checkandruff format.