Repository navigation
Conversation
Previously `GLFW.onKeydown` unconditionally called `event.preventDefault()` on `Backspace` and `Tab` keydown events on `window`, preventing users from deleting text or tabbing between HTML `<input>` and `<textarea>` elements on the same page. Based on emscripten-core#22879 by @uysalibov and tests from emscripten-core#23285 by @kripken. Fixes: emscripten-core#22866
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies libglfw.js to prevent default backspace and tab behaviors only when the event target is not an INPUT or TEXTAREA element, and adds a browser test to verify this functionality. The review feedback points out two important issues: first, simulateKeyEvent is undefined in the test file, which will lead to a runtime error; second, the event handler should guard against a null event.target and also avoid preventing default behaviors on contenteditable elements.
Member
|
What do other backends do here? Assuming the same, it sounds fine to me, but it would still be a breaking change I think, so it needs a changelog entry? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
GLFW.onKeydownunconditionally calledevent.preventDefault()onBackspaceandTabkeydown events onwindow, preventing users from deleting text or tabbing between HTML<input>and<textarea>elements on the same page.Based on #22879 by @uysalibov and tests from #23285 by @kripken.
Fixes: #22866