Skip to content

Add backspace/tab tests for input elements [NFC] - #23285

Open
kripken wants to merge 1 commit into
emscripten-core:mainfrom
kripken:input.test
Open

kripken wants to merge 1 commit into
emscripten-core:mainfrom
kripken:input.test

Conversation

@kripken

@kripken kripken commented Jan 3, 2025 •

Copy link
Copy Markdown
Member

This adds tests for #22879

The glfw test passes as is, and when modified for that PR, passes with that PR.

However, the SDL test does not work, even before that PR, related to SDL
checking !SDL.unicode && !SDL.textInput before doing preventDefault,

https://github.com/emscripten-core/emscripten/pull/22879/files#diff-d34003e633a5e6cebdd7d5f53a624b636ea6e36f59c208107fb829f5cefcd107L699

The very first assert fails in SDL.

That suggests to me that perhaps the SDL side of that PR is not actually needed?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants