Repository navigation
[chore](build) Update doris-skills submodule with four new skills - #70582
Open
morningman wants to merge 1 commit into
Open
morningman wants to merge 1 commit into
morningman wants to merge 1 commit into
Conversation
### Background `doris-skills` is a submodule that points at apache/doris-skills, the Apache Doris repository of agent skills: instructions and scripts that coding agents such as Claude Code and Codex load for Doris tasks. Nothing builds from it; it is checked out on request (`git submodule update --init doris-skills`) and by the CI jobs that clone every submodule. This repository pins `c0aca2f` (apache/doris-skills#2, June), which has three skills. ### What problem does this PR solve? Issue Number: None Related PR: apache#64240 (the previous update of this pointer), apache#70422 (moves the same pointer to `0b36dcb` and adds the `AGENTS.md` guidance; conflicts with this PR on that line), apache/doris-skills#17 (the commit this PR pins) PR Type: Build/CI/Chore Problem Summary: Since `c0aca2f`, doris-skills has merged 13 PRs that add four skills, for debugging, local PR review, development, and PR descriptions, and a checkout of this repository still gets none of them. This PR moves the pointer to `c353d71`, the tip of doris-skills `main`, and changes nothing else. Builds, tests, and Doris users see no change. | | Skills in `doris-skills/skills/` | |---|---| | master (`c0aca2f`) | `doris-architecture-advisor`, `doris-best-practices`, `doris-profile-reader` | | this PR (`c353d71`) | `develop-with-evidence`, `doris-architecture-advisor`, `doris-best-practices`, `doris-debug`, `doris-pr-description`, `doris-profile-reader`, `doris-repo-review` | ### Details - **Affected:** Only the `doris-skills` pointer. The CI jobs that clone every submodule (`submodules: recursive` in `be-ut-mac.yml`, `build-extension.yml`, `build-thirdparty.yml`, `build-ui.yml`, and `checkstyle.yaml`, and `git submodule update --init --recursive --depth 1` in the performance pipeline's `compile.sh`) clone doris-skills at `c353d71` without reading it; `build.sh` and `run-be-ut.sh` update only the `contrib/` submodules they name. - **Developer and release impact:** Developers who check out the submodule get the seven skills at `c353d71`, about 2.3 MB; existing checkouts keep their commit until the next `git submodule update`. Release builds don't change, since no script in this repository reads `doris-skills`. - **License and third-party:** None. doris-skills is an Apache-2.0 repository of the ASF, and no file from it is added to this tree. - **Rollback:** Revert this PR; local submodule checkouts made meanwhile do no harm. ### Testing - `git ls-remote https://github.com/apache/doris-skills refs/heads/main` returns `c353d71bc50d6c0baf1831dec33cbfa0abc64ef2`, the commit this PR pins: the squash merge of apache/doris-skills#17, not a PR-only commit. `c0aca2f` is its ancestor. - A fresh clone of the URL in `.gitmodules`, checked out at `c353d71` as `git submodule update --init doris-skills` does, holds the seven skills in the table above. - `python3 skills/doris-pr-description/scripts/check_pr.py --self-test` at `c353d71` reports `Self-test: 11 examples in 10 files, 0 problems`. ### Notes for Reviewers - The pointer moves over 13 commits of apache/doris-skills (#3 to apache#17), +10,047 −45 in 114 files, each reviewed and merged there; the three skills pinned today don't change. In this repository's diff, only the pin itself needs checking. - apache#70422 changes the same line, to `0b36dcb` (apache/doris-skills#16). Whichever of the two merges second keeps `c353d71`. ### Release note None ### Check List (For Author) - Behavior changed: No - Does this need documentation: No - Pre-submission status: Ready ### AI Disclosure - Tool: Claude Code (Claude Opus 5.5) - Generated: the submodule update and this description - Human review: not stated - Prompts: After apache/doris-skills#17 merged, the author asked for a separate PR that only updates the doris-skills submodule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
skip buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
doris-skillsis a submodule that points at apache/doris-skills, the Apache Doris repository of agent skills: instructions and scripts that coding agents such as Claude Code and Codex load for Doris tasks. Nothing builds from it; it is checked out on request (git submodule update --init doris-skills) and by the CI jobs that clone every submodule. This repository pinsc0aca2f(apache/doris-skills#2, June), which has three skills.What problem does this PR solve?
Issue Number: None
Related PR: #64240 (the previous update of this pointer), #70422 (moves the same pointer to
0b36dcband adds theAGENTS.mdguidance; conflicts with this PR on that line), apache/doris-skills#17 (the commit this PR pins)PR Type: Build/CI/Chore
Problem Summary:
Since
c0aca2f, doris-skills has merged 13 PRs that add four skills, for debugging, local PR review, development, and PR descriptions, and a checkout of this repository still gets none of them. This PR moves the pointer toc353d71, the tip of doris-skillsmain, and changes nothing else. Builds, tests, and Doris users see no change.doris-skills/skills/c0aca2f)doris-architecture-advisor,doris-best-practices,doris-profile-readerc353d71)develop-with-evidence,doris-architecture-advisor,doris-best-practices,doris-debug,doris-pr-description,doris-profile-reader,doris-repo-reviewDetails
doris-skillspointer. The CI jobs that clone every submodule (submodules: recursiveinbe-ut-mac.yml,build-extension.yml,build-thirdparty.yml,build-ui.yml, andcheckstyle.yaml, andgit submodule update --init --recursive --depth 1in the performance pipeline'scompile.sh) clone doris-skills atc353d71without reading it;build.shandrun-be-ut.shupdate only thecontrib/submodules they name.c353d71, about 2.3 MB; existing checkouts keep their commit until the nextgit submodule update. Release builds don't change, since no script in this repository readsdoris-skills.Testing
git ls-remote https://github.com/apache/doris-skills refs/heads/mainreturnsc353d71bc50d6c0baf1831dec33cbfa0abc64ef2, the commit this PR pins: the squash merge of feat(doris-pr-description): show the problem with a concrete example doris-skills#17, not a PR-only commit.c0aca2fis its ancestor..gitmodules, checked out atc353d71asgit submodule update --init doris-skillsdoes, holds the seven skills in the table above.python3 skills/doris-pr-description/scripts/check_pr.py --self-testatc353d71reportsSelf-test: 11 examples in 10 files, 0 problems.Notes for Reviewers
0b36dcb(feat: add develop-with-evidence and doris-pr-description skills doris-skills#16). Whichever of the two merges second keepsc353d71.Release note
None
Check List (For Author)
AI Disclosure