Repository navigation
[chore](build) Update doris-skills and have agents use its development and PR skills - #70422
Open
morningman wants to merge 1 commit into
Open
morningman wants to merge 1 commit into
morningman wants to merge 1 commit into
Conversation
…t and PR skills ### Background `doris-skills` is a submodule that points at apache/doris-skills, the Apache Doris repository of agent skills; nothing builds from it, and it is not checked out by default. doris-skills apache#16 added two contributor skills: `develop-with-evidence` develops and verifies a change and leaves a handoff file with a PR description draft under `.git/pr-handoff/`, and `doris-pr-description` writes the PR title and description by the Doris PR standard and opens the PR. Coding agents such as Claude Code and Codex read `AGENTS.md` when a session starts. ### What problem does this PR solve? Issue Number: None Related PR: apache#70175 (named both skills in `AGENTS.md`), apache/doris-skills#16 (added both skills) PR Type: Build/CI/Chore Problem Summary: This repository pins doris-skills #2, which has neither skill, and `AGENTS.md` mentions them only in passing without saying where they are, so a developer has to point the agent at them by hand. This PR moves the pointer to the tip of doris-skills `main` and adds a section to `AGENTS.md` that makes the two skills the default for development and PR tasks, including checking out the submodule when it is missing. `CONTRIBUTING.md`, `CONTRIBUTING_CN.md`, and the PR template give people the same recommendation. Builds, tests, and Doris users see no change. ### Details - **Affected:** Documentation and the `doris-skills` pointer. CI jobs with `submodules: recursive` now clone doris-skills at `0b36dcb` without reading it; `build.sh` and `run-be-ut.sh` don't initialize it. - **Developer and release impact:** Agents that read `AGENTS.md` use the two skills for development and PR tasks unless the user asks otherwise, check out the submodule (about 2.4 MB) when `doris-skills/` is empty, and ask the developer to do it when they can't. PR authors see one more guidance comment in the template. Releases don't change. - **License and third-party:** None. doris-skills is an Apache-2.0 repository of the ASF, and no file from it is added to this tree. - **Rollback:** Revert this PR; local submodule checkouts made meanwhile do no harm. ### Testing - On an isolated clone of this branch, `git submodule update --init doris-skills` checks out `0b36dcb` and both `SKILL.md` paths that `AGENTS.md` names exist. With the pin set back to `c0aca2f` there, `--remote` moves the checkout to the tip of `main` and leaves a moved pointer in `git diff`, hence the note to keep it out of commits. - Agents in throwaway sparse clones of this branch, given no other hint, were asked to fix a problem in `build-support/check-format.sh` and submit a PR (prepare only, read-only tools, one local run each). Claude Code 2.1.322 found `doris-skills/` empty, checked it out itself, read `develop-with-evidence` and the stage 1 files it lists (`doris-pr-description`'s included), and planned to reproduce first and open the PR with `doris-pr-description`. Codex 0.163.0 read both `SKILL.md` files and the same files when the submodule was checked out; in its read-only sandbox on a fresh clone it reported that the submodule must be checked out and both skills read before implementing. - `git ls-remote` shows `0b36dcb` as the tip of doris-skills `main`, with `c0aca2f` as its ancestor. - All runs predate the rebase onto current master, which touched none of these files. ### Notes for Reviewers - The pointer carries doris-skills #3 to apache#16: 12 commits, 114 files, about 10,000 added lines, all in that repository (the `doris-debug` and `doris-repo-review` skills, README updates, and the two skills in apache#16). Only apache/doris-skills#16 matters to the new text. - A submodule cannot follow `main` on its own: `branch = main` in `.gitmodules` only lets `git submodule update --remote` take the newest commit locally, and the pin still moves by a PR like this one. - Agents read the `SKILL.md` files by path, since no tool discovers skills under `doris-skills/skills/`; symlinks under `.claude/skills/` would serve one tool and dangle until the submodule is checked out. ### Release note None ### Check List (For Author) - Behavior changed: No - Does this need documentation: No - Pre-submission status: Ready ### AI Disclosure - Tool: Claude Code (Claude Opus 5.5) - Generated: the documentation changes, the submodule bump, and this description - Human review: not stated - Prompts: Update the doris-skills submodule to its latest commit and say whether it can follow doris-skills automatically; add to the development guides a recommendation to prefer develop-with-evidence for development and doris-pr-description for PR submission. Then: the goal is that a developer starts any coding agent in the Doris checkout, asks it to fix or develop something and submit a PR, and the agent applies both skills on its own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
doris-skillsis a submodule that points at apache/doris-skills, the Apache Doris repository of agent skills; nothing builds from it, and it is not checked out by default. doris-skills #16 added two contributor skills:develop-with-evidencedevelops and verifies a change and leaves a handoff file with a PR description draft under.git/pr-handoff/, anddoris-pr-descriptionwrites the PR title and description by the Doris PR standard and opens the PR. Coding agents such as Claude Code and Codex readAGENTS.mdwhen a session starts.What problem does this PR solve?
Issue Number: None
Related PR: #70175 (named both skills in
AGENTS.md), apache/doris-skills#16 (added both skills)PR Type: Build/CI/Chore
Problem Summary:
This repository pins doris-skills #2, which has neither skill, and
AGENTS.mdmentions them only in passing without saying where they are, so a developer has to point the agent at them by hand. This PR moves the pointer to the tip of doris-skillsmainand adds a section toAGENTS.mdthat makes the two skills the default for development and PR tasks, including checking out the submodule when it is missing.CONTRIBUTING.md,CONTRIBUTING_CN.md, and the PR template give people the same recommendation. Builds, tests, and Doris users see no change.Details
doris-skillspointer. CI jobs withsubmodules: recursivenow clone doris-skills at0b36dcbwithout reading it;build.shandrun-be-ut.shdon't initialize it.AGENTS.mduse the two skills for development and PR tasks unless the user asks otherwise, check out the submodule (about 2.4 MB) whendoris-skills/is empty, and ask the developer to do it when they can't. PR authors see one more guidance comment in the template. Releases don't change.Testing
git submodule update --init doris-skillschecks out0b36dcband bothSKILL.mdpaths thatAGENTS.mdnames exist. With the pin set back toc0aca2fthere,--remotemoves the checkout to the tip ofmainand leaves a moved pointer ingit diff, hence the note to keep it out of commits.build-support/check-format.shand submit a PR (prepare only, read-only tools, one local run each). Claude Code 2.1.322 founddoris-skills/empty, checked it out itself, readdevelop-with-evidenceand the stage 1 files it lists (doris-pr-description's included), and planned to reproduce first and open the PR withdoris-pr-description. Codex 0.163.0 read bothSKILL.mdfiles and the same files when the submodule was checked out; in its read-only sandbox on a fresh clone it reported that the submodule must be checked out and both skills read before implementing.git ls-remoteshows0b36dcbas the tip of doris-skillsmain, withc0aca2fas its ancestor.Notes for Reviewers
doris-debuganddoris-repo-reviewskills, README updates, and the two skills in llvm 3.3有bug #16). Only feat: add develop-with-evidence and doris-pr-description skills doris-skills#16 matters to the new text.mainon its own:branch = mainin.gitmodulesonly letsgit submodule update --remotetake the newest commit locally, and the pin still moves by a PR like this one.SKILL.mdfiles by path, since no tool discovers skills underdoris-skills/skills/; symlinks under.claude/skills/would serve one tool and dangle until the submodule is checked out.Release note
None
Check List (For Author)
AI Disclosure