Repository navigation
feat: narrow partial reads of uncompressed chunks within a single row - #4611
Open
bendichter wants to merge 3 commits into
Open
bendichter wants to merge 3 commits into
bendichter wants to merge 3 commits into
Conversation
When a selection touches one index along the first axis, apply the same row window along the next axis, and so on. arr[t, y0:y1, x0:x1] then fetches rows y0 to y1 of frame t instead of the whole frame, and a single item is fetched for a point. The fetched block keeps the narrowed axes with length 1, so the shifted selection applies to it unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4611 +/- ##
=======================================
Coverage 94.90% 94.90%
=======================================
Files 96 96
Lines 14048 14063 +15
=======================================
+ Hits 13332 13347 +15
Misses 716 716
🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a selection touches one index along the first axis, apply the same row window along the next axis, and so on.
arr[t, y0:y1, x0:x1]then fetches rows y0 to y1 of frame t instead of the whole frame, and a single item is fetched for a point.The fetched block keeps the narrowed axes with length 1, so the shifted selection applies to it unchanged.
Summary
We have use-cases such as reading a small patch of a single frame of an image series, where it's possible and useful to extend the partial decode logic to inner dimensions. This identifies that specific indexing pattern and extends the current partial decode logic to efficiently read bytes in this case.
Author attestation
TODO
docs/user-guide/*.mdchanges/