Repository navigation
Conversation
http_request copied the user and password of the current URL into any redirect target without credentials of its own, so a redirect to another host received them, and a redirect to ftp:// sent them as USER/PASS. Only copy them if the host matches, like FreeBSD's libfetch does.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http_request copies the user and password of the current url into the redirect target whenever the Location url has no credentials of its own, without looking at the host. with a repository like https://user:pass@repo.example.org/, a redirect to any other host makes libfetch send Authorization: Basic with those credentials there, and a redirect to ftp://other/ hands them to that ftp server as USER/PASS in cleartext. only copy them when the host matches, which is the guard FreeBSD's libfetch has. same-host and absolute-path redirects keep their credentials. checked with two local servers (127.0.0.1 redirecting to 127.0.0.2): before the change the second one receives the Basic header (or USER/PASS for ftp://), after it gets none, and make check passes with gcc and clang.