Repository navigation
cp: drop unnecessary fn - #16469
Open
oech3 wants to merge 1 commit into
Open
cp: drop unnecessary fn#16469oech3 wants to merge 1 commit into
oech3 wants to merge 1 commit into
Conversation
oech3
force-pushed
the
cp-symlink
branch
2 times, most recently
from
November 14, 2026 18:25
3c7eb66 to
35191d7
Compare
Contributor
|
thanks for tackling this! |
sylvestre
reviewed
Nov 14, 2026
| CpError::IoErrContext( | ||
| e, | ||
| translate!("cp-error-cannot-create-symlink", | ||
| #[cfg(not(windows))] |
Contributor
There was a problem hiding this comment.
rustix is only a dependency on linux/android/wasi, this won't build on macos or the BSDs.
please keep std::os::unix::fs::symlink for unix and use rustix only under target_os = "wasi"
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.