Skip to content

taco: ensure assembly is included in timing for all benchmarks #8

Open

Description

@rohany

Should the call to assemble() be included in benchmark timing @stephenchouca ?

Activity

  1. stephenchouca commented on Mar 9, 2021

    @stephenchouca
    Collaborator

    For comparisons against other Python libraries, I think it'd make sense to include the assembly time when benchmarking so that the comparison is more apples-to-apples, particularly since assembly can take a significant amount of time when the output is sparse. (Note though that assembly time can be significantly reduced if it is done with the compute step using a fused kernel. With the C++ API at least, you should be able to tell TACO to generate code that simultaneously assembles and computes the output by invoking TensorBase::setAssembleWhileCompute(true) before invoking compile.)

  2. changed the title [-]benchmark timing inclusion[/-] [+]taco: ensure assembly is included in timing for all benchmarks[/+] on Mar 9, 2021
  3. rohany commented on Mar 9, 2021

    @rohany
    CollaboratorAuthor

    If setAssembleWhileCompute(true) is used, then does assemble even need to be called before compute?

  4. stephenchouca commented on Mar 9, 2021

    @stephenchouca
    Collaborator

    If setAssembleWhileCompute(true) is used, then does assemble even need to be called before compute?

    You shouldn't have to call assemble in that case.

  5. added
    final-checkShould be checked before running final benchmarks
    on Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    final-checkShould be checked before running final benchmarks

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions