Repository navigation
test(unit): Load Tailwind styles in component tests - #448
Draft
Bohreromir wants to merge 1 commit into
Draft
Bohreromir wants to merge 1 commit into
Bohreromir wants to merge 1 commit into
Conversation
Component tests rendered without app.css, so utility classes like hidden, invisible and md:hidden had no effect and visibility assertions ran against a DOM no user sees. One test (PreviewModal Data tab) passed only because of that. Import app.css in the client setup, default the browser viewport to 1280x800, and fix the tests that relied on unstyled markup.
Coverage Report
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Component tests rendered without app.css, so utility classes like hidden, invisible and md:hidden had no effect
Import app.css in the client setup, default the browser viewport to 1280x800, and fix the tests that relied on unstyled markup.
closes #447
Docs
Release note
Checklist
Author
Reviewer
Acceptance