Repository navigation
Add the #io_close scheduler hook - #483
Open
tavianator wants to merge 1 commit into
Open
tavianator wants to merge 1 commit into
tavianator wants to merge 1 commit into
Conversation
dirceu
reviewed
Nov 12, 2026
| # @parameter descriptor [Integer] The fd to close. | ||
| # @returns [Boolean] Whether the selector closed the descriptor. | ||
| def io_close(descriptor) | ||
| !!@selector&.io_close(descriptor) |
There was a problem hiding this comment.
[P2] Preserve descriptor ownership if close is interrupted
URing's io_close can yield while draining a full submission queue, before it has queued this descriptor's close. If the task is cancelled there, Ruby has already marked the IO closed, and the exception skips its fallback close, leaking the OS descriptor. A selector shim reproduces the ownership loss: closed? is true while the fd remains open. Can we ensure the close is accepted before cancellation can unwind this hook, and add a regression test for that interruption?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for asynchronous close operations.
Link: #436
Types of Changes
Contribution