Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_operating_systemandparse_browseracceptpatch_minorbut omit it when callingparse_version. For example, the existing BlackBerry Torch user agent contains OS version6.0.0.448, and ua-parser supplies all four components, butUserAgent.osandget_os()return only6.0.0.Pass the fourth component through both helpers. Regression tests cover four-part versions, a zero final component, absent final components, and the existing BlackBerry input. Update the three existing BlackBerry display expectations to include the previously lost OS build number.
Validation:
python -m unittest discoverpasses all 59 tests on CPython 3.11 with the project's ua-parser 0.10.0 pin (PyYAML 6.0.3). The baseline passes 55 tests; the updated tests produce four failures before the fix.git diff --checkpasses. Other Python versions were not run locally.This fix was found, implemented, and tested with Codex during a source audit.