Skip to content

Create a vcpkg issue to package mathplot #30

Open

Description

@sebsjames

This depends on sebsjames/maths being packaged: sebsjames/maths#8

Activity

  1. sebsjames commented on Jun 30, 2025

    @sebsjames
    OwnerAuthor

    @miyanyan are you able to help with this?

  2. miyanyan commented on Jun 30, 2025

    @miyanyan
    Contributor

    I can try it, then remove the maths submodule and add to vcpkg.json?

  3. miyanyan commented on Jun 30, 2025

    @miyanyan
    Contributor

    btw, the name maths is too common and maybe need aliased.

  4. sebsjames commented on Jun 30, 2025

    @sebsjames
    OwnerAuthor

    Hi Miyan, I'll have a think about that over the next week (I'm on holiday) and come back to you.

  5. sebsjames commented on Jul 7, 2025

    @sebsjames
    OwnerAuthor

    So, I took a look at nlohmann json, whose repository is just called 'json'. The vcpkg for this repo is called 'nlohmann-json'; presumably this is an alias? sebsjames-maths seems good to me as an alias.

  6. sebsjames commented on Jul 9, 2025

    @sebsjames
    OwnerAuthor

    Great, sebsjames/maths is now packaged in vcpkg!

  7. miyanyan commented on Jul 10, 2025

    @miyanyan
    Contributor

    May I remove the maths submodule and add to vcpkg.json? the submodule is not friendly to me, it's too slow to download the submodule 😭

  8. sebsjames commented on Jul 10, 2025

    @sebsjames
    OwnerAuthor

    Hi Miyan, I am hesitant to remove the submodule. I'm interested in what way it is slow? To download?

    I think we could keep the submodule, but make it optional. That is, you could use a vcpkged maths or the submodule.

  9. miyanyan commented on Jul 10, 2025

    @miyanyan
    Contributor

    Hi Miyan, I am hesitant to remove the submodule. I'm interested in what way it is slow? To download?

    I got the reason, I didn't set the ssh key of this pc for github...

  10. sebsjames commented on Jul 10, 2025

    @sebsjames
    OwnerAuthor

    Glad you can now clone recursively.

    I do still think the submodule should be optional - so that when a user installs with vcpkg they get the maths vcpkg and the mathplot vcpkg (without a submodule for maths), BUT when they're developing with a clone from github, they can just clone recursively and that gives them all the code they need.

  11. sebsjames commented on Jul 10, 2025

    @sebsjames
    OwnerAuthor

    This may be achieved by adding lines something like this in CMakeLists.txt:

    set(SEBSJAMES_MATHS_INCLUDE  "${PROJECT_SOURCE_DIR}/maths" CACHE STRING
          "The path to sebsjames/maths. Defaults to the git-submoduled version within mathplot but can be any other location that contains the sm directory"
          FORCE)
  12. rremilian commented on Sep 26, 2025

    @rremilian
    Contributor

    Hi @sebsjames, do you still need help with this ?

  13. sebsjames commented on Sep 26, 2025

    @sebsjames
    OwnerAuthor

    Hi @rremilian yes, this has stalled a little. I'm not quite sure how to deal with the fact that the maths code is now in a submodule.

  14. rremilian commented on Sep 26, 2025

    @rremilian
    Contributor

    I will have a look tomorrow. However, considering that maths is already in vcpkg, couldn't we use it directly from there and add it as a dependency for mathplot ?

  15. sebsjames commented on Sep 26, 2025

    @sebsjames
    OwnerAuthor

    Yes, I should think so

  16. rremilian commented on Sep 26, 2025

    @rremilian
    Contributor

    I will try this tomorrow. We will also need a release of mathplot before we add it in vcpkg.
    I will work with a fork of mathplot for the time being.

  17. sebsjames commented on Sep 26, 2025

    @sebsjames
    OwnerAuthor

    Great. Yes, it's about time for a release of mathplot. I may be uncommunicative until Tuesday, I'm going on a cycle tour.

  18. rremilian commented on Sep 26, 2025

    @rremilian
    Contributor

    P.S. Please don't do a release just yet. I think we will have to make some minor changes to the CMakeLists.

  19. rremilian commented on Sep 30, 2025

    @rremilian
    Contributor

    Hi @sebsjames,
    I've prepared the port: microsoft/vcpkg@080d1c6. When you are ready, you can create the release and I will change the port to point to this repository and also create a PR in microsoft/vcpkg.

  20. sebsjames commented on Oct 2, 2025

    @sebsjames
    OwnerAuthor

    That's great Emilian, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedExtra attention is needed

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions