You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So, I took a look at nlohmann json, whose repository is just called 'json'. The vcpkg for this repo is called 'nlohmann-json'; presumably this is an alias? sebsjames-maths seems good to me as an alias.
I do still think the submodule should be optional - so that when a user installs with vcpkg they get the maths vcpkg and the mathplot vcpkg (without a submodule for maths), BUT when they're developing with a clone from github, they can just clone recursively and that gives them all the code they need.
This may be achieved by adding lines something like this in CMakeLists.txt:
set(SEBSJAMES_MATHS_INCLUDE "${PROJECT_SOURCE_DIR}/maths"CACHESTRING"The path to sebsjames/maths. Defaults to the git-submoduled version within mathplot but can be any other location that contains the sm directory"FORCE)
I will have a look tomorrow. However, considering that maths is already in vcpkg, couldn't we use it directly from there and add it as a dependency for mathplot ?
Hi @sebsjames,
I've prepared the port: microsoft/vcpkg@080d1c6. When you are ready, you can create the release and I will change the port to point to this repository and also create a PR in microsoft/vcpkg.
Activity
sebsjames commentedon Jun 30, 2025
@miyanyan are you able to help with this?
miyanyan commentedon Jun 30, 2025
I can try it, then remove the maths submodule and add to vcpkg.json?
miyanyan commentedon Jun 30, 2025
btw, the name
mathsis too common and maybe need aliased.sebsjames commentedon Jun 30, 2025
Hi Miyan, I'll have a think about that over the next week (I'm on holiday) and come back to you.
sebsjames commentedon Jul 7, 2025
So, I took a look at nlohmann json, whose repository is just called 'json'. The vcpkg for this repo is called 'nlohmann-json'; presumably this is an alias? sebsjames-maths seems good to me as an alias.
sebsjames commentedon Jul 9, 2025
Great, sebsjames/maths is now packaged in vcpkg!
miyanyan commentedon Jul 10, 2025
May I remove the maths submodule and add to vcpkg.json? the submodule is not friendly to me, it's too slow to download the submodule 😭
sebsjames commentedon Jul 10, 2025
Hi Miyan, I am hesitant to remove the submodule. I'm interested in what way it is slow? To download?
I think we could keep the submodule, but make it optional. That is, you could use a vcpkged maths or the submodule.
miyanyan commentedon Jul 10, 2025
I got the reason, I didn't set the ssh key of this pc for github...
sebsjames commentedon Jul 10, 2025
Glad you can now clone recursively.
I do still think the submodule should be optional - so that when a user installs with vcpkg they get the maths vcpkg and the mathplot vcpkg (without a submodule for maths), BUT when they're developing with a clone from github, they can just clone recursively and that gives them all the code they need.
sebsjames commentedon Jul 10, 2025
This may be achieved by adding lines something like this in CMakeLists.txt:
rremilian commentedon Sep 26, 2025
Hi @sebsjames, do you still need help with this ?
sebsjames commentedon Sep 26, 2025
Hi @rremilian yes, this has stalled a little. I'm not quite sure how to deal with the fact that the maths code is now in a submodule.
rremilian commentedon Sep 26, 2025
I will have a look tomorrow. However, considering that maths is already in vcpkg, couldn't we use it directly from there and add it as a dependency for mathplot ?
sebsjames commentedon Sep 26, 2025
Yes, I should think so
rremilian commentedon Sep 26, 2025
I will try this tomorrow. We will also need a release of mathplot before we add it in vcpkg.
I will work with a fork of mathplot for the time being.
sebsjames commentedon Sep 26, 2025
Great. Yes, it's about time for a release of mathplot. I may be uncommunicative until Tuesday, I'm going on a cycle tour.
rremilian commentedon Sep 26, 2025
P.S. Please don't do a release just yet. I think we will have to make some minor changes to the CMakeLists.
rremilian commentedon Sep 30, 2025
Hi @sebsjames,
I've prepared the port: microsoft/vcpkg@080d1c6. When you are ready, you can create the release and I will change the port to point to this repository and also create a PR in microsoft/vcpkg.
sebsjames commentedon Oct 2, 2025
That's great Emilian, thank you!