Skip to content

Add more methods to SocketForwarder. - #708

Merged
ioquatix merged 2 commits into
masterfrom
expose-more-io-methods
Jan 13, 2024
Merged

ioquatix merged 2 commits into
masterfrom
expose-more-io-methods

Conversation

@ioquatix

@ioquatix ioquatix commented Dec 27, 2023 •

Copy link
Copy Markdown
Member

Generic code that assumes the Socket interface will fail if it tries to use wait or wait_readable or close_on_exec family of methods. Can we add these?

@ioquatix ioquatix self-assigned this Dec 27, 2023
@ioquatix
ioquatix requested a review from rhenium December 27, 2023 23:30
@junaruga

Copy link
Copy Markdown
Member

Maybe it could be better to create the branch on your forked repository. By the way, the failures in the windows-latest 3.3 case in CI were fixed. You can rebase the branch on the latest master branch.

@ioquatix
ioquatix force-pushed the expose-more-io-methods branch from 42e8240 to 6663ad7 Compare January 12, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants