Skip to content

Remove RC4 cipher - #50

Merged
rhenium merged 1 commit into
ruby:masterfrom
jsyeo:jsyeo-remove-rc4
Jul 4, 2016
Merged

rhenium merged 1 commit into
ruby:masterfrom
jsyeo:jsyeo-remove-rc4

Conversation

@jsyeo

@jsyeo jsyeo commented Apr 13, 2016

Copy link
Copy Markdown
Contributor

RC4 has insecure biases and both clients and servers should not be using it.

@rhenium

rhenium commented Jun 1, 2016

Copy link
Copy Markdown
Member

It looks like Firefox 44 and Chrome 48 (both released in 2016-01) finally disabled RC4.

https://bugs.chromium.org/p/chromium/issues/detail?id=375342
https://blog.mozilla.org/security/2015/09/11/deprecating-the-rc4-cipher/

And more, OpenSSL 1.1.0 (to be released soon) will remove RC4 cipher suites from DEFAULT.

openssl/openssl@c84f7f4

Will merge unless there are objections.

@rhenium

rhenium commented Jul 3, 2016

Copy link
Copy Markdown
Member

@jsyeo Could you clarify the commit message so that people who don't read this page can understand what it does, and the background?

This removes RC4 cipher suites from SSLContext::DEFAULT_PARAMS, but it doesn't prohibit specifying explicitly, or using RC4 with OpenSSL::Cipher.

then, I'll merge. Thank you!

This commit removes insecure RC4 ciper suites [1] from being used by
default. If needed, users can still specify the usage of it by
specifying it explicitly.

[1]: https://tools.ietf.org/html/rfc7465
@jsyeo
jsyeo force-pushed the jsyeo-remove-rc4 branch from 38c49bf to cb3b838 Compare July 4, 2016 09:41
@jsyeo

jsyeo commented Jul 4, 2016

Copy link
Copy Markdown
Contributor Author

@rhenium amended. 😉

@rhenium
rhenium merged commit 23a6b70 into ruby:master Jul 4, 2016
@rhenium

rhenium commented Jul 4, 2016

Copy link
Copy Markdown
Member

Merged, thanks!

@jsyeo
jsyeo deleted the jsyeo-remove-rc4 branch July 13, 2016 07:34
dncrht added a commit to simplybusiness/devise_ldap_authenticatable that referenced this pull request Oct 23, 2017
Our LDAP server runs on Win2003 and only supports RC4 cipher.
We only care whether we use SSL or not. On SSL enabled, encryption
is set to simple_tls and the supported ciphers are set.

Ruby's 2.4 openssl gem has removed RC4 from its default params, however
doesn't disallow its usage. See: ruby/openssl#50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants