Repository navigation
backend: default cbor topicName to all topics - #2711
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
The cbor.topicName config documents a default of /.*/, but Cbor had an empty SetDefaults and Serde.SetDefaults never called it. With CBOR enabled and no topicName set, the topic matcher was empty, so picking CBOR as the key or value deserializer in the message viewer failed with "cbor encoding not configured for topic" on every topic. Set the documented default and call it from Serde.SetDefaults, as the MessagePack config already does. A configured topicName still replaces the default. Fixes redpanda-data#2487
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
serde.cbor.topicNameis documented to default to/.*/, butCbor.SetDefaultswas empty andSerde.SetDefaultsnever called it. Withserde.cbor.enabled: trueand notopicName, the topic matcher stays empty. Picking CBOR as the key or value deserializer in the message viewer then fails on every topic.This change sets the documented default and calls it from
Serde.SetDefaults, the same way the MessagePack config does. A configuredtopicName(literal or/regex/) still replaces the default, and a test covers both cases.Fixes #2487
Examples
Config:
Before: picking CBOR as the value deserializer shows
cbor encoding not configured for topic: <topic>.After: records on any topic decode as CBOR.
go test -run TestSerde_ ./pkg/config/fails onmaster(expected cbor topicName to default to a regex) and passes with this change.