[samsonasik]

without the patch, it produce error:

There was 1 error:

1) Rector\Tests\DowngradePhp74\Rector\Array_\DowngradeArraySpreadRector\DowngradeArraySpreadRectorTest::test@/Users/samsonasik/www/rector-downgrade-php/rules-tests/DowngradePhp74/Rector/Array_/DowngradeArraySpreadRector/Fixture/on_class_constant_global_constants.php.inc with data ('/Users/samsonasik/www/rector-...hp.inc')
TypeError: PhpParser\Internal\TokenStream::getIndentationBefore(): Return value must be of type int, null returned

Ref https://getrector.com/demo/98524e80-092d-461c-ab17-9fe950a65a5b

on code:

namespace Rector\Tests\DowngradePhp74\Rector\Array_\DowngradeArraySpreadRector\Fixture;

use Rector\Tests\DowngradePhp74\Rector\Array_\DowngradeArraySpreadRector\Source\ClassWithGlobalConstants;

final class OnClassConstantGlobalConstants
{
    private const ITEMS = ['x', ...ClassWithGlobalConstants::ITEMS];
}

Add test for it. This also reduce AstResolver usage by move to PHPStan ReflectionProvider.

[samsonasik]

@TomasVotruba ready 👍

[TomasVotruba]

Thank you 👍