Repository navigation
Conversation
#59994 sends the visual deep link once on iOS, which stops a second, unaccepted "Open in RNTester?" dialog from leaving RNTester on the previous example. But a single link can also be dropped on iOS when it arrives before RNTester is ready, leaving the flow on the Components screen until Maestro retries it. Both platforms now send the link twice again, and iOS accepts the dialog after each one. Changelog: [Internal]
meta-cla
Bot
added
the
CLA Signed
robhogan
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#59994 sends the visual deep link once on iOS, which fixed
border- it had failed its first attempt in every iOS capture job. However, a single link can also be dropped on iOS if it arrives before RNTester is ready, so the flow sits on the Components screen until Maestro retries it. Since #59994 landed, 9 of 13 iOS capture jobs had at least one flow fail this way (13 failures across 7 flows, twice failing two attempts in a row), against none in the 14 jobs before it.This goes back to sending the link twice on both platforms, but accepts the "Open in RNTester?" dialog after each one on iOS, so neither a dropped link nor a leftover dialog can strand the flow.
Changelog: [Internal]
Test plan:
This PR's own Test All run exercises the flows on CI - every iOS flow should open its example on the first attempt.