Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D131753903. |
cortinico
approved these changes
Nov 13, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Visual regressionNo visual differences at android: no capture |
meta-codesync
Bot
changed the title
javache
added a commit
to javache/react-native
that referenced
this pull request
Nov 13, 2026
…act#59998) Summary: Keep the existing `getVerticalBarEdge` implementation and allow its Clang-Tidy synchronous-main-queue diagnostic at this call site only. No runtime behavior or public API changes. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D131753903
javache
force-pushed
the
export-D131753903
branch
from
November 13, 2026 19:10
be47f9b to
5a52e8e
Compare
…act#59998) Summary: Keep the existing `getVerticalBarEdge` implementation and allow its Clang-Tidy synchronous-main-queue diagnostic at this call site only. No runtime behavior or public API changes. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D131753903
javache
force-pushed
the
export-D131753903
branch
from
November 13, 2026 19:20
5a52e8e to
39fc187
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Keep the existing
getVerticalBarEdgeimplementation and allow its Clang-Tidy synchronous-main-queue diagnostic at this call site only. No runtime behavior or public API changes.Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D131753903