Repository navigation
Conversation
Mirror of internal draft D131766156. Changelog: [Internal]
|
Warning Missing Test Plan Please add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow the three Gemfiles to be evaluated before the declared
loggergem is installed, while retaining logger preloading for ActiveSupport/CocoaPods once it is available. Catch only aLoadErrorwhose path is exactlylogger; nested dependency failures and initialization exceptions continue to fail.No gem constraints, lockfiles, test expectations, or CI policies change.
Diagnosis
The latest observed
mainSHA,3f54cc20ed702f861fa4641e5ad0d1a95ab771c1, has a deterministic Dependabot failure in addressable update #1701385983:The same signature occurs on its parent
a1f6da49ce22736152c98701534bf86690374a4c(job) and on a November 11 run (job). This is not a regression in the latest Flow tooling upgrade, and repeated identical failures across SHAs and updater images do not support treating it as flakiness.The eager require was introduced by
96d3f911246f81a00644379da364a373fae1f0ca. Its parent evaluates successfully without logger under the same focused probe; the introducing version and current unpatched files fail. That identifies the source-level boundary, not the exact hosted Dependabot environment change that exposed it. No full hosted-image bisect was performed.Removing the preload outright would reintroduce the older ActiveSupport logger failure. The guard instead permits dependency resolution before installation, preserving the preload in an installed environment and the explicit
gem 'logger'declaration.Test evidence
All change implementation and validation originated in the internal source-of-truth checkout, before this branch was created.
cannot load such file -- loggerwhen its library is absent from the load path.LoadErrorpropagates; runtime initialization error propagates.Risk and limitations
This is a three-file bootstrap fix, not a dependency upgrade. Only the absence of logger during Gemfile evaluation is deferred; other loading or initialization errors remain visible. The hosted Dependabot image/full security-update transaction was not run locally. A hosted updater rerun after the fix reaches
mainis the final end-to-end check; do not assume the addressable update has been applied by this PR.Other CI on the observed SHA was progressing normally. Missing Meta Import, CLA, and Internal-Only contexts on that exact SHA remain a separate reporting caveat, not something this change suppresses.
Changelog
[INTERNAL] [FIXED] - Allow Gemfile dependency resolution before logger is installed.
Internal provenance
Created first: D131766156, draft version 472961500. This PR mirrors exactly its three Gemfile changes. Nothing has been merged or landed.