Skip to content

Sync Flow options in the GitHub Flow config (#59988) - #59988

Open
javache wants to merge 1 commit into
react:mainfrom
javache:export-D131543925
Open

javache wants to merge 1 commit into
react:mainfrom
javache:export-D131543925

Conversation

@javache

@javache javache commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

Enable the stricter Flow options that React Native code is already held to downstream, so pull requests that violate them fail GitHub CI instead of after merge:

  • experimental.require_dictionary_key_label, experimental.require_function_type_param_name, experimental.ban_explicit_exact_object_types, experimental.react_managed_attributes, experimental.jsx_intrinsic_elements, experimental.strict_es6_import_export and experimental.export_star_excludes_default.
  • The matching unsuppressable_error_codes, so these errors cannot be silenced with suppression comments.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D131543925

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 13, 2026
@meta-codesync

meta-codesync Bot commented Nov 13, 2026

Copy link
Copy Markdown

@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D131543925.

@meta-codesync meta-codesync Bot changed the title Sync Flow options in the GitHub Flow config Sync Flow options in the GitHub Flow config (#59988) Nov 13, 2026
javache added a commit to javache/react-native that referenced this pull request Nov 13, 2026
Summary:

Enable the stricter Flow options that React Native code is already held to downstream, so pull requests that violate them fail GitHub CI instead of after merge:

- `experimental.require_dictionary_key_label`, `experimental.require_function_type_param_name`, `experimental.ban_explicit_exact_object_types`, `experimental.react_managed_attributes`, `experimental.jsx_intrinsic_elements`, `experimental.strict_es6_import_export` and `experimental.export_star_excludes_default`.
- The matching `unsuppressable_error_codes`, so these errors cannot be silenced with suppression comments.

Changelog: [Internal]

Differential Revision: D131543925
javache added a commit to javache/react-native that referenced this pull request Nov 13, 2026
Summary:

Enable the stricter Flow options that React Native code is already held to downstream, so pull requests that violate them fail GitHub CI instead of after merge:

- `experimental.require_dictionary_key_label`, `experimental.require_function_type_param_name`, `experimental.ban_explicit_exact_object_types`, `experimental.react_managed_attributes`, `experimental.jsx_intrinsic_elements`, `experimental.strict_es6_import_export` and `experimental.export_star_excludes_default`.
- The matching `unsuppressable_error_codes`, so these errors cannot be silenced with suppression comments.

Changelog: [Internal]

Differential Revision: D131543925
@javache
javache requested a review from cipolleschi November 13, 2026 19:00
Summary:

Enable the stricter Flow options that React Native code is already held to downstream, so pull requests that violate them fail GitHub CI instead of after merge:

- `experimental.require_dictionary_key_label`, `experimental.require_function_type_param_name`, `experimental.ban_explicit_exact_object_types`, `experimental.react_managed_attributes`, `experimental.jsx_intrinsic_elements`, `experimental.strict_es6_import_export` and `experimental.export_star_excludes_default`.
- The matching `unsuppressable_error_codes`, so these errors cannot be silenced with suppression comments.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D131543925
@github-actions

Copy link
Copy Markdown

Visual regression

1 visual difference(s) at 07a03567718d. Visual differences need maintainer approval. Review the report, then apply visual-change-approved.

ios scroll-view/scroll-to/end: Changed, 393801 px (54.422%)

diff

Expected and Captured
Expected Captured
expected captured

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant