Repository navigation
Conversation
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D131543925. |
javache
force-pushed
the
export-D131543925
branch
from
November 13, 2026 14:04
4fbcaa5 to
1d3aea7
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Nov 13, 2026
Summary: Enable the stricter Flow options that React Native code is already held to downstream, so pull requests that violate them fail GitHub CI instead of after merge: - `experimental.require_dictionary_key_label`, `experimental.require_function_type_param_name`, `experimental.ban_explicit_exact_object_types`, `experimental.react_managed_attributes`, `experimental.jsx_intrinsic_elements`, `experimental.strict_es6_import_export` and `experimental.export_star_excludes_default`. - The matching `unsuppressable_error_codes`, so these errors cannot be silenced with suppression comments. Changelog: [Internal] Differential Revision: D131543925
javache
added a commit
to javache/react-native
that referenced
this pull request
Nov 13, 2026
Summary: Enable the stricter Flow options that React Native code is already held to downstream, so pull requests that violate them fail GitHub CI instead of after merge: - `experimental.require_dictionary_key_label`, `experimental.require_function_type_param_name`, `experimental.ban_explicit_exact_object_types`, `experimental.react_managed_attributes`, `experimental.jsx_intrinsic_elements`, `experimental.strict_es6_import_export` and `experimental.export_star_excludes_default`. - The matching `unsuppressable_error_codes`, so these errors cannot be silenced with suppression comments. Changelog: [Internal] Differential Revision: D131543925
javache
force-pushed
the
export-D131543925
branch
from
November 13, 2026 14:06
1d3aea7 to
2d6f082
Compare
Summary: Enable the stricter Flow options that React Native code is already held to downstream, so pull requests that violate them fail GitHub CI instead of after merge: - `experimental.require_dictionary_key_label`, `experimental.require_function_type_param_name`, `experimental.ban_explicit_exact_object_types`, `experimental.react_managed_attributes`, `experimental.jsx_intrinsic_elements`, `experimental.strict_es6_import_export` and `experimental.export_star_excludes_default`. - The matching `unsuppressable_error_codes`, so these errors cannot be silenced with suppression comments. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D131543925
javache
force-pushed
the
export-D131543925
branch
from
November 13, 2026 19:10
2d6f082 to
07a0356
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary:
Enable the stricter Flow options that React Native code is already held to downstream, so pull requests that violate them fail GitHub CI instead of after merge:
experimental.require_dictionary_key_label,experimental.require_function_type_param_name,experimental.ban_explicit_exact_object_types,experimental.react_managed_attributes,experimental.jsx_intrinsic_elements,experimental.strict_es6_import_exportandexperimental.export_star_excludes_default.unsuppressable_error_codes, so these errors cannot be silenced with suppression comments.Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D131543925