Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On Android, a View with a percentage
borderRadiusandelevationcasts its shadow from an outline with corners that are too round.CompositeBackgroundDrawable.getOutlineresolves the radii againstbounds.width()andbounds.height(), which are in pixels, and then converts the result withdpToPx()again, so a percentage radius gets multiplied by the screen density. A 120x120 View withborderRadius: '25%'on a 3x screen casts a circle's shadow.BackgroundDrawable,BorderDrawableandOutlineDrawablealready resolve against the size in dp, so this does the same ingetOutline. Radii in dp don't change.Fixes #59962
Changelog:
[ANDROID] [FIXED] - Fix elevation shadow corners for Views with a percentage borderRadius
Test Plan:
Added
percentageRadiusIsResolvedAgainstTheSizeInDptoCompositeBackgroundDrawableTest: a 120x120 px drawable at density 2 withborderRadius: '25%'should get a 30 px outline radius. It fails on main (60 px) and passes with the change.