Skip to content

Preserve feature versions during burndown updates - #811

Merged
msarahan merged 2 commits into
rapidsai:mainfrom
msarahan:codex/fix-burndown-version-updater
Nov 10, 2026
Merged

msarahan merged 2 commits into
rapidsai:mainfrom
msarahan:codex/fix-burndown-version-updater

Conversation

@msarahan

@msarahan msarahan commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

In past releases, the update-version.sh script would incorrectly reset feature versions, requiring manual fixes such as #769. This PR corrects the update version behavior and adds tests for correct behavior.

Release preparation must not reset feature patches to the repository's .00
version, especially when changing the build-utils source manifest. Preserve
same-series feature versions and increment build-utils only when that generated
payload changes. Keep new-series initialization and make repeat updates
idempotent so a retry does not introduce another feature patch.

Add a focused local regression script covering patch preservation, payload
changes, repeated updates and new-series initialization. Leave CI, metadata
integration and unrelated updater behavior unchanged to keep this review small.

Validation: the regression fails on the original updater and passes with BSD
and GNU sed; fixture ShellCheck and repository pre-commit checks pass.
Exercise feature patch preservation and idempotence in the existing ShellCheck job so updater regressions are caught in CI. Install the updater’s existing packaging prerequisite and lint the fixture script alongside the current shell checks.
@msarahan
msarahan requested a review from a team as a code owner November 9, 2026 21:45
@msarahan
msarahan requested review from bdice and removed request for a team November 9, 2026 21:45
@msarahan
msarahan merged commit b91d735 into rapidsai:main Nov 10, 2026
399 of 409 checks passed
@msarahan
msarahan deleted the codex/fix-burndown-version-updater branch November 10, 2026 01:56
@msarahan

Copy link
Copy Markdown
Contributor Author

Followup:

The original incorrect behavior

Screenshot 2026-11-10 at 8 02 35 PM

The update-version script would just reset rapids-buiid-utils feature version.

The equivalent update from today:

Screenshot 2026-11-10 at 8 01 39 PM

I think this is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants