Skip to content

Implementing dedicated function for full text search filtering - #86

Merged
generall merged 3 commits into
qdrant:devfrom
no-materials:dedicated-function-for-full-text-search-filter
Jan 27, 2024
Merged

generall merged 3 commits into
qdrant:devfrom
no-materials:dedicated-function-for-full-text-search-filter

Conversation

@no-materials

@no-materials no-materials commented Dec 29, 2023 •

Copy link
Copy Markdown
Contributor

This PR addresses #85 which denotes that in order to use the full text search filter, a hacky workaround of inserting whitespace is required. This PR implements a dedicated function (matches_text) for initiating a full text-search, reflecting the python client's api.
Existing implementations of the full text search will continue to work as before.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@no-materials
no-materials marked this pull request as ready for review December 29, 2023 16:04
@generall
generall requested a review from agourlay January 5, 2024 18:14

@generall generall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM

@generall
generall requested review from timvisee and removed request for agourlay January 5, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants