Repository navigation
Hide pending new settings from the active mapping - #1351
Open
iamabhisheknag wants to merge 1 commit into
Open
iamabhisheknag wants to merge 1 commit into
iamabhisheknag wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A newly proposed setting raises
KeyErroron lookup until its first acknowledgement, but currently appears in iteration and length. Consequently,dict(settings)and iteration oversettings.items()can raiseKeyErrorwhile an update is in flight, including afterH2Connection.update_settings().Filter those pending keys from iteration and count only visible keys. Acknowledgement still activates the queued value; the regressions cover a new known/extension setting, repeated proposals, and deletion before acknowledgement.
Local validation on Python 3.14: 1,688 tests pass with 100% line and branch coverage; required Ruff and mypy checks pass. Three new cases fail before the fix. An in-memory client/server exchange confirms settings are transmitted and become visible after ACK.
AI assistance: OpenAI coding assistant (GPT-6).