Repository navigation
tipb: backport Local MATCH protocol to release-8.5 (#439) - #440
Merged
solotzg merged 2 commits intoNov 10, 2026
Merged
Conversation
…ngcap#432) - Add LocalMatchAgainstBoolean (5250) and a versioned Boolean query payload carried in Expr.val, keeping SQL arguments in Expr.children. - Define required, optional and prohibited word, phrase and prefix clauses, STANDARD/NGRAM analyzer settings, and built-in stopword configuration with independent stopword collation. - The protocol supports row-wise Local MATCH scalar execution without index lookup.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
solotzg
marked this pull request as ready for review
November 10, 2026 07:28
AilinKid
approved these changes
Nov 10, 2026
qw4990
approved these changes
Nov 10, 2026
solotzg
changed the title
This was referenced Nov 11, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Backport the Local MATCH Boolean protocol to
release-8.5so the release branch can carry the same TiDB/TiFlash wire format.ref #439
What is changed and how does it work?
LocalMatchAgainstBoolean = 5250, its query/node messages, and analyzer enums toproto/expression.proto.scripts/proto.lock.This uses the protocol change already merged into
feature/release-8.5-ftsby #432 and matches the master protocol PR #439. Keep this PR in draft until #439 merges.Checks
feature/release-8.5-fts.git diff --checkand JSON parsing ofscripts/proto.lockpassed.release-8.5baseline has existing protolock drift across unrelated protocol fields and does not containscripts/check.sh. This PR adds only the Local MATCH definitions rather than resetting the baseline lock snapshot.