Repository navigation
Conversation
Comment on lines
+258
to
262
| /** | ||
| * @param callable(bool): Type $left | ||
| * @param callable(bool): Type $right | ||
| */ | ||
| $andVerdict = static fn (callable $left, callable $right): callable => static function (bool $nativeTypesPromoted) use ($left, $right): Type { |
Contributor
There was a problem hiding this comment.
I'm unsure such phpdoc for closure
Contributor
Author
There was a problem hiding this comment.
Sorry, I'm not sure I understand what you mean. Could you please clarify?
Contributor
There was a problem hiding this comment.
See https://phpstan.org/r/8a0dae54-39f1-4eb2-aed9-552a80b9fc80
The phpdoc is not used.
- No type inference
- No error reported
Contributor
Author
There was a problem hiding this comment.
That's an unrelated issue I would say
Contributor
There was a problem hiding this comment.
If the phpdoc is not used at all, it's useless to add it here
Contributor
Author
There was a problem hiding this comment.
I'm happy to add support for it as well if that's desired, but I think that should go in a separate PR.
AJenbo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just adding a few missing types, should be the last of the type clean up for now.