Know the static Html::text() and Html::html() factories

src/Reflection/Nette/HtmlClassReflectionExtension.php

@@ -7,13 +7,15 @@
 use PHPStan\Reflection\MethodsClassReflectionExtension;
 use PHPStan\Reflection\PropertiesClassReflectionExtension;
 use PHPStan\Reflection\PropertyReflection;
+use function in_array;
 
 class HtmlClassReflectionExtension implements MethodsClassReflectionExtension, PropertiesClassReflectionExtension
 {
 
 	public function hasMethod(ClassReflection $classReflection, string $methodName): bool
 	{
-		return $classReflection->is('Nette\Utils\Html');
+		// The static factories declared in the stub, which would otherwise be taken for attribute setters
+		return $classReflection->is('Nette\Utils\Html') && !in_array($methodName, ['text', 'html'], true);
 	}
 
 	public function getMethod(ClassReflection $classReflection, string $methodName): MethodReflection

stubs/Utils/Html.stub

@@ -5,6 +5,8 @@ namespace Nette\Utils;
 /**
  * @implements \IteratorAggregate<int, self|string>
  * @implements \ArrayAccess<int, self|string>
+ * @method static static text(mixed $text)
+ * @method static static html(mixed $html)
  */
 class Html implements \ArrayAccess, \IteratorAggregate
 {

tests/Reflection/Nette/HtmlClassReflectionExtensionTest.php

@@ -28,10 +28,22 @@ public function dataHasMethod(): array
 		return [
 			[
 				Html::class,
+				'href',
 				true,
 			],
+			[
+				Html::class,
+				'text',
+				false,
+			],
+			[
+				Html::class,
+				'html',
+				false,
+			],
 			[
 				stdClass::class,
+				'href',
 				false,
 			],
 		];
@@ -40,10 +52,10 @@ public function dataHasMethod(): array
 	/**
 	 * @dataProvider dataHasMethod
 	 */
-	public function testHasMethod(string $className, bool $result): void
+	public function testHasMethod(string $className, string $methodName, bool $result): void
 	{
 		$classReflection = $this->reflectionProvider->getClass($className);
-		self::assertSame($result, $this->extension->hasMethod($classReflection, 'href'));
+		self::assertSame($result, $this->extension->hasMethod($classReflection, $methodName));
 	}
 
 	public function testGetMethod(): void

tests/Rule/Nette/HtmlStaticFactoriesTest.php

@@ -0,0 +1,32 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rule\Nette;
+
+use PHPStan\Rules\Methods\CallStaticMethodsRule;
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+
+/**
+ * @extends RuleTestCase<CallStaticMethodsRule>
+ */
+class HtmlStaticFactoriesTest extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return self::getContainer()->getByType(CallStaticMethodsRule::class); // @phpstan-ignore phpstanApi.classConstant
+	}
+
+	public function testRule(): void
+	{
+		$this->analyse([__DIR__ . '/data/html-static-factories.php'], []);
+	}
+
+	public static function getAdditionalConfigFiles(): array
+	{
+		return [
+			__DIR__ . '/../../../extension.neon',
+		];
+	}
+
+}

tests/Rule/Nette/data/html-static-factories.php

@@ -0,0 +1,12 @@
+<?php
+
+namespace HtmlStaticFactories;
+
+use Nette\Utils\Html;
+
+function factories(): Html
+{
+	$text = Html::text('text');
+	$html = Html::html('<b>html</b>');
+	return $text->addHtml($html);
+}