Skip to content

Upgrade Bootstrap and jQuery - #133

Merged
MauricioFauth merged 1 commit into
phpmyadmin:masterfrom
MauricioFauth:bootstrap-jquery
Oct 15, 2020
Merged

MauricioFauth merged 1 commit into
phpmyadmin:masterfrom
MauricioFauth:bootstrap-jquery

Conversation

@MauricioFauth

Copy link
Copy Markdown
Member
  • Upgrades Bootstrap to v4.5.3
  • Upgrades jQuery to v3.5.1

Fixes #131.

@codecov

codecov Bot commented Oct 14, 2020

Copy link
Copy Markdown

Codecov Report

Merging #133 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   63.37%   63.37%           
=======================================
  Files          65       65           
  Lines        1417     1417           
=======================================
  Hits          898      898           
  Misses        519      519           

@MauricioFauth
MauricioFauth marked this pull request as ready for review October 14, 2020 17:51
- Upgrades Bootstrap to v4.5.3
- Upgrades jQuery to v3.5.1

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@MauricioFauth

Copy link
Copy Markdown
Member Author

Screenshot from 2020-10-14 14-59-45

@williamdes williamdes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks clean !

@MauricioFauth
MauricioFauth merged commit 2189054 into phpmyadmin:master Oct 15, 2020
@MauricioFauth
MauricioFauth deleted the bootstrap-jquery branch October 15, 2020 11:56
@MauricioFauth MauricioFauth self-assigned this Oct 15, 2020
@ibennetch

ibennetch commented Oct 18, 2020 •

Copy link
Copy Markdown
Member

On mobile displays, this seems to cause a display issue with the hamburger menu, at least on iOS. I haven't tested with Android yet.

image

@MauricioFauth

Copy link
Copy Markdown
Member Author

Thank you for noticing that. I will fix it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Bootstrap

3 participants