Repository navigation
ci: publish only to Open VSX and fix production docs deploy - #382
Merged
Merged
Conversation
VS Code Marketplace publication is now manual: drop the vsce step and the VSCE_PAT requirement, and keep Open VSX automated. Add a workflow_dispatch entry point that republishes artifacts from an existing run so a failed publish can be retried without cutting a new release. Production docs could not deploy: ossutil 1.7 rejects --include/--exclude patterns containing directory separators (getFilter splits the pattern and fails), so 'preview/*' and 'staging/*' were invalid and the whole step errored out. Sync every production top-level entry instead: --delete then stays scoped to production paths and the preview/staging prefixes survive. Also expose the docs deploy as workflow_dispatch(tag) to redeploy an existing tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The 1.3.0 release could not finish its post-publish jobs:
Access Denied: The Personal Access Token used has expired.(theVSCE_PATsecret expired), which alsoskipped Open VSX because it runs after the Marketplace step.
Error: --include or --exclude does not support format containing dir info,so vide.pascal-lab.net still serves the previous docs.
steps cannot be retried for an already published tag.
Changes
vscepublishstep, the
VSCE_PATrequirement and the now-unusednpm ci. Open VSX staysautomated. Maintainers publish the Marketplace build with
vsce publish --packagePath <vsix>.publish-vsix.ymlnow has aworkflow_dispatchentrytaking
source-refandrun-id, so artifacts from an existing run can bepublished without cutting a new release.
--include/--excludeagainstfile names only:
getFiltersplits the pattern and rejects anything with adirectory separator, which is why
--exclude 'preview/*'failed outright.The step now syncs every production top-level entry of the build output
individually, so
--deletestays scoped to production paths and thepreview/andstaging/prefixes are never touched.publish-docs.ymlnow also acceptsworkflow_dispatchwith ataginput, so docs for an already publishedrelease can be redeployed on their own.
Trade-off
With per-entry sync, a removed top-level build output would linger in the
bucket (nested paths are still deleted by
--delete). This is called out in acomment next to the step.
Verification
verified that the new per-entry
sync/cpcommands pass argument parsing(they only fail later at the dummy endpoint, as expected).
1.3.0can be completed after merge:Publish production docswithtag: v1.3.0;Publish VSIX to Open VSXwithsource-ref: v1.3.0and
run-id: 44035663359(the 1.3.0 release run).