Skip to content

choose_password template shows "undefined" for username — username param missing from reset redirect URL #10245

Open

Description

@DylanBanta-WM

New Issue Checklist

Issue Description

The choose_password password reset page displays "New Password for undefined" because the username query parameter is not included in the redirect URL generated by PublicAPIRouter.js, despite the template expecting it.

Steps to reproduce

  1. Call requestPasswordReset for any user
  2. Click the reset link sent via email
  3. Observe the label on the reset page reads "New Password for undefined"

Actual Outcome

The page renders: "New Password for undefined"

Expected Outcome

The page should render: "New Password for " (or the app name)

The comment at the top of the choose_password template explicitly states:

"The query params 'username' and 'app' hold the friendly names for your current user and your app."

However, requestResetPassword() in PublicAPIRouter.js only includes token, id, and app in the redirect username is absent:

const params = querystring.stringify({
token,
id: config.applicationId,
app: config.appName
// username is missing
});

While the template at line 184 reads:

document.getElementById('username_label').appendChild(document.createTextNode(urlParams['username']));

Activity

  1. parse-github-assistant commented on Mar 19, 2026

    @parse-github-assistant

    🚀 Thanks for opening this issue!

    ℹ️ You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

  2. mtrezza commented on Mar 19, 2026

    @mtrezza
    Member

    Yes, username has been removed. Template requires a change.

  3. added
    type:bugImpaired feature or lacking behavior that is likely assumed
    on Mar 20, 2026
  4. Rishabh-1098git commented on May 20, 2026

    @Rishabh-1098git

    @mtrezza -
    Hi, I’d like to take a look at this issue.

    From the description, it seems the choose_password template expects a username query param, but the reset redirect URL generated in PublicAPIRouter.js does not include it, which results in the UI rendering "New Password for undefined".

    I’ll reproduce the flow locally and verify whether the correct fix is to pass the username through the reset redirect params (or gracefully handle its absence in the template) before opening a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type:bugImpaired feature or lacking behavior that is likely assumed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions