Repository navigation
the default set container demands nothing of its element - #54
Merged
Merged
Conversation
The default set type renders a Vec and never used the ordering traits it demanded, so a set whose elements cannot be compared failed at finalize for no reason the output needed. A uniqueItems array records that the source promised distinct elements, not that the element type is comparable; iddqd's IdOrdMap marks its array uniqueItems because key uniqueness implies element uniqueness, and its elements carry floats. The obligation now lives only on a configured set container (BTreeSet, HashSet), where the compiler demands it. The tests that asserted the old default's demand configure a BTreeSet explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default set type renders a Vec and never used the ordering traits it demanded, so a set whose elements cannot be compared failed at finalize for no reason the output needed. A uniqueItems array records that the source promised distinct elements, not that the element type is comparable; iddqd's IdOrdMap marks its array uniqueItems because key uniqueness implies element uniqueness, and its elements carry floats. The obligation now lives only on a configured set container (BTreeSet, HashSet), where the compiler demands it. The tests that asserted the old default's demand configure a BTreeSet explicitly.