Repository navigation
compile string constraint patterns with the u flag - #49
Merged
Merged
Conversation
JSON Schema patterns carry ECMA-262 unicode semantics, and the JSON
Schema test suite expects them on every draft; without the flag a
unicode property escape does not match and an escape like \p{L} can
accept strings the pattern rejects. The emitted LazyLock now builds the
regex with Regex::with_flags(p, "u"), as typify does on main (#1103).
A pattern with an identity escape the u flag forbids fails in the
consumer's build, where it failed to match before; typespace does not
compile patterns at build time, since regress is only a dev dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON Schema patterns carry ECMA-262 unicode semantics, and the JSON Schema test suite expects them on every draft; without the flag a unicode property escape does not match and an escape like \p{L} can accept strings the pattern rejects. The emitted LazyLock now builds the regex with Regex::with_flags(p, "u"), as typify does on main (#1103). A pattern with an identity escape the u flag forbids fails in the consumer's build, where it failed to match before; typespace does not compile patterns at build time, since regress is only a dev dependency.
See oxidecomputer/typify#1103