[haircommander]

No description provided.

[openshift-merge-bot]

Pipeline controller notification

This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration.

Use /test ? to list jobs and /pipeline help for commands.

[openshift-ci-robot]

@haircommander: This pull request references OCPNODE-4886 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @haircommander! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The changes enable GomaxprocsInjection in additional feature sets and update its feature-gate manifests and feature table. The Default and OKD KubeletConfig schemas add the systemGomaxprocsBehavior field. The FeatureGateKarpenterOperator registration is removed. Four ContainerRuntimeConfig CRD manifests are deleted, and a feature-set annotation is removed from another manifest.

Suggested reviewers: rvanderp3

Merge Risk: Minimal · up to dc517

This change promotes GomaxprocsInjection to enabled in the Default and OKD feature sets and adds the systemGomaxprocsBehavior field to KubeletConfig. No concrete merge-blocking defect was established. The failing verify-feature-promotion CI check should be looked at before merge.

Pre-merge checks: 14 · 1

Failed checks: 1 inconclusive

Check name	Status	Explanation	Resolution
Description check		The author did not provide a description, so this check cannot assess whether it relates to the changeset.	Add a brief description of the Gomaxprocs feature updates and related changes.

Passed checks: 14 passed

Check name	Status	Explanation
Title check		The title clearly identifies the Gomaxprocs feature update to GA, which is a main change in the pull request.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names		The PR changes feature gates, documentation, and CRD manifests. It does not add or change Ginkgo test titles.
Test Structure And Quality		The PR does not add or change Ginkgo test code. The test-quality requirements do not apply.
Microshift Test Compatibility		The PR adds no Ginkgo e2e tests. The only changed Go file updates feature-gate configuration.
Single Node Openshift (Sno) Test Compatibility		The PR adds no Ginkgo e2e tests. The changed files contain feature-gate declarations, documentation, and generated manifests.
Topology-Aware Scheduling Compatibility		The PR changes feature gates and CRD schemas. It does not modify deployment manifests, operator code, or controllers, or introduce the listed scheduling constraints.
Ote Binary Stdout Contract		The PR changes feature-gate registration and generated manifests. The changed initializer updates feature-set membership without writing to stdout. No OTE process-level stdout write was introduced.
Ipv6 And Disconnected Network Test Compatibility		The PR adds no Ginkgo e2e tests. The diff changes feature gates, documentation, and CRD manifests, so this check does not apply.
No-Weak-Crypto		The diff changes feature gates and CRD manifests. It does not introduce weak cryptography, custom cryptography, or secret comparisons.
Container-Privileges		The PR changes feature gates and CRD schemas. It does not add container manifests or the listed privilege settings.
No-Sensitive-Data-In-Logs		The diff changes feature gates and CRD manifests. It adds no logging or evidence of sensitive data exposure in logs.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (9 skipped: 9 unsupported.)

Warning

Some tools did not complete. Review the errors below.

golangci-lint (2.15.0)

golangci-lint (2.15.0) skipped for .golangci.yaml: configuration contains disallowed or uninspectable plugin or linter settings. Use supported built-in linters.

Recent review info

Run configuration

• Source mode: Auto
• Repository: openshift/api
• Branch: master
• File: .coderabbit.yaml
• Commit: f6e8a08
• Layers: Repository YAML (base), Central YAML (inherited)
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 11435492-83c6-4d8e-8b7f-f59e7603a31f

Commits

Reviewing files that changed from the base of the PR and between f6e8a08 and dc517a3.

Files ignored due to path filters: 7

• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_containerruntimeconfigs-Default.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_containerruntimeconfigs-DevPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_containerruntimeconfigs-OKD.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_containerruntimeconfigs-TechPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_containerruntimeconfigs.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_kubeletconfigs-Default.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_kubeletconfigs-OKD.crd.yaml is excluded by !**/zz_generated.crd-manifests/*

Files selected for processing: 15

• features.md
• features/features.go
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-Default.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-DevPreviewNoUpgrade.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-OKD.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-TechPreviewNoUpgrade.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_kubeletconfigs-Default.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_kubeletconfigs-OKD.crd.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-5-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-5-10-SelfManagedHA-OKD.yaml

Files with no reviewable changes: 5

• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-Default.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-TechPreviewNoUpgrade.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-OKD.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_containerruntimeconfigs-DevPreviewNoUpgrade.crd.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@haircommander: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-feature-promotion	dc517a3	link	true	/test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[everettraven]

@haircommander Looks like there are no tests for the feature as of yet - are those in the works?

[haircommander]

yes! we have the node isolated job https://prow.ci.openshift.org/view/gs/test-platform-results-public/logs/openshift-origin-31875-nightly-5.1-e2e-aws-nodes-isolated-techpreview-1of2/2121025792686166016
I've recently added more tests for it openshift/origin#31875 and we're increasing the frequency openshift/release#88654 and I'm about to open a PR to increase the cluster types it's running on (other clouds to start, I have to update the job to work for metal)

I think this feature will need an override to merge, because they require tuning the node which is too disruptive for the remaining e2e suite. it also is more efficient to combine tests rather than separate, so we won't actually have 5 ginkgo.Its, but we do have 5 scenarios that are now being tested.