Repository navigation
Conversation
The posix storage publishes UploadReady with an empty UploadID when it assimilates a file it found on disk. There is no upload session behind such an event, so the lookup in the upload store failed with "nats: invalid key" and logged two errors per file. Skip these events, like PostprocessingStepFinished already does for on demand scans.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 5 |
🟢 Coverage 100.00% diff coverage · +0.02% coverage variation
Metric Results Coverage variation ✅ +0.02% coverage variation (-1.00%) Diff coverage ✅ 100.00% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (9347da7) 93680 27017 28.84% Head commit (ade9daa) 93682 (+2) 27034 (+17) 28.86% (+0.02%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#3966) 3 3 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
dschmidt
force-pushed
the
fix/postprocessing-uploadready-without-upload
branch
2 times, most recently
from
November 11, 2026 23:57
bb655a6 to
ade9daa
Compare
dschmidt
marked this pull request as ready for review
November 11, 2026 23:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The posix storage publishes
UploadReadywith an emptyUploadIDwhen it assimilates a file it found on disk. Postprocessing looks that ID up in its upload store, which fails and logs two errors per file:There is no upload session behind such an event, so this skips it, the same way
PostprocessingStepFinishedalready skips an emptyUploadIDfor on demand scans. Nothing else changes: the event was dropped after the failed lookup before, too.Tested with two new unit specs (empty ID is ignored, unknown non-empty ID still returns
ErrEvent). Not tested against a running instance.AI usage: the cause was found while debugging an installation with Claude Code (claude-fable-5-2), which also wrote the patch and the tests.