Skip to content

fix(graph): report the space name instead of "." for space roots in sharedByMe - #3939

Merged
butonic merged 2 commits into
opencloud-eu:workpagagesfrom
dragonchaser:backport-wp2-746
Nov 10, 2026
Merged

butonic merged 2 commits into
opencloud-eu:workpagagesfrom
dragonchaser:backport-wp2-746

Conversation

@dragonchaser

Copy link
Copy Markdown
Member

Drive item names were derived from the resource path, so shared project spaces showed up as "."; use the storage provider's name (falling back to the path's base name) and update the sharedByMe acceptance scenario accordingly.

The drive item name was derived from the resource path. Space roots
have no path ("."), so e.g. the sharedByMe response reported "." as
the name of a shared project space. Use the name provided by the
storage provider and fall back to the base of the path if it is empty.

Adjust the sharedByMe acceptance scenario for link shares of a
project space accordingly: the space root item now carries the name of
the space.
@codacy-production

codacy-production Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Not up to standards ⛔

🟢 Coverage 100.00% diff coverage · +0.00% coverage variation

Metric Results
Coverage variation ✅ +0.00% coverage variation (-1.00%)
Diff coverage ✅ 100.00% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (83615f2) Report Missing Report Missing Report Missing
Head commit (25534bb) 92643 (+3) 25423 (+5) 27.44% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3939) 5 5 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

1 Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@dragonchaser dragonchaser added the Type:Maintenance E.g. technical debt, packaging, etc. label Nov 10, 2026
@dragonchaser
dragonchaser marked this pull request as ready for review November 10, 2026 14:32

@butonic butonic left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faithful port of owncloud/ocis#11538 👍

@butonic
butonic merged commit c292fc9 into opencloud-eu:workpagages Nov 10, 2026
60 of 61 checks passed
@dragonchaser
dragonchaser deleted the backport-wp2-746 branch November 11, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type:Maintenance E.g. technical debt, packaging, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants